From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: tags-loop-continue Date: Sun, 10 Jan 2016 19:14:14 +0300 Message-ID: <56928356.2000609@yandex.ru> References: <83wprimto9.fsf@gnu.org> <56916C10.6050004@yandex.ru> <83oacumqmj.fsf@gnu.org> <56917246.1010800@yandex.ru> <5691795E.9010008@yandex.ru> <83lh7ym725.fsf@gnu.org> <5691D768.3020908@yandex.ru> <83bn8tmnvq.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1452442483 2469 80.91.229.3 (10 Jan 2016 16:14:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Jan 2016 16:14:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 10 17:14:36 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aIIdX-0005lx-Mw for ged-emacs-devel@m.gmane.org; Sun, 10 Jan 2016 17:14:35 +0100 Original-Received: from localhost ([::1]:47563 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIIdW-0002xi-Pq for ged-emacs-devel@m.gmane.org; Sun, 10 Jan 2016 11:14:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIIdI-0002xL-Qw for emacs-devel@gnu.org; Sun, 10 Jan 2016 11:14:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIIdE-0003zm-QV for emacs-devel@gnu.org; Sun, 10 Jan 2016 11:14:20 -0500 Original-Received: from mail-lb0-x236.google.com ([2a00:1450:4010:c04::236]:36555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIIdE-0003zJ-JW; Sun, 10 Jan 2016 11:14:16 -0500 Original-Received: by mail-lb0-x236.google.com with SMTP id oh2so243721471lbb.3; Sun, 10 Jan 2016 08:14:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=zNVYuPuWw89hbhA5ihjHwAgh6LmwFxrqU4+QITTqhC4=; b=zo/UnW6T0ZRTATUd9mo4UBjXn/OIkBxKp9uSxblfdApYDwqH5eVPQ8zAT+pIQYRBoN d61cjhWIOcMCT11WSJmi9wMovVSNSSqSywkH/8IAaxpSLxU19RRD7yU37kK9f+q6nHN1 p2jJDITcnme6D9s7KYdBEjU3XxY9uYcjOHbPDrzcyRnC5kZiyh9OAxJDgiZ/M+gI8tKE LrNsDOFPmfVvvoNNcIv41NTMqtXIIfB7ZsvX+mU2/ENhks4ZFy0ptykXJfPw20dMG+fK ix32m5d+PmPIQKai3X4kKFFUmiqn3qqFPHq5WF9mcXlM6P9vz/VOeHT3cJeozr7YYvKU I5bA== X-Received: by 10.112.135.39 with SMTP id pp7mr6160783lbb.43.1452442455824; Sun, 10 Jan 2016 08:14:15 -0800 (PST) Original-Received: from [192.168.1.190] ([178.252.127.222]) by smtp.googlemail.com with ESMTPSA id q76sm16073715lfd.41.2016.01.10.08.14.14 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 10 Jan 2016 08:14:14 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Thunderbird/43.0 In-Reply-To: <83bn8tmnvq.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197978 Archived-At: On 01/10/2016 06:54 PM, Eli Zaretskii wrote: > I think you've just heard from someone who evidently does use them: > > http://lists.gnu.org/archive/html/emacs-devel/2016-01/msg00627.html But not with default key bindings. I'd classify Ingo's message as an evidence that we're allowed not to care too much about the default binding. >> C-, is too nice a key binding to spend on them. > > You mean 'M-,', I presume. Yes, sorry. >> If we want to retain some global binding for tags-loop-continue, let's move it to C-*. > > I'm afraid it won't go down well with the users of those commands. None of the early adopters complained thus far. In any case, we're changing a lot of things already. The most curmudgeonly users will have a lot to complain about anyway. > Besides, 'C-*' is not available on TTYs. And here, I meant 'M-*'. The binding formerly used by pop-tag-mark. > I asked "how", not "where". This command (tags-loop-continue) existed > before and had a keybinding; it will also exist in Emacs 25.1 -- how > do we explain that it now has a different keybinding, or no keybinding > at all? What good reasons do we give for such a backward-incompatible > change in a veteran command? The command won't change--only its bindings. Because we expect it to be used considerably less often from now on. >> Other than that, what technical solution is used to keep the command >> and its keybinding available is unimportant, I think. >> >> It doesn't seem like tags-search uses any special keymap during its execution. > > I didn't talk about tags-search, I'm talking only about > tags-loop-continue. Because tags-query-replace uses a special keymap, we can bind tags-loop-continue to M-, in it. _Maybe_ we can similarly use a new keymap during tags-search's execution. If you think it's a good idea, I can look into it. On the flip side, the users may get confused that M-, is bound to different commands in different contexts. > I think it should remain an interactive command > (so it could be easily rebound and invoked by name), and it should be > bound to 'M-,' as it was before. I will stick out like a sore thumb, being entirely useless with the xref interface, and only serving the more obscure use cases. Let's not take up the handy key combination just for that. > We will need to find a new binding > for xref-query-replace, which is unfortunate, but I don't see a better > way forward. Apparently you mean xref-pop-marker-stack. See the two proposed ways forward described above (use M-*, or only set up the M-, binding during tags-search and tags-query-replace).