From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jussi Lahdenniemi Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Override Windows default Win-* key combinations when using Emacs Date: Tue, 5 Jan 2016 21:41:02 +0200 Organization: Aprikoodi Oy Message-ID: <568C1C4E.50200@aprikoodi.fi> References: <568BBC58.50702@aprikoodi.fi> <83y4c43qkh.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1452022904 9648 80.91.229.3 (5 Jan 2016 19:41:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Jan 2016 19:41:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 05 20:41:33 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aGXU4-0007oY-Au for ged-emacs-devel@m.gmane.org; Tue, 05 Jan 2016 20:41:32 +0100 Original-Received: from localhost ([::1]:51273 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGXU3-0000e6-PQ for ged-emacs-devel@m.gmane.org; Tue, 05 Jan 2016 14:41:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGXTq-0000dI-Et for emacs-devel@gnu.org; Tue, 05 Jan 2016 14:41:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGXTn-0003E6-6s for emacs-devel@gnu.org; Tue, 05 Jan 2016 14:41:18 -0500 Original-Received: from nbjjceehcbh.turbo-smtp.net ([199.244.72.17]:19639) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1aGXTn-0003E1-0L for emacs-devel@gnu.org; Tue, 05 Jan 2016 14:41:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aprikoodi.fi; s=turbo-smtp; x=1452627674; h=DomainKey-Signature: Received:Received:Subject:To:References:Cc:From:Organization: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=KYVNJ0rzq5Q/hCUrCG3yCuodTkh7v/mWeu AhjiEaU9s=; b=QeugM4T0/8ebPsZQKzxEr9JyR3HuiqrxjKaKgKKGkuiAVxiSb2 hpwFwLD1ke0WzDH690C4faIr05Mh2vYt3GMRvGupu39sNuEe0p2bhFM3XCUgG9rT g0G8aCQPdz/o2Xn2sJvTAJ6inuxjrWozRxcTnAY9JhyXQS2VqSumll73w= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=turbo-smtp; d=aprikoodi.fi; h=Received:Received:X-TurboSMTP-Tracking:Subject:To:References:Cc:From:Organization:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=B+RW6CVlRiGoNCtffXA49w3RVoQQO2O6AYaLeRIdB44XpZ1JK/1sWUBO4o0Qvq v+6a3ZUmoDRlxugwZG3EmIeyIRBLTYb3CCW/3A7GLaakXKQYWgMY2q+r1oD2vJge 9smc7QTerHlJGmt1WLKkBJSsjNzVYPhpr8CkrYys22IZs=; Original-Received: (qmail 5461 invoked from network); 5 Jan 2016 19:41:14 -0000 Original-Received: from unknown (HELO ?192.168.100.12?) (authenticated@109.240.10.34) by turbo-smtp.com with SMTP; 5 Jan 2016 19:41:13 -0000 X-TurboSMTP-Tracking: 2716823305 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 In-Reply-To: <83y4c43qkh.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 199.244.72.17 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197675 Archived-At: > Thank you for your contribution. It is large enough to require legal > paperwork; I can send you the forms off-list if you agree. Sure! > As for the patch: why does this have to be an external program? Can't > Emacs itself do this job? Doing part of Emacs's keyboard input in a > separate process has several downsides, so I think it should be > avoided if possible. While submitting the change, I thought about this as well. I wrote the code four years ago, and could not remember why I chose this approach; possibly both for better performance when several emacses are running and for smaller changes in the core emacs code (as that was the first time I touched the emacs code base). I'll see how much it would take to incorporate the code in the emacs process. > Also, did you try this with the latest Emacs sources? The way > keyboard input works in Emacs on Windows has changed several months > ago. Yes, this patch was done on the latest emacs master branch on git. Also, I verified that the w32-register-hot-key does not do the job for the Windows key combinations. > Finally, will this also work in the console (a.k.a. "TTY") session, or > just in GUI sessions? No, it currently only works for GUI. Supporting the console would require some additional code (to check if the currently active window is a console running Emacs, basically) but it could be done. I'll check this as well. -- Jussi Lahdenniemi