From: Paul Eggert <eggert@cs.ucla.edu>
To: Emacs development discussions <emacs-devel@gnu.org>
Subject: merge from emacs-25 to master lost a line
Date: Mon, 4 Jan 2016 17:43:06 -0800 [thread overview]
Message-ID: <568B1FAA.2000302@cs.ucla.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 1974 bytes --]
The recent merge from emacs-25 to master lost the attached one-line
spelling fix for test/automated/url-parse-tests.el that was originally
installed in emacs-25 commit c9dfe5121cb31aa1e8cf352e5088940fc5dd7106
dated 2015-12-26. This fix was lost even though the commit and change is
listed in the master branch now. I fixed the problem in master as part
of commit 61e83e902b388490b609677a76f3d49740439f24 dated 2016-01-04.
Although this particular bug is both minor and fixed now, I worry that
there may be similar problems elsewhere.
I suspect the problem arose due to the big renaming of tests in commit
22bbf7ca22f11cc33d887d0162cf2ec6661c3a3e dated 2015-11-23, which renamed
a bunch of test files, e.g., from test/automated/url-util-tests.el to
test/lisp/url/url-util-tests.el. It looks like this renaming means that
if emacs-25 adds a test (under the old naming scheme) and then later
changes the test (also under the old naming scheme), the later change
will be lost when be merging to master.
If my analysis is correct, I suggest two things:
* First, when merging to master we have to be careful about the renamed
tests. I suppose somone (I hope it's not me) could go through all the
emacs-25 changes to tests renamed in master, and check that the changes
are properly merged to master.
* Second, to help avoid this problem in the future we should avoid
making wholesale renames to master right now. They're not worth the
hassle. That is, it's OK to add stuff to master, but let's not rename
files in master unless we really need to.
Some nearby problems in master (don't know if they're related): Commits
8dea6fe5b5bc2936b046e799ea61afc508e28752 and
b792ecea1715e080ad8e232d3d154b8a25d2edfb (both dated 2015-12-26) both
have commit logs mentioning test/lisp/url/url-parse-tests.el, but
neither in fact changes that file. Commit
1dee11d874de5ff3d5634e1629054c4398b27b72 (also dated 2015-12-26) creates
the file without the spelling fix.
[-- Attachment #2: spellfix.diff --]
[-- Type: text/x-patch, Size: 910 bytes --]
diff --git a/test/automated/url-parse-tests.el b/test/automated/url-parse-tests.el
index 154e091..443034a 100644
--- a/test/automated/url-parse-tests.el
+++ b/test/automated/url-parse-tests.el
@@ -156,7 +156,7 @@
;; example mentioned in RFC3986, section 5.4. Reference Resolution Examples
(should (equal (url-generic-parse-url "http://a/b/c/d;p?q") (url-parse-make-urlobj "http" nil nil "a" nil "/b/c/d;p?q" nil nil t))))
-(ert-deftest url-generic-parse-url/same-decument-reference ()
+(ert-deftest url-generic-parse-url/same-document-reference ()
"RFC 3986, section 4.4. Same-Document Reference / same-document reference: empty or number sign (\"#\") followed by a fragment identifier"
(should (equal (url-generic-parse-url "") (url-parse-make-urlobj nil nil nil nil nil "" nil nil nil)))
(should (equal (url-generic-parse-url "#") (url-parse-make-urlobj nil nil nil nil nil "" "" nil nil)))
next reply other threads:[~2016-01-05 1:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 1:43 Paul Eggert [this message]
2016-01-07 22:31 ` merge from emacs-25 to master lost a line Phillip Lord
2016-01-07 23:06 ` Paul Eggert
2016-01-07 23:36 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568B1FAA.2000302@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.