From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH PING] Honor 'SOURCE_DATE_EPOCH' when generating autoloads. Date: Mon, 28 Dec 2015 19:01:37 -0800 Organization: UCLA Computer Science Department Message-ID: <5681F791.40309@cs.ucla.edu> References: <87k2ph3mgx.fsf@gnu.org> <87io4lnkyz.fsf@gnu.org> <83mvtwoktg.fsf@gnu.org> <878u5gkakj.fsf@gnu.org> <83a8pwoesc.fsf@gnu.org> <87two3475d.fsf@gnu.org> <5665D6B9.4030309@cs.ucla.edu> <5665DAA1.2080208@cs.ucla.edu> <83k2o9t6t1.fsf@gnu.org> <56771D52.2070406@cs.ucla.edu> <83fuytp1au.fsf@gnu.org> <568073A4.3010604@cs.ucla.edu> <83ege6fsj1.fsf@gnu.org> <568178B6.4000402@cs.ucla.edu> <837fjyfn58.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000106040205010100030309" X-Trace: ger.gmane.org 1451358122 472 80.91.229.3 (29 Dec 2015 03:02:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Dec 2015 03:02:02 +0000 (UTC) Cc: p.stephani2@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 29 04:01:53 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDkXl-0007vD-NG for ged-emacs-devel@m.gmane.org; Tue, 29 Dec 2015 04:01:49 +0100 Original-Received: from localhost ([::1]:46926 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDkXl-00068M-3g for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2015 22:01:49 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDkXh-00068F-Op for emacs-devel@gnu.org; Mon, 28 Dec 2015 22:01:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDkXg-00088H-EV for emacs-devel@gnu.org; Mon, 28 Dec 2015 22:01:45 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:58162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDkXc-00087b-Au; Mon, 28 Dec 2015 22:01:40 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5CFA0160E90; Mon, 28 Dec 2015 19:01:39 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id aQ1eTbIqdX-G; Mon, 28 Dec 2015 19:01:38 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3C430160E8D; Mon, 28 Dec 2015 19:01:38 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id blAbAWlRNQsT; Mon, 28 Dec 2015 19:01:38 -0800 (PST) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 14C25160E90; Mon, 28 Dec 2015 19:01:38 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 In-Reply-To: <837fjyfn58.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197058 Archived-At: This is a multi-part message in MIME format. --------------000106040205010100030309 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Eli Zaretskii wrote: >> >What sort of error? > "Wrong type argument: char-or-string-p, nil". See the attached image, Although you applied the patch to emacs-25, the patch was intended for ma= ster.=20 emacs-25 and master disagree here because of emacs-25 commit=20 2dd3581b78a5fe15e0562b1cc2daa6e3afeeec4a dated December 25 "Restore info = about=20 the build host in bug reports". This explains why I did not observe the p= roblem=20 on master, whereas you observed it on emacs-25. I just now installed into emacs-25 the attached, which should future-proo= f the=20 Dec. 25 change whenever it happens to be merged into master. > the reproducible build is not (yet) the standard > build, it's more like an anomaly at this time, so I thought we should > have the string explain itself. And nil cannot explain anything. That is what documentation is for, no? :-) Having now had some experience with using the deterministic-build API in = code, I=20 far prefer using (if FOO ...) to something like (if (string-equal FOO "(e= lided=20 due to deterministic builds)") ...). Not only would the the latter be lon= ger and=20 harder to read, it would mean I need to go to the documentation and see h= ow the=20 magic-cookie string is spelled and would be likely to make a typo there, = which=20 means we would need to give the magic cookie a name like=20 =E2=80=98deterministic-build-system-name=E2=80=99 to catch typos so that = the code will instead=20 be (if (string-equal FOO deterministic-build-system-name) ...), and then = we=20 would need to give similar names to the magic cookies used for other thin= gs like=20 emacs-build-time that are elided. This would all be complete overkill. It= is=20 much simpler to use nil to represent missing information; this is easier = to=20 remember and read and document and it fits squarely within the Emacs Lisp= tradition. --------------000106040205010100030309 Content-Type: text/x-diff; name="0001-Port-report-emacs-bug-to-deterministic-builds.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Port-report-emacs-bug-to-deterministic-builds.patch" >From 691092c904cc293d84e16f2239f51cbb8ff1cbcd Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 28 Dec 2015 18:43:09 -0800 Subject: [PATCH] Port report-emacs-bug to deterministic builds * lisp/mail/emacsbug.el (report-emacs-bug): Future-proof the recent "built on" change to deterministic builds where emacs-build-system will be nil. See: http://lists.gnu.org/archive/html/emacs-devel/2015-12/msg01369.html --- lisp/mail/emacsbug.el | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el index ae0e711..ef5e86a 100644 --- a/lisp/mail/emacsbug.el +++ b/lisp/mail/emacsbug.el @@ -242,7 +242,11 @@ report-emacs-bug (let ((txt (delete-and-extract-region (1+ user-point) (point)))) (insert (propertize "\n" 'display txt))) - (insert "\n\nIn " (emacs-version) " built on " emacs-build-system "\n") + (insert "\n\nIn " (emacs-version)) + (if emacs-build-system + (insert " built on " emacs-build-system)) + (insert "\n") + (if (stringp emacs-repository-version) (insert "Repository revision: " emacs-repository-version "\n")) (if (fboundp 'x-server-vendor) -- 2.5.0 --------------000106040205010100030309--