From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Should we have a commit size guideline? Date: Tue, 15 Dec 2015 17:00:07 -0800 Organization: UCLA Computer Science Department Message-ID: <5670B797.5080200@cs.ucla.edu> References: <83bn9r3cwr.fsf@gnu.org> <5670ACBC.8020203@cs.ucla.edu> <5670AF1D.1090803@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1450227645 14590 80.91.229.3 (16 Dec 2015 01:00:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Dec 2015 01:00:45 +0000 (UTC) To: Dmitry Gutov , Eli Zaretskii , bruce.connor.am@gmail.com, dak@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 16 02:00:32 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a90SF-0007gB-9t for ged-emacs-devel@m.gmane.org; Wed, 16 Dec 2015 02:00:31 +0100 Original-Received: from localhost ([::1]:39772 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a90SE-0001S6-Ko for ged-emacs-devel@m.gmane.org; Tue, 15 Dec 2015 20:00:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a90Rz-0001Rz-QS for emacs-devel@gnu.org; Tue, 15 Dec 2015 20:00:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a90Rz-00056c-2C for emacs-devel@gnu.org; Tue, 15 Dec 2015 20:00:15 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:37611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a90Rt-00055N-I9; Tue, 15 Dec 2015 20:00:09 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7383B16066A; Tue, 15 Dec 2015 17:00:08 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Os26bRHzgW6W; Tue, 15 Dec 2015 17:00:07 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BBE791601A7; Tue, 15 Dec 2015 17:00:07 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id bAcIZyDFurJ0; Tue, 15 Dec 2015 17:00:07 -0800 (PST) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 8980516066A; Tue, 15 Dec 2015 17:00:07 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 In-Reply-To: <5670AF1D.1090803@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196335 Archived-At: Dmitry Gutov wrote: > Emacs doesn't change tabs to spaces if the indentation level of the line > hasn't changed. I observe problems in this area when changing code (which changes indentation) and then changing it back (i.e., not undo, but make a further change that undoes most or all of the original change). In this case Emacs changes tabs to spaces, assuming the .dir-locals.el settings already mentioned. > we've always considered tabs-to-spaces changes near some actual > changed code to be okay. Yes, of course. Here, though, a two-line changed ballooned into a 23-line change. The first 2 lines of the ballooned change were real, and the other 21 lines were tabs-to-spaces only. It is a bit of an annoyance, that's all. Obviously there are workarounds. It's not something I'd bother writing about, but I'm sympathetic to those bothered enough to write.