From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Should we have a commit size guideline? Date: Wed, 16 Dec 2015 02:23:57 +0200 Message-ID: <5670AF1D.1090803@yandex.ru> References: <83bn9r3cwr.fsf@gnu.org> <5670ACBC.8020203@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1450225468 15363 80.91.229.3 (16 Dec 2015 00:24:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Dec 2015 00:24:28 +0000 (UTC) To: Paul Eggert , Eli Zaretskii , bruce.connor.am@gmail.com, dak@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 16 01:24:23 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a8ztH-0003Ej-Bt for ged-emacs-devel@m.gmane.org; Wed, 16 Dec 2015 01:24:23 +0100 Original-Received: from localhost ([::1]:39691 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8ztG-00037e-C9 for ged-emacs-devel@m.gmane.org; Tue, 15 Dec 2015 19:24:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8zt2-00037U-CM for emacs-devel@gnu.org; Tue, 15 Dec 2015 19:24:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8zsv-00066Z-7z for emacs-devel@gnu.org; Tue, 15 Dec 2015 19:24:06 -0500 Original-Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:36895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8zsv-00066T-0x; Tue, 15 Dec 2015 19:24:01 -0500 Original-Received: by mail-wm0-x230.google.com with SMTP id n186so49422858wmn.0; Tue, 15 Dec 2015 16:24:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=WoTE6SG1xOjklmCP7vs0Z5m1dOXNVDa5CkS/hBfGzrM=; b=aAQn5uvKWK1R+E5ZrVzCx3tvJBYGC07P4DeUgAnEGvvyFpOqx8VARFgoLAPZ9GmAIB EcXmz32ByYdYm68PfRWSgXiW2Q4K2mrsluo7boamwgTvsyM1ff3w/AJyoTI3/We/3xrV Fjmh4493fb3R0OEK86oKBpr9aHiG9ALcuA0StjmqNBuOkKGDj31as1tMLddPWODr7NQ4 GrTnqA8/oiczmr4Rlob9FHW9gAD44YT0WZ1CPmcOFjf16FHox2GIG8LB1UoqqWuyk35A N13i0nG5IVYoKdtbKKJcfcB/jlqdwhVIa8Oua9+JOB8nKHttyQ1/m9hUU+Nh2Teym090 RmSg== X-Received: by 10.194.222.195 with SMTP id qo3mr47107048wjc.51.1450225440281; Tue, 15 Dec 2015 16:24:00 -0800 (PST) Original-Received: from [10.9.0.103] (nat.webazilla.com. [78.140.128.228]) by smtp.googlemail.com with ESMTPSA id 200sm4983360wmn.11.2015.12.15.16.23.58 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 15 Dec 2015 16:23:59 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Thunderbird/42.0 In-Reply-To: <5670ACBC.8020203@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196334 Archived-At: On 12/16/2015 02:13 AM, Paul Eggert wrote: > That being said, it is annoying when part of a patch consists entirely > of changing tabs to spaces or vice versa, as this one did, Did it? Emacs doesn't change tabs to spaces if the indentation level of the line hasn't changed. And anyway, we've always considered tabs-to-spaces changes near some actual changed code to be okay. If someone is having a problem reading such diffs, Emacs has a wonderful diff-auto-refine-mode. > This particular botch was undoubtedly caused by the line > "(emacs-lisp-mode . ((indent-tabs-mode . nil)))" in .dir-locals.el, > which was recently inserted in the (vain) attempt to get rid of all the > tabs in .el source files, and we should probably remove that line as in > practice it really causes more trouble than it's worth. You're assuming that otherwise every committer would have indent-tabs-mode set to nil, which undoubtedly isn't true. Even if it were true, were this line to be removed, you'd still see the same problem with people changing indentation from spaces to tabs in the same fashion. There are a lot of lines indented with spaces already.