From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Should we have a commit size guideline? Date: Tue, 15 Dec 2015 16:13:48 -0800 Organization: UCLA Computer Science Department Message-ID: <5670ACBC.8020203@cs.ucla.edu> References: <83bn9r3cwr.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1450224869 6405 80.91.229.3 (16 Dec 2015 00:14:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Dec 2015 00:14:29 +0000 (UTC) To: Eli Zaretskii , bruce.connor.am@gmail.com, dak@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 16 01:14:19 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a8zjT-0000Af-Vo for ged-emacs-devel@m.gmane.org; Wed, 16 Dec 2015 01:14:16 +0100 Original-Received: from localhost ([::1]:39661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8zjS-0008BL-W6 for ged-emacs-devel@m.gmane.org; Tue, 15 Dec 2015 19:14:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8zjF-00089Q-Av for emacs-devel@gnu.org; Tue, 15 Dec 2015 19:14:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8zjE-0003Gg-EI for emacs-devel@gnu.org; Tue, 15 Dec 2015 19:14:01 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8zj9-0003Ea-B9; Tue, 15 Dec 2015 19:13:55 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 118461601A7; Tue, 15 Dec 2015 16:13:50 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id pvNCQ3JpuBav; Tue, 15 Dec 2015 16:13:49 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EF04916066A; Tue, 15 Dec 2015 16:13:48 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id y6SlTkeJ9_lv; Tue, 15 Dec 2015 16:13:48 -0800 (PST) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9DAD71601A7; Tue, 15 Dec 2015 16:13:48 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196332 Archived-At: John Wiegley wrote: > The best of both worlds should be: A commit series from a feature branch, > merged into the target branch. I generally find it a waste of time to split a small or medium-sized patch into the maximum number of patchlets that can be applied one at a time without breaking the build. Of course it's not OK to amalgamate unrelated patches together into one huge commit. Still, for a relatively small and coherent patch such as the one that prompted this thread, we've already wasted more time discussing how to split it up than any possible benefit that would have accrued by splitting it. That being said, it is annoying when part of a patch consists entirely of changing tabs to spaces or vice versa, as this one did, as this wastes the time of reviewers for no good reason. I wish we'd stop doing that. This particular botch was undoubtedly caused by the line "(emacs-lisp-mode . ((indent-tabs-mode . nil)))" in .dir-locals.el, which was recently inserted in the (vain) attempt to get rid of all the tabs in .el source files, and we should probably remove that line as in practice it really causes more trouble than it's worth.