all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Module tests
@ 2015-12-06 17:53 Eli Zaretskii
  2015-12-06 22:56 ` Paul Eggert
  0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2015-12-06 17:53 UTC (permalink / raw)
  To: Paul Eggert; +Cc: emacs-devel

Commit 2b3f5de2b3 removed these 2 tests:

  (should (= (mod-test-sum 1 #x1fffffff)
             (1+  #x1fffffff)))
  (should (= (mod-test-sum -1 #x20000000)
             #x1fffffff))

They were written to test the code in emacs-module.c which switches
from scalar values to cons cells when the integer value is too large
for 32 bits and Emacs is compiled with wide ints.

I don't understand why the removal.  AFAICS, we still switch from
integers to cons cells, so the borderline values just above and below
the threshold are where be dragons, and we should keep them (they
helped me to find and fix a couple of bugs in the previous
implementation).  What am I missing?



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-12-07  3:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-06 17:53 Module tests Eli Zaretskii
2015-12-06 22:56 ` Paul Eggert
2015-12-07  3:38   ` Eli Zaretskii

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.