From: Dmitry Gutov <dgutov@yandex.ru>
To: Stephen Leake <stephen_leake@stephe-leake.org>
Cc: emacs-devel@gnu.org, Phillip Lord <phillip.lord@russet.org.uk>
Subject: Re: automated indent tests
Date: Sun, 29 Nov 2015 20:00:45 +0200 [thread overview]
Message-ID: <565B3D4D.6040404@yandex.ru> (raw)
In-Reply-To: <86oaecvgn4.fsf_-_@stephe-leake.org>
On 11/29/2015 07:50 PM, Stephen Leake wrote:
> For tests where auto-mode-alists fails, we could require a file local
> variable to set the mode. That would make it easier to debug the test
> interactively as well.
> I prefer them in the files as file local variables; that makes it easier
> to debug the test interactively.
>
> Unless you want to use one unindented file, indent it with several
> different indent options, and compare each result to a different
> In some cases, the final indentation can depend on the starting point.
> Certainly that will be true for languages where the syntax relies on the
> indentation (Python etc).
>
> So maybe allowing for both forms of test would be best.
All good ideas.
> For my ada-mode indentation tests, I store only the known-good file in
> the resource directory, autmatically de-indent every line by two spaces,
> then reindent and compare to the original. That has been sufficient so
> far.
On top-level, there's nowhere to de-indent. So maybe add two spaces of
indentation instead?
And also, most indentation functions don't change the indentation inside
multiline string literals. So that would have to be taken care of
somehow, maybe with a "this is a string" annotation comments.
next prev parent reply other threads:[~2015-11-29 18:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151126211432.7647.1395@vcs.savannah.gnu.org>
[not found] ` <E1a23s9-00020K-OH@vcs.savannah.gnu.org>
2015-11-28 18:56 ` [Emacs-diffs] master 75336a2: Merge branch 'feature/standard-test-location' Dmitry Gutov
2015-11-28 18:59 ` Eli Zaretskii
2015-11-28 19:20 ` Phillip Lord
2015-11-28 20:06 ` Dmitry Gutov
2015-11-28 21:20 ` Phillip Lord
2015-11-29 4:16 ` Dmitry Gutov
2015-11-29 17:50 ` automated indent tests Stephen Leake
2015-11-29 18:00 ` Dmitry Gutov [this message]
2015-11-29 21:15 ` [Emacs-diffs] master 75336a2: Merge branch 'feature/standard-test-location' Phillip Lord
2015-12-01 7:16 ` Stephen Leake
2015-12-03 17:31 ` Phillip Lord
2015-11-28 20:15 ` Ken Brown
2015-11-28 20:52 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565B3D4D.6040404@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=phillip.lord@russet.org.uk \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.