From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 75336a2: Merge branch 'feature/standard-test-location' Date: Sat, 28 Nov 2015 22:06:09 +0200 Message-ID: <565A0931.8010502@yandex.ru> References: <20151126211432.7647.1395@vcs.savannah.gnu.org> <5659F8CC.2070106@yandex.ru> <87d1uukk29.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1448741190 17721 80.91.229.3 (28 Nov 2015 20:06:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 Nov 2015 20:06:30 +0000 (UTC) Cc: emacs-devel@gnu.org To: Phillip Lord Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 28 21:06:27 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a2llJ-0007pa-15 for ged-emacs-devel@m.gmane.org; Sat, 28 Nov 2015 21:06:25 +0100 Original-Received: from localhost ([::1]:33607 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2llM-0004KB-Fr for ged-emacs-devel@m.gmane.org; Sat, 28 Nov 2015 15:06:28 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2ll9-0004K6-LC for emacs-devel@gnu.org; Sat, 28 Nov 2015 15:06:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2ll6-0003UH-Eq for emacs-devel@gnu.org; Sat, 28 Nov 2015 15:06:15 -0500 Original-Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:37013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2ll6-0003Tu-8i for emacs-devel@gnu.org; Sat, 28 Nov 2015 15:06:12 -0500 Original-Received: by wmww144 with SMTP id w144so92598474wmw.0 for ; Sat, 28 Nov 2015 12:06:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=9uTwcA/vWou3jQfiz9wnp2Hx0oQ/AX/iZIzx2taRdK8=; b=gHsz55XxIfelrVuEtdxe6Zv+lKiOrgQhsCk3XBC714epyNczeSUfDG/ZHyyBe6GNBI xngzanSveUzAKgpChU/kRekRYpl2bVwNQ1Nl4rhWg+gsVJXwoBMU3V36VvLjLsCHehhe eFQMWtnx/TrrrPkCIZAKAIlxtkDgXqR0joISye5RX0smdylcdo0w31qbzIxLbLJals3D +S96B49D6coosDEgrhl66OV/w7Huc+0v/+3zW1np6Trn+my5r/cqW2x/ctEURPYAO6by 8nC9BJHRFKIqweUXxNx48lHZ5171jJZJIPqk2qv51BqFILE9Fl4sgb/KDUHXBIF8PD+f veKA== X-Received: by 10.28.61.4 with SMTP id k4mr19102304wma.34.1448741171589; Sat, 28 Nov 2015 12:06:11 -0800 (PST) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id a63sm13617917wmc.5.2015.11.28.12.06.10 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 28 Nov 2015 12:06:11 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Thunderbird/42.0 In-Reply-To: <87d1uukk29.fsf@russet.org.uk> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c09::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195479 Archived-At: On 11/28/2015 09:20 PM, Phillip Lord wrote: > Possibly not. I just inverted the logic -- I moved all of the files from > "automated" into top-level, and everything from top-level into "manual". All right, thanks, I can see the idea now. I haven't noticed that there's no 'automatic' directory now. > In the long term it might be nice to either link these into "make check" > from the test dir, And then, the 'manual' directory will disappear? Sounds good. > or make them ert driven and move them to the main > directory. In the previous discussions, Stefan has been a been proponent to keeping indentation tests as sample files, instead of ERT scripts. Because, as the argument went, it's much easier to work on the indentation code when the file contents are right before your eyes, and you can interact with them live. Initially, I've put a number of indentation tests into automated/ruby-mode-tests.el, but now I more or less agree with the above position. > I've been working on a new package with some higher-level > predicates which should do most of what the indent tests do, which > should help. There is a `ruby-should-indent-buffer' helper in the aforementioned file. I haven't really needed much else.