From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#22032: 24.3; VC doesn't handle hg hidden revisions Date: Sat, 28 Nov 2015 04:44:52 +0200 Message-ID: <56591524.3010806@yandex.ru> References: <56584054.5080100@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1448678781 32051 80.91.229.3 (28 Nov 2015 02:46:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 Nov 2015 02:46:21 +0000 (UTC) To: Glenn Hutchings , 22032@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 28 03:46:08 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a2VWa-0002mX-8I for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Nov 2015 03:46:08 +0100 Original-Received: from localhost ([::1]:59276 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2VWd-0004Ue-2f for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Nov 2015 21:46:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2VWZ-0004UY-TQ for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2015 21:46:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2VWU-00021L-Sl for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2015 21:46:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2VWU-00021H-Oo for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2015 21:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a2VWU-0006AM-F1 for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2015 21:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Nov 2015 02:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22032-submit@debbugs.gnu.org id=B22032.144867871823651 (code B ref 22032); Sat, 28 Nov 2015 02:46:01 +0000 Original-Received: (at 22032) by debbugs.gnu.org; 28 Nov 2015 02:45:18 +0000 Original-Received: from localhost ([127.0.0.1]:57451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a2VVm-00069P-1a for submit@debbugs.gnu.org; Fri, 27 Nov 2015 21:45:18 -0500 Original-Received: from mail-wm0-f53.google.com ([74.125.82.53]:34444) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a2VVP-00068G-MP for 22032@debbugs.gnu.org; Fri, 27 Nov 2015 21:45:14 -0500 Original-Received: by wmvv187 with SMTP id v187so90016610wmv.1 for <22032@debbugs.gnu.org>; Fri, 27 Nov 2015 18:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=fmg99Ceb6p4w7hkaaNRrkentYxZn48hpv7RCH6YR0KM=; b=R73Nv+e/HN9A1wrlv4L2sEVnbnncbBnFkQPpWIcGT5KbHG2VWCWNmt7AbYkZQGs1WV Hf2B0PsFBUm/qHJEF/hvwSCYIc1O/QeJQbi+MwkISRlyu7YWzMFcT920hN+54zh0OUQs HBU96AIxaplVEdRzA8HQim3jvTUJ0Z6Rt+a6/BiZ/sMZdTv8QGUZjpLri/e8mR9yuV+f AaIWKfjpyvLky1uN+KmQ1wgg6pyf8fTrxvDlW79AVEa8ZkrwuzL6xzJqMbH4RDFsiIka EVR+ZKVU4QI1qP0cE2gZtTVMh2ds6paDIxUm7p6Woq+y76uBGslHCWO/CaSd4ie0MsOm pBCg== X-Received: by 10.28.103.84 with SMTP id b81mr13576955wmc.39.1448678694660; Fri, 27 Nov 2015 18:44:54 -0800 (PST) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id c4sm35392244wjs.36.2015.11.27.18.44.53 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 27 Nov 2015 18:44:53 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Thunderbird/42.0 In-Reply-To: <56584054.5080100@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109347 Archived-At: On 11/27/2015 01:36 PM, Glenn Hutchings wrote: > In the *vc-change-log* buffer, pressing '=' should display the diff > twixt the current and previous revisions. This fails when (1) the HG > backend is being used, and (2) the mercurial change history contains > hidden revisions. Could you link to some relevant documentation? The closest I've been able to find mentions "secret changesets". > Hidden revisions are a fairly recent mercurial feature. By default, > they're not displayed; hg needs a "--hidden" argument to consider them. Is there a reason why we wouldn't want to use that argument and just always display them? > The lisp function to find the previous rev number > (vc-hg-previous-revision) just decrements the current rev by 1. In the > example above, doing a diff on changeset 2 would try to use the hidden > revision 1 and then mercurial gives an error to the effect of "rev 1 is > hidden" (sorry, don't have the exact text to hand). Would calling 'hg diff --hidden' help? > Possible fix: > actually move to the previous rev in the buffer, and get the rev number > from that. Unfortunately, vc-hg-previous-revision is not always called from the vc-log buffer. E.g. it's also called from the vc-annotate buffer. So we'd need a more reliable way to detect the previous revision. Such as an Hg command line invocation, probably. > To repeat it: get a mercurial repo with hidden changeset (as above) and > try the command with latest mercurial. A publicly available example would be nice.