* bug#21953: Eliminate warnings in the emacs-25 release branch
@ 2015-11-18 17:44 John Wiegley
2015-11-18 17:58 ` Eli Zaretskii
` (6 more replies)
0 siblings, 7 replies; 52+ messages in thread
From: John Wiegley @ 2015-11-18 17:44 UTC (permalink / raw
To: 21953
By my count today, there are 461 byte-compilation warnings on the emacs-25
branch. This issue is here as a release blocker to deal with, or silence,
these warnings.
How do I mark this as a release blocker when creating an e-mail report?
John
abbrev.el:847:8:Warning: ‘with-wrapper-hook’ is an obsolete macro (as of
emacs-lisp/byte-run.el:48:1:Warning: ‘macro-declaration-function’ is an
emacs-lisp/float-sup.el:31:1:Warning: global/dynamic var ‘pi’ lacks a prefix
emacs-lisp/lisp.el:367:27:Warning: ‘syntax-begin-function’ is an obsolete
files.el:1697:8:Warning: function create-file-buffer used to take 0+
font-lock.el:641:47:Warning: ‘font-lock-fontify-buffer’ is for interactive use
font-lock.el:1755:34:Warning: ‘syntax-begin-function’ is an obsolete variable
menu-bar.el:417:11:Warning: reference to free variable ‘xref-find-function’
minibuffer.el:1697:12:Warning: display-completion-list called with 2
minibuffer.el:1966:62:Warning: ‘with-wrapper-hook’ is an obsolete macro (as of
minibuffer.el:2924:1:Warning: Unused lexical variable ‘p1’
minibuffer.el:2924:1:Warning: Unused lexical variable ‘p2’
replace.el:2235:36:Warning: looking-back called with 1 argument, but requires
simple.el:4018:52:Warning: ‘with-wrapper-hook’ is an obsolete macro (as of
startup.el:115:1:Warning: global/dynamic var ‘argv’ lacks a prefix
startup.el:122:1:Warning: global/dynamic var ‘argi’ lacks a prefix
subr.el:32:11:Warning: macro declare-function used to take 2+ arguments, now
dirtrack.el:183:1:Warning: global/dynamic var ‘dirtrackp’ lacks a prefix
ehelp.el:358:10:Warning: ‘execute-extended-command’ is for interactive use
epa-mail.el:75:4:Warning: ‘epa-decrypt-armor-in-region’ is for interactive use
epa-mail.el:83:4:Warning: ‘epa-verify-cleartext-in-region’ is for interactive
epa-mail.el:109:10:Warning: ‘epa-sign-region’ is for interactive use only.
epa-mail.el:228:12:Warning: ‘epa-encrypt-region’ is for interactive use only.
epa.el:1008:19:Warning: ‘epa-verify-region’ is for interactive use only.
ffap.el:984:63:Warning: assignment to free variable ‘kpsewhich-args’
ffap.el:984:59:Warning: reference to free variable ‘kpsewhich-args’
htmlfontify.el:1820:13:Warning: ‘font-lock-fontify-buffer’ is for interactive
isearchb.el:80:1:Warning: Package iswitchb is obsolete!
pcmpl-gnu.el:162:47:Warning: ‘pcomplete-suffix-list’ is an obsolete variable
pcomplete.el:1017:11:Warning: macro ‘pcomplete-here’ defined too late
server.el:1705:1:Warning: the function ‘cygwin-convert-file-name-from-windows’
calendar/appt.el:548:1:Warning: global/dynamic var ‘number’ lacks a prefix
calendar/cal-bahai.el:316:1:Warning: global/dynamic var ‘date’ lacks a prefix
calendar/cal-china.el:635:1:Warning: global/dynamic var ‘date’ lacks a prefix
calendar/cal-china.el:653:1:Warning: global/dynamic var ‘entry’ lacks a prefix
calendar/cal-coptic.el:171:1:Warning: global/dynamic var ‘date’ lacks a prefix
calendar/cal-french.el:246:1:Warning: global/dynamic var ‘date’ lacks a prefix
calendar/cal-hebrew.el:751:1:Warning: global/dynamic var ‘date’ lacks a prefix
calendar/cal-hebrew.el:759:1:Warning: global/dynamic var ‘entry’ lacks a
calendar/cal-islam.el:308:1:Warning: global/dynamic var ‘date’ lacks a prefix
calendar/cal-iso.el:132:1:Warning: global/dynamic var ‘date’ lacks a prefix
calendar/cal-julian.el:186:1:Warning: global/dynamic var ‘date’ lacks a prefix
calendar/cal-mayan.el:356:1:Warning: global/dynamic var ‘date’ lacks a prefix
calendar/cal-persia.el:199:1:Warning: global/dynamic var ‘date’ lacks a prefix
calendar/diary-lib.el:715:1:Warning: global/dynamic var ‘number’ lacks a
calendar/diary-lib.el:1812:1:Warning: global/dynamic var ‘date’ lacks a prefix
calendar/diary-lib.el:1813:1:Warning: global/dynamic var ‘entry’ lacks a
calendar/lunar.el:244:1:Warning: global/dynamic var ‘date’ lacks a prefix
calendar/solar.el:890:1:Warning: global/dynamic var ‘date’ lacks a prefix
calendar/time-date.el:134:11:Warning: ‘encode-time-value’ is an obsolete
calendar/time-date.el:260:24:Warning: ‘encode-time-value’ is an obsolete
calendar/time-date.el:268:27:Warning: ‘encode-time-value’ is an obsolete
calendar/todo-mode.el:4664:24:Warning: looking-back called with 1 argument,
cedet/ede.el:1540:1:Warning: the following functions might not be defined at
cedet/mode-local.el:641:42:Warning: reference to free variable
cedet/semantic.el:1188:15:Warning: Unknown slot ‘bounds’
cedet/ede/base.el:631:34:Warning: Unknown slot ‘:file’
cedet/ede/base.el:634:69:Warning: Unknown slot ‘:directory’
cedet/ede/config.el:164:17:Warning: Unknown slot ‘:directory’
cedet/ede/config.el:260:23:Warning: Unknown slot ‘:debug-command’
cedet/ede/config.el:277:34:Warning: Unknown slot ‘:run-command’
cedet/ede/config.el:308:22:Warning: Unknown slot ‘:build-command’
cedet/ede/config.el:383:17:Warning: Unknown slot ‘:c-preprocessor-files’
cedet/ede/config.el:386:11:Warning: Unknown slot ‘lexical-table’
cedet/ede/config.el:388:5:Warning: Unknown slot ‘:c-preprocessor-table’
cedet/ede/config.el:413:36:Warning: Unknown slot ‘:classpath’
cedet/ede/cpp-root.el:284:13:Warning: Unknown slot ‘:file’
cedet/ede/cpp-root.el:444:30:Warning: Unknown slot ‘lexical-table’
cedet/ede/cpp-root.el:456:78:Warning: Unknown slot ‘:compile-command’
cedet/ede/cpp-root.el:464:30:Warning: Unknown slot ‘:local-variables’
cedet/ede/cpp-root.el:472:75:Warning: Unknown slot ‘:project’
cedet/ede/detect.el:204:49:Warning: ‘eieio-object-name-string’ is an obsolete
cedet/ede/emacs.el:227:13:Warning: Unknown slot ‘lexical-table’
cedet/ede/emacs.el:227:43:Warning: Unknown slot ‘lexical-table’
cedet/ede/files.el:123:26:Warning: Unknown slot ‘:directory’
cedet/ede/files.el:211:31:Warning: Unknown slot ‘:directory’
cedet/ede/files.el:207:20:Warning: Unknown slot ‘:directory’
cedet/ede/files.el:231:36:Warning: Unknown slot ‘:directory’
cedet/ede/files.el:359:12:Warning: Unknown slot ‘:directory’
cedet/ede/files.el:368:13:Warning: Unknown slot ‘:directory’
cedet/ede/linux.el:309:29:Warning: Unknown slot ‘lexical-table’
cedet/ede/proj-archive.el:35:1:Warning: Obsolete name arg "ede-archive-linker"
cedet/ede/proj-aux.el:36:1:Warning: Obsolete name arg "ede-aux-source-txt" to
cedet/ede/proj-elisp.el:79:1:Warning: Obsolete name arg "ede-emacs-source" to
cedet/ede/proj-elisp.el:86:1:Warning: Obsolete name arg "ede-emacs-compiler"
cedet/ede/proj-elisp.el:97:18:Warning: Obsolete name arg
cedet/ede/proj-elisp.el:325:1:Warning: Obsolete name arg
cedet/ede/proj-elisp.el:336:89:Warning: Obsolete name arg "clean-autoloads" to
cedet/ede/proj-info.el:45:1:Warning: Obsolete name arg "ede-makeinfo-source"
cedet/ede/proj-info.el:52:1:Warning: Obsolete name arg "ede-makeinfo-compiler"
cedet/ede/proj-info.el:63:1:Warning: Obsolete name arg
cedet/ede/proj-misc.el:51:1:Warning: Obsolete name arg "ede-misc-source" to
cedet/ede/proj-misc.el:57:1:Warning: Obsolete name arg "ede-misc-compile" to
cedet/ede/proj-obj.el:85:1:Warning: Obsolete name arg "ede-source-c" to
cedet/ede/proj-obj.el:93:1:Warning: Obsolete name arg "ede-c-compiler-gcc" to
cedet/ede/proj-obj.el:105:18:Warning: Obsolete name arg "c-inference-rule" to
cedet/ede/proj-obj.el:116:1:Warning: Obsolete name arg "ede-cc-linker" to
cedet/ede/proj-obj.el:126:1:Warning: Obsolete name arg "ede-source-c++" to
cedet/ede/proj-obj.el:134:1:Warning: Obsolete name arg "ede-c-compiler-g++" to
cedet/ede/proj-obj.el:147:18:Warning: Obsolete name arg "c++-inference-rule"
cedet/ede/proj-obj.el:158:1:Warning: Obsolete name arg "ede-g++-linker" to
cedet/ede/proj-obj.el:171:1:Warning: Obsolete name arg "ede-source-lex" to
cedet/ede/proj-obj.el:178:1:Warning: Obsolete name arg "ede-lex-compiler" to
cedet/ede/proj-obj.el:187:1:Warning: Obsolete name arg "ede-source-yacc" to
cedet/ede/proj-obj.el:194:1:Warning: Obsolete name arg "ede-yacc-compiler" to
cedet/ede/proj-obj.el:205:1:Warning: Obsolete name arg "ede-source-f90" to
cedet/ede/proj-obj.el:213:1:Warning: Obsolete name arg "ede-source-f77" to
cedet/ede/proj-obj.el:221:1:Warning: Obsolete name arg
cedet/ede/proj-obj.el:233:18:Warning: Obsolete name arg "f90-inference-rule"
cedet/ede/proj-obj.el:254:1:Warning: Obsolete name arg "ede-gfortran-linker"
cedet/ede/proj-obj.el:266:1:Warning: Obsolete name arg "ede-ld-linker" to
cedet/ede/proj-shared.el:81:24:Warning: Obsolete name arg
cedet/ede/proj-shared.el:128:24:Warning: Obsolete name arg
cedet/ede/project-am.el:662:32:Warning: Unknown slot ‘:file’
cedet/ede/project-am.el:697:66:Warning: Unknown slot ‘:source’
cedet/ede/project-am.el:699:16:Warning: Unknown slot ‘:name’
cedet/ede/project-am.el:801:49:Warning: Unknown slot ‘:path’
cedet/ede/project-am.el:809:17:Warning: Unknown slot ‘:include’
cedet/ede/project-am.el:818:49:Warning: Unknown slot ‘:path’
cedet/ede/project-am.el:818:68:Warning: Unknown slot ‘:source’
cedet/ede/project-am.el:830:48:Warning: Unknown slot ‘:name’
cedet/ede/project-am.el:996:31:Warning: Unknown slot ‘:directory’
cedet/ede/shell.el:41:20:Warning: Unknown slot ‘:directory’
cedet/ede/simple.el:48:15:Warning: Obsolete name arg "simple-overlay" to
cedet/ede/source.el:158:1:Warning: Obsolete name arg "ede-source-scheme" to
cedet/ede/util.el:44:28:Warning: Unknown slot ‘:version’
cedet/semantic/analyze.el:205:18:Warning: Unknown slot ‘:prefix’
cedet/semantic/analyze.el:213:5:Warning: Unknown slot ‘:function’
cedet/semantic/analyze.el:218:5:Warning: Unknown slot ‘:assignee’
cedet/semantic/analyze.el:666:22:Warning: Obsolete name arg "functionargument"
cedet/semantic/analyze.el:673:24:Warning: Obsolete name arg "assignment" to
cedet/semantic/analyze.el:698:15:Warning: Obsolete name arg "context" to
cedet/semantic/analyze.el:748:13:Warning: Unknown slot ‘:buffer’
cedet/semantic/analyze.el:749:38:Warning: Unknown slot ‘:bounds’
cedet/semantic/chart.el:155:34:Warning: Unknown slot ‘filestream’
cedet/semantic/chart.el:155:37:Warning: Unknown slot ‘includestream’
cedet/semantic/chart.el:158:31:Warning: Unknown slot ‘fullscope’
cedet/semantic/chart.el:165:41:Warning: Unknown slot ‘localvar’
cedet/semantic/complete.el:1286:49:Warning: Unknown slot ‘:table’
cedet/semantic/complete.el:1892:43:Warning: Obsolete name arg "simple" to
cedet/semantic/complete.el:1947:8:Warning: Obsolete name arg "inline" to
cedet/semantic/complete.el:2038:22:Warning: Obsolete name arg "inline" to
cedet/semantic/db-el.el:80:1:Warning: Obsolete name arg "Emacs" to constructor
cedet/semantic/db-el.el:346:1:Warning: the function
cedet/semantic/db-find.el:366:49:Warning: ‘semanticdb-table-child-p’ is an
cedet/semantic/db-find.el:407:23:Warning: ‘semanticdb-abstract-table-child-p’
cedet/semantic/db-find.el:912:20:Warning: ‘semanticdb-abstract-table-child-p’
cedet/semantic/db-find.el:942:39:Warning: ‘semanticdb-abstract-table-child-p’
cedet/semantic/db-global.el:93:8:Warning: Obsolete name arg "global" to
cedet/semantic/db-global.el:194:26:Warning: Unknown slot ‘:hit-text’
cedet/semantic/db-javascript.el:99:1:Warning: Obsolete name arg "Javascript"
cedet/semantic/db-ref.el:91:49:Warning: ‘semanticdb-table-child-p’ is an
cedet/semantic/db-ref.el:168:50:Warning: Obsolete name arg "DEBUG" to
cedet/semantic/db-typecache.el:562:49:Warning: Unknown slot ‘:major-mode’
cedet/semantic/debug.el:171:88:Warning: Unknown slot ‘:source-buffer’
cedet/semantic/debug.el:213:17:Warning: Unknown slot ‘:parser-buffer’
cedet/semantic/debug.el:365:28:Warning: Obsolete name arg "Debug Interface" to
cedet/semantic/ede-grammar.el:69:1:Warning: Obsolete name arg
cedet/semantic/ede-grammar.el:81:1:Warning: Obsolete name arg
cedet/semantic/ede-grammar.el:92:18:Warning: Obsolete name arg
cedet/semantic/ede-grammar.el:100:1:Warning: Obsolete name arg
cedet/semantic/ede-grammar.el:108:1:Warning: Obsolete name arg
cedet/semantic/ede-grammar.el:119:18:Warning: Obsolete name arg
cedet/semantic/grammar.el:1923:40:Warning: Unknown slot ‘:prefix’
cedet/semantic/grammar.el:1933:10:Warning: Unknown slot ‘prefixclass’
cedet/semantic/idle.el:905:38:Warning: Unknown slot ‘bounds’
cedet/semantic/idle.el:906:37:Warning: Unknown slot ‘prefix’
cedet/semantic/idle.el:1189:25:Warning: Unknown slot ‘parents’
cedet/semantic/idle.el:1189:44:Warning: Unknown slot ‘tag’
cedet/semantic/mru-bookmark.el:168:1:Warning: Obsolete name arg "Ring" to
cedet/semantic/mru-bookmark.el:322:36:Warning: Unknown slot ‘:object-name’
cedet/semantic/scope.el:319:23:Warning: Obsolete name arg "mini" to
cedet/semantic/senator.el:577:23:Warning: Unknown slot ‘parents’
cedet/semantic/symref.el:110:24:Warning: Unknown slot ‘:metasubproject’
cedet/semantic/symref.el:332:20:Warning: Unknown slot ‘:hit-lines’
cedet/semantic/symref.el:365:31:Warning: Unknown slot ‘:searchfor’
cedet/semantic/symref.el:365:31:Warning: Unknown slot ‘:created-by’
cedet/semantic/symref.el:366:48:Warning: Unknown slot ‘:searchtype’
cedet/semantic/symref.el:546:44:Warning: Unknown slot ‘:resulttype’
cedet/semantic/texi.el:415:17:Warning: Unknown slot ‘:prefix’
cedet/semantic/texi.el:428:64:Warning: Unknown slot ‘:prefixclass’
cedet/semantic/texi.el:691:1:Warning: the function ‘semantic-analyze-context’
cedet/semantic/util.el:113:11:Warning: ‘semanticdb-abstract-table-child-p’ is
cedet/semantic/analyze/complete.el:91:24:Warning:
cedet/semantic/analyze/debug.el:478:63:Warning: Unknown slot ‘:scope’
cedet/semantic/analyze/refs.el:106:29:Warning: Unknown slot ‘:tag’
cedet/semantic/bovine/debug.el:61:52:Warning: Obsolete name arg "frame" to
cedet/semantic/bovine/debug.el:119:50:Warning: Obsolete name arg "frame" to
cedet/semantic/bovine/make.el:200:15:Warning: Unknown slot ‘:prefixclass’
cedet/semantic/bovine/make.el:196:63:Warning: Unknown slot ‘:prefix’
cedet/semantic/bovine/scm-by.el:231:1:Warning: the function
cedet/semantic/decorate/include.el:444:8:Warning: Unknown slot ‘:major-mode’
cedet/semantic/decorate/include.el:447:15:Warning: Unknown slot ‘:tags’
cedet/semantic/decorate/include.el:451:8:Warning: Unknown slot ‘:pointmax’
cedet/semantic/decorate/include.el:806:58:Warning: ‘eieio-object-name-string’
cedet/semantic/decorate/include.el:812:46:Warning: ‘eieio-object-name-string’
cedet/semantic/symref/cscope.el:54:14:Warning: Unknown slot ‘:searchfor’
cedet/semantic/symref/cscope.el:54:45:Warning: Unknown slot ‘:searchtype’
cedet/semantic/symref/cscope.el:55:45:Warning: Unknown slot ‘:resulttype’
cedet/semantic/symref/cscope.el:56:45:Warning: Unknown slot ‘:searchscope’
cedet/semantic/symref/global.el:43:13:Warning: Unknown slot ‘:searchfor’
cedet/semantic/symref/global.el:43:48:Warning: Unknown slot ‘:searchtype’
cedet/semantic/symref/global.el:44:48:Warning: Unknown slot ‘:resulttype’
cedet/semantic/symref/global.el:45:48:Warning: Unknown slot ‘:searchscope’
cedet/semantic/symref/grep.el:90:1:Warning: global/dynamic var ‘grepflags’
cedet/semantic/symref/grep.el:91:1:Warning: global/dynamic var ‘greppattern’
cedet/semantic/symref/grep.el:143:19:Warning: Unknown slot ‘:searchtype’
cedet/semantic/symref/grep.el:180:68:Warning: Unknown slot ‘:resulttype’
cedet/semantic/symref/idutils.el:43:13:Warning: Unknown slot ‘:searchfor’
cedet/semantic/symref/idutils.el:43:45:Warning: Unknown slot ‘:searchtype’
cedet/semantic/symref/idutils.el:44:45:Warning: Unknown slot ‘:resulttype’
cedet/semantic/symref/idutils.el:45:45:Warning: Unknown slot ‘:searchscope’
cedet/semantic/symref/list.el:214:24:Warning: Unknown slot ‘:hit-tags’
cedet/semantic/symref/list.el:408:4:Warning: Unknown slot ‘:searchfor’
cedet/semantic/symref/list.el:408:4:Warning: Unknown slot ‘:created-by’
cedet/srecode/args.el:180:37:Warning: Unknown slot ‘:version’
cedet/srecode/compile.el:141:34:Warning: Unknown slot ‘key’
cedet/srecode/compile.el:552:34:Warning: Unknown slot ‘:object-name’
cedet/srecode/compile.el:553:46:Warning: Unknown slot ‘:context’
cedet/srecode/compile.el:601:4:Warning: ‘eieio-object-name-string’ is an
cedet/srecode/compile.el:647:4:Warning: ‘eieio-object-name-string’ is an
cedet/srecode/compile.el:647:36:Warning: Unknown slot ‘:secondname’
cedet/srecode/cpp.el:122:59:Warning: Unknown slot ‘:prime’
cedet/srecode/ctxt.el:179:9:Warning: Unknown slot ‘object-name’
cedet/srecode/dictionary.el:125:35:Warning: Unknown slot ‘:value’
cedet/srecode/dictionary.el:227:18:Warning: Unknown slot ‘:tables’
cedet/srecode/dictionary.el:541:29:Warning: Unknown slot ‘:object-name’
cedet/srecode/dictionary.el:543:22:Warning: Unknown slot ‘prompt’
cedet/srecode/dictionary.el:544:22:Warning: Unknown slot ‘read-fcn’
cedet/srecode/el.el:86:54:Warning: Unknown slot ‘:prime’
cedet/srecode/extract.el:90:46:Warning: Obsolete name arg "state" to
cedet/srecode/extract.el:163:33:Warning: Unknown slot ‘:object-name’
cedet/srecode/find.el:99:53:Warning: Unknown slot ‘:project’
cedet/srecode/find.el:142:22:Warning: Unknown slot ‘:tables’
cedet/srecode/find.el:148:54:Warning: Unknown slot ‘:application’
cedet/srecode/find.el:151:9:Warning: Unknown slot ‘:major-mode’
cedet/srecode/find.el:248:57:Warning: Unknown slot ‘:application’
cedet/srecode/insert.el:473:35:Warning: Unknown slot ‘:object-name’
cedet/srecode/insert.el:479:27:Warning: Unknown slot ‘:secondname’
cedet/srecode/insert.el:552:48:Warning: Unknown slot ‘:object-name’
cedet/srecode/insert.el:589:40:Warning: Unknown slot ‘:defaultfcn’
cedet/srecode/insert.el:626:26:Warning: Unknown slot ‘:read-fcn’
cedet/srecode/insert.el:808:6:Warning: ‘eieio-object-name-string’ is an
cedet/srecode/insert.el:864:53:Warning: Unknown slot ‘:object-name’
cedet/srecode/insert.el:866:25:Warning: ‘eieio-object-name-string’ is an
cedet/srecode/insert.el:925:43:Warning: Unknown slot ‘:secondname’
cedet/srecode/insert.el:978:8:Warning: Unknown slot ‘:object-name’
cedet/srecode/insert.el:1059:22:Warning: Unknown slot ‘:object-name’
cedet/srecode/map.el:273:18:Warning: Obsolete name arg "SRecode Map" to
cedet/srecode/map.el:302:10:Warning: Obsolete name arg "SRecode Map" to
cedet/srecode/mode.el:199:40:Warning: Unknown slot ‘:tables’
cedet/srecode/mode.el:242:31:Warning: ‘eieio-object-name-string’ is an
cedet/srecode/mode.el:344:52:Warning: Unknown slot ‘:table’
cedet/srecode/mode.el:325:10:Warning: Unknown slot ‘:file’
cedet/srecode/mode.el:325:30:Warning: Unknown slot ‘:object-name’
cedet/srecode/mode.el:339:26:Warning: Unknown slot ‘:context’
cedet/srecode/semantic.el:66:8:Warning: Unknown slot ‘:prime’
cedet/srecode/semantic.el:106:44:Warning: Unknown slot ‘:prime’
cedet/srecode/srt-mode.el:247:45:Warning: Unknown slot ‘key’
cedet/srecode/srt-mode.el:500:33:Warning: Obsolete name arg "TMP" to
cedet/srecode/srt-mode.el:505:34:Warning: Unknown slot ‘:object-name’
cedet/srecode/srt-mode.el:508:61:Warning: Unknown slot ‘:secondname’
cedet/srecode/srt-mode.el:508:33:Warning: Unknown slot ‘key’
cedet/srecode/srt-mode.el:631:26:Warning: Unknown slot ‘:prefix’
cedet/srecode/srt-mode.el:649:29:Warning: Unknown slot ‘:argument’
cedet/srecode/table.el:203:49:Warning: Unknown slot ‘:priority’
cedet/srecode/table.el:204:51:Warning: Unknown slot ‘:priority’
cedet/srecode/table.el:242:4:Warning: Unknown slot ‘:major-mode’
cedet/srecode/table.el:243:4:Warning: Unknown slot ‘:tables’
cedet/srecode/table.el:255:4:Warning: ‘eieio-object-name-string’ is an
cedet/srecode/table.el:257:4:Warning: Unknown slot ‘:priority’
cedet/srecode/table.el:257:20:Warning: Unknown slot ‘:application’
cedet/srecode/table.el:260:22:Warning: Unknown slot ‘:framework’
cedet/srecode/table.el:263:22:Warning: Unknown slot ‘:project’
cedet/srecode/texi.el:156:8:Warning: Unknown slot ‘:prime’
emacs-lisp/chart.el:130:44:Warning: Unknown slot ‘title’
emacs-lisp/eieio-custom.el:202:41:Warning: ‘eieio-object-name-string’ is an
emacs-lisp/eieio-custom.el:469:14:Warning: Unknown slot ‘name’
emacs-lisp/eieio-datadebug.el:64:16:Warning: ‘eieio-object-name-string’ is an
emacs-lisp/eieio-datadebug.el:90:6:Warning: ‘eieio-object-name-string’ is an
emacs-lisp/eieio-opt.el:154:65:Warning: ‘eieio-help-class’ is an obsolete
emacs-lisp/eieio-speedbar.el:199:43:Warning: ‘eieio-object-name-string’ is an
emacs-lisp/eieio-speedbar.el:207:49:Warning: ‘eieio-object-name-string’ is an
emacs-lisp/ewoc.el:501:1:Warning: Unused lexical variable ‘dll’
emacs-lisp/package.el:3412:1:Warning: the function
emacs-lisp/pcase.el:501:8:Warning: function pcase--mutually-exclusive-p used
emulation/viper-ex.el:551:13:Warning: looking-back called with 1 argument, but
emulation/viper-ex.el:553:13:Warning: looking-back called with 1 argument, but
emulation/viper-ex.el:552:26:Warning: looking-back called with 1 argument, but
emulation/viper-ex.el:2014:6:Warning: ‘find-tag’ is an obsolete function (as
emulation/viper-ex.el:2018:36:Warning: ‘find-tag-other-window’ is an obsolete
erc/erc.el:5401:27:Warning: global/dynamic var ‘str’ lacks a prefix
eshell/em-alias.el:217:1:Warning: Unused lexical argument ‘args’
eshell/em-cmpl.el:271:8:Warning: ‘pcomplete-suffix-list’ is an obsolete
eshell/em-dirs.el:186:1:Warning: Unused lexical argument ‘args’
eshell/em-dirs.el:303:1:Warning: Unused lexical argument ‘args’
eshell/em-rebind.el:225:49:Warning: ‘delete-backward-char’ is for interactive
eshell/em-script.el:60:1:Warning: Unused lexical argument ‘args’
eshell/em-tramp.el:97:1:Warning: Unused lexical variable ‘args’
eshell/em-unix.el:933:1:Warning: Unused lexical variable ‘args’
eshell/em-unix.el:963:1:Warning: Unused lexical argument ‘args’
eshell/esh-io.el:325:1:Warning: Unused lexical variable ‘gui-select-enable-clipboard’
eshell/esh-mode.el:491:15:Warning: ‘find-tag’ is an obsolete function (as of
eshell/esh-proc.el:161:1:Warning: Unused lexical argument ‘args’
eshell/esh-var.el:346:1:Warning: Unused lexical variable ‘args’
gnus/gnus-cite.el:1239:17:Warning: ‘font-lock-fontify-buffer’ is for
gnus/gnus-group.el:1637:4:Warning: global/dynamic var ‘ticked’ lacks a prefix
gnus/gnus-group.el:1637:23:Warning: global/dynamic var ‘score’ lacks a prefix
gnus/gnus-group.el:1637:39:Warning: global/dynamic var ‘level’ lacks a prefix
gnus/gnus-group.el:1637:54:Warning: global/dynamic var ‘mailp’ lacks a prefix
gnus/gnus-group.el:1638:4:Warning: global/dynamic var ‘total’ lacks a prefix
gnus/gnus-group.el:1638:19:Warning: global/dynamic var ‘unread’ lacks a prefix
gnus/message.el:1913:1:Warning: ‘make-variable-buffer-local’ not called at
gnus/message.el:6045:1:Warning: global/dynamic var ‘Date’ lacks a prefix
gnus/message.el:6047:1:Warning: global/dynamic var ‘Organization’ lacks a
gnus/message.el:6048:1:Warning: global/dynamic var ‘From’ lacks a prefix
gnus/message.el:6049:1:Warning: global/dynamic var ‘Path’ lacks a prefix
gnus/message.el:6050:1:Warning: global/dynamic var ‘Subject’ lacks a prefix
gnus/message.el:6051:1:Warning: global/dynamic var ‘Newsgroups’ lacks a prefix
gnus/message.el:6053:1:Warning: global/dynamic var ‘References’ lacks a prefix
gnus/message.el:6054:1:Warning: global/dynamic var ‘To’ lacks a prefix
gnus/message.el:6055:1:Warning: global/dynamic var ‘Distribution’ lacks a
gnus/message.el:6056:1:Warning: global/dynamic var ‘Lines’ lacks a prefix
gnus/message.el:6058:1:Warning: global/dynamic var ‘Expires’ lacks a prefix
gnus/mm-decode.el:1933:1:Warning: the function ‘gnus-format-message’ is not
gnus/mm-uu.el:339:1:Warning: global/dynamic var ‘entry’ lacks a prefix
gnus/mm-view.el:528:18:Warning: ‘font-lock-fontify-buffer’ is for interactive
gnus/mml-smime.el:601:1:Warning: the function ‘gnus-format-message’ is not
gnus/mml1991.el:194:8:Warning: ‘mm-with-unibyte-current-buffer’ is an obsolete
gnus/mml1991.el:363:33:Warning: ‘mm-with-unibyte-current-buffer’ is an
gnus/mml2015.el:476:14:Warning: ‘mm-with-unibyte-current-buffer’ is an
gnus/nnmail.el:1962:31:Warning: ‘rmail-dont-reply-to-names’ is an obsolete
gnus/nnmaildir.el:1781:42:Warning: global/dynamic var ‘flist’ lacks a prefix
gnus/nnmaildir.el:1782:4:Warning: global/dynamic var ‘ls’ lacks a prefix
gnus/nnmaildir.el:1782:19:Warning: global/dynamic var ‘dirs’ lacks a prefix
gnus/nnmaildir.el:1782:31:Warning: global/dynamic var ‘dir’ lacks a prefix
gnus/nnmaildir.el:1782:45:Warning: global/dynamic var ‘files’ lacks a prefix
gnus/nnmaildir.el:1783:4:Warning: global/dynamic var ‘file’ lacks a prefix
gnus/nnmaildir.el:1783:19:Warning: global/dynamic var ‘x’ lacks a prefix
gnus/nnrss.el:590:22:Warning: ‘mm-with-unibyte-current-buffer’ is an obsolete
gnus/nnspool.el:348:37:Warning: ‘mm-with-unibyte-current-buffer’ is an
gnus/nnweb.el:107:22:Warning: ‘mm-with-unibyte-current-buffer’ is an obsolete
gnus/nnweb.el:157:39:Warning: ‘mm-with-unibyte-current-buffer’ is an obsolete
gnus/nnweb.el:166:45:Warning: ‘mm-with-unibyte-current-buffer’ is an obsolete
gnus/nnweb.el:390:42:Warning: ‘mm-with-unibyte-current-buffer’ is an obsolete
gnus/plstore.el:419:14:Warning: ‘epg-context-set-armor’ is an obsolete
gnus/registry.el:186:18:Warning: Unknown slot ‘:tracker’
gnus/utf7.el:123:43:Warning: ‘mm-with-unibyte-current-buffer’ is an obsolete
mail/mailalias.el:55:1:Warning: global/dynamic var ‘pattern’ lacks a prefix
mail/mailheader.el:102:1:Warning: global/dynamic var ‘headers’ lacks a prefix
mail/rmail.el:4583:1:Warning: Unused lexical variable ‘rmail-mime-render-html-function’
mail/rmail.el:4950:1:Warning: the function ‘rmail-mime-entity-truncated’ is
mail/supercite.el:709:1:Warning: global/dynamic var ‘curline’ lacks a prefix
obsolete/cc-compat.el:166:1:Warning: the following functions might not be
obsolete/complete.el:836:33:Warning: ‘completion-base-size’ is an obsolete
obsolete/otodo-mode.el:928:1:Warning: global/dynamic var ‘date’ lacks a prefix
obsolete/otodo-mode.el:929:1:Warning: global/dynamic var ‘entry’ lacks a
obsolete/vc-mcvs.el:443:29:Warning: reference to free variable
obsolete/vc-mcvs.el:594:1:Warning: the function ‘vc-stay-local-p’ is not known
obsolete/vi.el:1389:22:Warning: ‘mark-whole-buffer’ is for interactive use
obsolete/vip.el:1860:17:Warning: ‘delete-backward-char’ is for interactive use
obsolete/vip.el:2980:6:Warning: ‘find-tag’ is an obsolete function (as of
obsolete/vip.el:2983:32:Warning: ‘find-tag-other-window’ is an obsolete
org/ob-lilypond.el:250:34:Warning: ‘show-all’ is an obsolete function (as of
org/org-agenda.el:8307:32:Warning: ‘show-entry’ is an obsolete function (as of
org/org-agenda.el:8527:34:Warning: ‘show-entry’ is an obsolete function (as of
org/org-agenda.el:8565:16:Warning: ‘show-subtree’ is an obsolete function (as
org/org-agenda.el:8596:10:Warning: ‘hide-subtree’ is an obsolete function (as
org/org-agenda.el:8604:10:Warning: ‘show-entry’ is an obsolete function (as of
org/org-agenda.el:8605:8:Warning: ‘show-children’ is an obsolete function (as
org/org-agenda.el:8611:10:Warning: ‘show-subtree’ is an obsolete function (as
org/org-agenda.el:8619:15:Warning: ‘show-subtree’ is an obsolete function (as
org/org-agenda.el:8628:10:Warning: ‘show-subtree’ is an obsolete function (as
org/org-archive.el:347:36:Warning: ‘show-all’ is an obsolete function (as of
org/org-archive.el:314:37:Warning: ‘show-subtree’ is an obsolete function (as
org/org-archive.el:443:27:Warning: ‘hide-subtree’ is an obsolete function (as
org/org-archive.el:517:14:Warning: ‘hide-subtree’ is an obsolete function (as
org/org-capture.el:1001:54:Warning: ‘show-all’ is an obsolete function (as of
org/org-clock.el:1934:6:Warning: org-font-lock-ensure called with 0 arguments,
org/org-colview.el:563:11:Warning: ‘hide-entry’ is an obsolete function (as of
org/org-compat.el:484:19:Warning: ‘font-lock-fontify-buffer’ is for
org/org-crypt.el:191:19:Warning: ‘hide-subtree’ is an obsolete function (as of
org/org-ctags.el:361:6:Warning: ‘find-tag’ is an obsolete function (as of
org/org-ctags.el:530:19:Warning: ‘find-tag’ is an obsolete function (as of
org/org-feed.el:405:12:Warning: ‘hide-subtree’ is an obsolete function (as of
org/org-feed.el:409:12:Warning: ‘show-children’ is an obsolete function (as of
org/org-mouse.el:218:18:Warning: ‘redisplay-dont-pause’ is an obsolete
org/org-mouse.el:590:15:Warning: org-looking-back called with 1 argument, but
org/org-pcomplete.el:96:19:Warning: org-looking-back called with 1 argument,
org/org-pcomplete.el:96:47:Warning: org-looking-back called with 1 argument,
org/org-src.el:919:14:Warning: org-font-lock-ensure called with 0 arguments,
org/org-src.el:957:1:Warning: the function ‘org-some’ is not known to be
org/org.el:6378:8:Warning: org-font-lock-ensure called with 0 arguments, but
org/org.el:6633:15:Warning: ‘show-all’ is an obsolete function (as of 25.1);
org/org.el:6724:38:Warning: ‘show-all’ is an obsolete function (as of 25.1);
org/org.el:6797:10:Warning: ‘show-children’ is an obsolete function (as of
org/org.el:6855:17:Warning: ‘show-all’ is an obsolete function (as of 25.1);
org/org.el:6856:8:Warning: ‘hide-sublevels’ is an obsolete function (as of
org/org.el:6873:32:Warning: ‘show-all’ is an obsolete function (as of 25.1);
org/org.el:6893:12:Warning: ‘hide-subtree’ is an obsolete function (as of
org/org.el:6899:20:Warning: ‘hide-subtree’ is an obsolete function (as of
org/org.el:6900:14:Warning: ‘show-children’ is an obsolete function (as of
org/org.el:6906:18:Warning: ‘show-subtree’ is an obsolete function (as of
org/org.el:6932:34:Warning: ‘hide-sublevels’ is an obsolete function (as of
org/org.el:6949:23:Warning: ‘show-children’ is an obsolete function (as of
org/org.el:6950:32:Warning: ‘show-branches’ is an obsolete function (as of
org/org.el:7001:36:Warning: ‘hide-entry’ is an obsolete function (as of 25.1);
org/org.el:7102:28:Warning: ‘hide-sublevels’ is an obsolete function (as of
org/org.el:7162:9:Warning: ‘show-all’ is an obsolete function (as of 25.1);
org/org.el:7527:10:Warning: ‘show-all’ is an obsolete function (as of 25.1);
org/org.el:8227:16:Warning: ‘hide-subtree’ is an obsolete function (as of
org/org.el:8231:8:Warning: ‘show-children’ is an obsolete function (as of
org/org.el:8394:15:Warning: ‘hide-subtree’ is an obsolete function (as of
org/org.el:8706:18:Warning: ‘show-subtree’ is an obsolete function (as of
org/org.el:8827:20:Warning: ‘show-all’ is an obsolete function (as of 25.1);
org/org.el:12841:19:Warning: assignment to free variable ‘e’
org/org.el:12841:19:Warning: reference to free variable ‘e’
org/org.el:14894:37:Warning: assignment to free variable ‘e’
org/org.el:14894:37:Warning: reference to free variable ‘e’
org/org.el:15718:12:Warning: ‘hide-entry’ is an obsolete function (as of
org/org.el:16251:24:Warning: looking-back called with 1 argument, but requires
org/org.el:17513:21:Warning: org-looking-back called with 1 argument, but
org/org.el:19520:40:Warning: ‘show-subtree’ is an obsolete function (as of
org/org.el:20484:12:Warning: ‘hide-subtree’ is an obsolete function (as of
org/org.el:20524:16:Warning: org-looking-back called with 1 argument, but
org/org.el:23060:22:Warning: ‘hide-subtree’ is an obsolete function (as of
org/org.el:24031:1:Warning: the function ‘format-spec’ might not be defined at
org/ox-html.el:1858:25:Warning: org-font-lock-ensure called with 0 arguments,
org/ox-odt.el:3143:21:Warning: org-font-lock-ensure called with 0 arguments,
org/ox-org.el:257:10:Warning: org-font-lock-ensure called with 0 arguments,
org/ox-org.el:257:10:Warning: ‘show-all’ is an obsolete function (as of 25.1);
play/dunnet.el:1205:22:Warning: ‘end-of-buffer’ is for interactive use only;
progmodes/cc-defs.el:2505:1:Warning: the following functions might not be
progmodes/cc-vars.el:1780:1:Warning: the following functions might not be
progmodes/cc-langs.el:3362:1:Warning: the following functions might not be
progmodes/cc-engine.el:11298:1:Warning: the following functions might not be
progmodes/cc-align.el:1353:1:Warning: the following functions might not be
progmodes/cc-awk.el:1155:1:Warning: the following functions might not be
progmodes/cc-cmds.el:4777:1:Warning: the following functions might not be
progmodes/cc-fonts.el:2712:1:Warning: the following functions might not be
progmodes/cc-guess.el:581:1:Warning: the following functions might not be
progmodes/cc-menus.el:529:1:Warning: the following functions might not be
progmodes/cc-styles.el:671:1:Warning: the following functions might not be
progmodes/cc-mode.el:105:21:Warning: ‘font-lock-syntactic-keywords’ is an
progmodes/cc-mode.el:154:53:Warning: (lambda nil ...) quoted with ' rather
progmodes/cc-mode.el:154:53:Warning: (lambda nil ...) quoted with ' rather
progmodes/cc-mode.el:155:53:Warning: (lambda nil ...) quoted with ' rather
progmodes/cc-mode.el:156:53:Warning: (lambda nil ...) quoted with ' rather
progmodes/cc-mode.el:1927:1:Warning: the following functions might not be
progmodes/etags.el:1020:10:Warning: ‘find-tag-other-window’ is an obsolete
progmodes/etags.el:1872:18:Warning: ‘tags-loop-continue’ is an obsolete
progmodes/etags.el:1876:11:Warning: ‘tags-loop-continue’ is an obsolete
progmodes/etags.el:1901:9:Warning: ‘tags-loop-continue’ is an obsolete
progmodes/gdb-mi.el:675:1:Warning: Unused lexical argument ‘arg’
progmodes/gud.el:735:1:Warning: Unused lexical argument ‘arg’
progmodes/hideshow.el:581:22:Warning: looking-back called with 1 argument, but
progmodes/idlw-help.el:1185:16:Warning: ‘font-lock-fontify-buffer’ is for
progmodes/octave.el:1871:1:Warning: the function ‘compilation-forget-errors’
progmodes/sql.el:2781:31:Warning: looking-back called with 1 argument, but
textmodes/sgml-mode.el:436:1:Warning: global/dynamic var ‘v2’ lacks a prefix
vc/add-log.el:476:4:Warning: value returned from (car change-log-find-head) is
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-18 17:44 bug#21953: Eliminate warnings in the emacs-25 release branch John Wiegley
@ 2015-11-18 17:58 ` Eli Zaretskii
2015-11-18 18:04 ` Dmitry Gutov
` (5 subsequent siblings)
6 siblings, 0 replies; 52+ messages in thread
From: Eli Zaretskii @ 2015-11-18 17:58 UTC (permalink / raw
To: John Wiegley; +Cc: 21953
> From: John Wiegley <jwiegley@gmail.com>
> Date: Wed, 18 Nov 2015 09:44:04 -0800
>
> By my count today, there are 461 byte-compilation warnings on the emacs-25
> branch. This issue is here as a release blocker to deal with, or silence,
> these warnings.
>
> How do I mark this as a release blocker when creating an e-mail report?
Not sure what exactly did you want to know, but admin/release-process
might answer that; search for "blocking".
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-18 17:44 bug#21953: Eliminate warnings in the emacs-25 release branch John Wiegley
2015-11-18 17:58 ` Eli Zaretskii
@ 2015-11-18 18:04 ` Dmitry Gutov
2015-11-18 18:17 ` Glenn Morris
` (4 subsequent siblings)
6 siblings, 0 replies; 52+ messages in thread
From: Dmitry Gutov @ 2015-11-18 18:04 UTC (permalink / raw
To: 21953
On 11/18/2015 07:44 PM, John Wiegley wrote:
> progmodes/etags.el:1020:10:Warning: ‘find-tag-other-window’ is an obsolete
> progmodes/etags.el:1872:18:Warning: ‘tags-loop-continue’ is an obsolete
> progmodes/etags.el:1876:11:Warning: ‘tags-loop-continue’ is an obsolete
> progmodes/etags.el:1901:9:Warning: ‘tags-loop-continue’ is an obsolete
How will we silence them? with-no-warnings?
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-18 17:44 bug#21953: Eliminate warnings in the emacs-25 release branch John Wiegley
2015-11-18 17:58 ` Eli Zaretskii
2015-11-18 18:04 ` Dmitry Gutov
@ 2015-11-18 18:17 ` Glenn Morris
2015-11-18 18:44 ` Eli Zaretskii
` (2 more replies)
2015-11-18 18:39 ` Ken Brown
` (3 subsequent siblings)
6 siblings, 3 replies; 52+ messages in thread
From: Glenn Morris @ 2015-11-18 18:17 UTC (permalink / raw
To: 21953
John Wiegley wrote:
[I recommend not setting Mail-Followup-To: bug-gnu-emacs, since it loses
the ###@debbugs address. Which is not a problem by itself, but can cause
one later on if the subject also changes.]
> By my count today, there are 461 byte-compilation warnings on the emacs-25
> branch. This issue is here as a release blocker to deal with, or silence,
> these warnings.
Sorry, but I have to say that I think this goal is firstly unachievable,
and secondly won't make the release any better. In fact probably the
opposite, by distracting from more important issues.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-18 17:44 bug#21953: Eliminate warnings in the emacs-25 release branch John Wiegley
` (2 preceding siblings ...)
2015-11-18 18:17 ` Glenn Morris
@ 2015-11-18 18:39 ` Ken Brown
2015-11-18 18:52 ` Eli Zaretskii
2015-11-18 20:57 ` Stephen Berman
` (2 subsequent siblings)
6 siblings, 1 reply; 52+ messages in thread
From: Ken Brown @ 2015-11-18 18:39 UTC (permalink / raw
To: John Wiegley; +Cc: 21953
On 11/18/2015 12:44 PM, John Wiegley wrote:
> By my count today, there are 461 byte-compilation warnings on the emacs-25
> branch. This issue is here as a release blocker to deal with, or silence,
> these warnings.
>
> How do I mark this as a release blocker when creating an e-mail report?
>
> John
>
> server.el:1705:1:Warning: the function ‘cygwin-convert-file-name-from-windows’
I think I just fixed this one, but someone building on a system other
than Cygwin will have to confirm.
Ken
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-18 18:17 ` Glenn Morris
@ 2015-11-18 18:44 ` Eli Zaretskii
2015-11-23 19:10 ` Glenn Morris
2015-11-18 19:09 ` Artur Malabarba
2015-11-19 2:06 ` John Wiegley
2 siblings, 1 reply; 52+ messages in thread
From: Eli Zaretskii @ 2015-11-18 18:44 UTC (permalink / raw
To: Glenn Morris; +Cc: 21953
> From: Glenn Morris <rgm@gnu.org>
> Date: Wed, 18 Nov 2015 13:17:33 -0500
>
> > By my count today, there are 461 byte-compilation warnings on the emacs-25
> > branch. This issue is here as a release blocker to deal with, or silence,
> > these warnings.
>
> Sorry, but I have to say that I think this goal is firstly unachievable,
> and secondly won't make the release any better. In fact probably the
> opposite, by distracting from more important issues.
I agree that we cannot silence or solve all of them, but we should be
able to do that with most of them.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-18 18:39 ` Ken Brown
@ 2015-11-18 18:52 ` Eli Zaretskii
2015-11-18 19:19 ` Ken Brown
0 siblings, 1 reply; 52+ messages in thread
From: Eli Zaretskii @ 2015-11-18 18:52 UTC (permalink / raw
To: Ken Brown; +Cc: jwiegley, 21953
> From: Ken Brown <kbrown@cornell.edu>
> Date: Wed, 18 Nov 2015 13:39:34 -0500
> Cc: 21953@debbugs.gnu.org
>
> > server.el:1705:1:Warning: the function ‘cygwin-convert-file-name-from-windows’
>
> I think I just fixed this one, but someone building on a system other
> than Cygwin will have to confirm.
Confirmed.
However, if you test for cygwin-convert-file-name-from-windows being
bound, do you still need the test for Cygwin in addition to that?
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-18 18:17 ` Glenn Morris
2015-11-18 18:44 ` Eli Zaretskii
@ 2015-11-18 19:09 ` Artur Malabarba
2015-11-18 20:36 ` Eli Zaretskii
2015-11-19 2:06 ` John Wiegley
2 siblings, 1 reply; 52+ messages in thread
From: Artur Malabarba @ 2015-11-18 19:09 UTC (permalink / raw
To: Glenn Morris; +Cc: 21953
[-- Attachment #1: Type: text/plain, Size: 254 bytes --]
Quite a few of these are about using obsolete functions inside features
that are themselves obsolete (their files are in the obsolete subdir).
Maybe we can just suppress this kind of warning inside the obsolete subdir.
Perhaps with a dir-local-variable?
[-- Attachment #2: Type: text/html, Size: 273 bytes --]
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-18 18:52 ` Eli Zaretskii
@ 2015-11-18 19:19 ` Ken Brown
2015-11-18 20:38 ` Eli Zaretskii
0 siblings, 1 reply; 52+ messages in thread
From: Ken Brown @ 2015-11-18 19:19 UTC (permalink / raw
To: Eli Zaretskii; +Cc: jwiegley, 21953
On 11/18/2015 1:52 PM, Eli Zaretskii wrote:
>> From: Ken Brown <kbrown@cornell.edu>
>> Date: Wed, 18 Nov 2015 13:39:34 -0500
>> Cc: 21953@debbugs.gnu.org
>>
>>> server.el:1705:1:Warning: the function ‘cygwin-convert-file-name-from-windows’
>>
>> I think I just fixed this one, but someone building on a system other
>> than Cygwin will have to confirm.
>
> Confirmed.
>
> However, if you test for cygwin-convert-file-name-from-windows being
> bound, do you still need the test for Cygwin in addition to that?
No, I've now removed it. Thanks.
Ken
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-18 19:09 ` Artur Malabarba
@ 2015-11-18 20:36 ` Eli Zaretskii
2015-11-18 20:57 ` Artur Malabarba
0 siblings, 1 reply; 52+ messages in thread
From: Eli Zaretskii @ 2015-11-18 20:36 UTC (permalink / raw
To: bruce.connor.am; +Cc: 21953
> Date: Wed, 18 Nov 2015 19:09:17 +0000
> From: Artur Malabarba <bruce.connor.am@gmail.com>
> Cc: 21953@debbugs.gnu.org
>
> Quite a few of these are about using obsolete functions inside features that
> are themselves obsolete (their files are in the obsolete subdir). Maybe we can
> just suppress this kind of warning inside the obsolete subdir. Perhaps with a
> dir-local-variable?
Sounds good to me.
If no one objects in a couple of days, please do that.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-18 19:19 ` Ken Brown
@ 2015-11-18 20:38 ` Eli Zaretskii
0 siblings, 0 replies; 52+ messages in thread
From: Eli Zaretskii @ 2015-11-18 20:38 UTC (permalink / raw
To: Ken Brown; +Cc: jwiegley, 21953
> Cc: jwiegley@gmail.com, 21953@debbugs.gnu.org
> From: Ken Brown <kbrown@cornell.edu>
> Date: Wed, 18 Nov 2015 14:19:37 -0500
>
> > However, if you test for cygwin-convert-file-name-from-windows being
> > bound, do you still need the test for Cygwin in addition to that?
>
> No, I've now removed it. Thanks.
Thank you.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-18 17:44 bug#21953: Eliminate warnings in the emacs-25 release branch John Wiegley
` (3 preceding siblings ...)
2015-11-18 18:39 ` Ken Brown
@ 2015-11-18 20:57 ` Stephen Berman
[not found] ` <mailman.233.1447954214.31583.bug-gnu-emacs@gnu.org>
2015-11-26 8:33 ` Andreas Röhler
6 siblings, 0 replies; 52+ messages in thread
From: Stephen Berman @ 2015-11-18 20:57 UTC (permalink / raw
To: 21953
On Wed, 18 Nov 2015 09:44:04 -0800 John Wiegley <jwiegley@gmail.com> wrote:
> By my count today, there are 461 byte-compilation warnings on the emacs-25
> branch. This issue is here as a release blocker to deal with, or silence,
> these warnings.
[...]
> calendar/todo-mode.el:4664:24:Warning: looking-back called with 1 argument,
I'll take care of this before the release.
> obsolete/otodo-mode.el:928:1:Warning: global/dynamic var ‘date’ lacks a prefix
> obsolete/otodo-mode.el:929:1:Warning: global/dynamic var ‘entry’ lacks a
I think fixing these would require backward incompatible changes in
diary-lib.el which would break external code. Since this file is an
obsolete version of Todo mode, I hope these warnings aren't considered
blockers.
Steve Berman
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-18 20:36 ` Eli Zaretskii
@ 2015-11-18 20:57 ` Artur Malabarba
0 siblings, 0 replies; 52+ messages in thread
From: Artur Malabarba @ 2015-11-18 20:57 UTC (permalink / raw
To: Eli Zaretskii; +Cc: 21953
2015-11-18 20:36 GMT+00:00 Eli Zaretskii <eliz@gnu.org>:
>> Quite a few of these are about using obsolete functions inside features that
>> are themselves obsolete (their files are in the obsolete subdir). Maybe we can
>> just suppress this kind of warning inside the obsolete subdir. Perhaps with a
>> dir-local-variable?
>
> Sounds good to me.
>
> If no one objects in a couple of days, please do that.
Add 5 more days to that and you've got a deal. :)
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-18 18:17 ` Glenn Morris
2015-11-18 18:44 ` Eli Zaretskii
2015-11-18 19:09 ` Artur Malabarba
@ 2015-11-19 2:06 ` John Wiegley
2015-11-19 17:20 ` Stephen Leake
2015-11-19 17:29 ` Dmitry Gutov
2 siblings, 2 replies; 52+ messages in thread
From: John Wiegley @ 2015-11-19 2:06 UTC (permalink / raw
To: Glenn Morris; +Cc: Richard Stallman, 21953
>>>>> Glenn Morris <rgm@gnu.org> writes:
> Sorry, but I have to say that I think this goal is firstly unachievable, and
> secondly won't make the release any better. In fact probably the opposite,
> by distracting from more important issues.
I've never worked on a project where getting to warning free was not both
achievable, and a good idea.
For example, at one point the Borland C++ compiler had over 4,000 warnings. As
such, every one of them was completely ignored. Later on, after much effort,
we reduced that number to zero. While doing so, we discovered that a crash bug
we'd been working for _days_ was loudly pointed out to us by the compiler in
that same set of warnings. Had the warnings been "real" to us, it would have
saved days of developer time, on several occasions. It's worth the effort.
Having enough warnings that they no longer warn of anything is pretty much the
same as turning them off. That's why I don't accept the "it's too hard"
argument. If it adds another month or two to our release cycle, so be it.
Emacs 25.1 is the time to get them under control.
Some warnings are not wise to fix, and these should be silenced; but such
decisions should be made either by class within a package, or individually.
John
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 2:06 ` John Wiegley
@ 2015-11-19 17:20 ` Stephen Leake
2015-11-19 17:29 ` Dmitry Gutov
1 sibling, 0 replies; 52+ messages in thread
From: Stephen Leake @ 2015-11-19 17:20 UTC (permalink / raw
To: John Wiegley; +Cc: Richard Stallman, 21953
John Wiegley <jwiegley@gmail.com> writes:
>>>>>> Glenn Morris <rgm@gnu.org> writes:
>
>> Sorry, but I have to say that I think this goal is firstly unachievable, and
>> secondly won't make the release any better. In fact probably the opposite,
>> by distracting from more important issues.
>
> I've never worked on a project where getting to warning free was not both
> achievable, and a good idea.
>
> For example, at one point the Borland C++ compiler had over 4,000 warnings. As
> such, every one of them was completely ignored. Later on, after much effort,
> we reduced that number to zero. While doing so, we discovered that a crash bug
> we'd been working for _days_ was loudly pointed out to us by the compiler in
> that same set of warnings. Had the warnings been "real" to us, it would have
> saved days of developer time, on several occasions. It's worth the effort.
>
> Having enough warnings that they no longer warn of anything is pretty much the
> same as turning them off. That's why I don't accept the "it's too hard"
> argument. If it adds another month or two to our release cycle, so be it.
> Emacs 25.1 is the time to get them under control.
+10
--
-- Stephe
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 2:06 ` John Wiegley
2015-11-19 17:20 ` Stephen Leake
@ 2015-11-19 17:29 ` Dmitry Gutov
2015-11-19 17:37 ` John Wiegley
2015-11-19 17:45 ` Eli Zaretskii
1 sibling, 2 replies; 52+ messages in thread
From: Dmitry Gutov @ 2015-11-19 17:29 UTC (permalink / raw
To: John Wiegley, Glenn Morris; +Cc: Richard Stallman, 21953
On 11/19/2015 04:06 AM, John Wiegley wrote:
> I've never worked on a project where getting to warning free was not both
> achievable, and a good idea.
What will you get, as a result?
I can get behind taking care of "correctness" warnings, but if we lose
the obsolete functions warnings, we risk forgetting to take care of
their causes.
And it's not like we can actually fix all instances of obsolete usages
before the current release: a significant part of the warnings comes
from gnus, org, cc-mode and calendar, all of which, I'm assuming, have
to support older Emacsen.
We _should_ be able to take care of CEDET warnings, but probably after
their development migrates here.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 17:29 ` Dmitry Gutov
@ 2015-11-19 17:37 ` John Wiegley
2015-11-19 17:46 ` Dmitry Gutov
` (3 more replies)
2015-11-19 17:45 ` Eli Zaretskii
1 sibling, 4 replies; 52+ messages in thread
From: John Wiegley @ 2015-11-19 17:37 UTC (permalink / raw
To: Dmitry Gutov; +Cc: Richard Stallman, 21953
>>>>> Dmitry Gutov <dgutov@yandex.ru> writes:
> I can get behind taking care of "correctness" warnings, but if we lose the
> obsolete functions warnings, we risk forgetting to take care of their
> causes.
>
> And it's not like we can actually fix all instances of obsolete usages
> before the current release: a significant part of the warnings comes from
> gnus, org, cc-mode and calendar, all of which, I'm assuming, have to support
> older Emacsen.
If that's the case, I'm willing to filter those from the final count before
closing this issue. Then, in 25.2, we can focus on eliminating those as well.
> We _should_ be able to take care of CEDET warnings, but probably after their
> development migrates here.
That's good to hear; but can that happen for 25.1? CEDET is rather egregious
in the warnings category right now. If that means suppressing warnings
throughout CEDET for this release, I'm OK with that as a temporary measure.
By 25.2, anything that is built using "make" should be warning free, both C
and Emacs Lisp, using whatever reference platform we define as the litmus
test. I'll be building on that platform regularly, to report new warnings.
John
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 17:29 ` Dmitry Gutov
2015-11-19 17:37 ` John Wiegley
@ 2015-11-19 17:45 ` Eli Zaretskii
1 sibling, 0 replies; 52+ messages in thread
From: Eli Zaretskii @ 2015-11-19 17:45 UTC (permalink / raw
To: Dmitry Gutov; +Cc: jwiegley, rms, 21953
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Thu, 19 Nov 2015 19:29:44 +0200
> Cc: Richard Stallman <rms@gnu.org>, 21953@debbugs.gnu.org
>
> I can get behind taking care of "correctness" warnings, but if we lose
> the obsolete functions warnings, we risk forgetting to take care of
> their causes.
I don't think anyone was lobbying for shutting up the obsolete
functions/variables warnings. And I agree that the way to fix them
should not be just shutting them up.
> And it's not like we can actually fix all instances of obsolete usages
> before the current release: a significant part of the warnings comes
> from gnus, org, cc-mode and calendar, all of which, I'm assuming, have
> to support older Emacsen.
That might be true, but a large number of CEDET warnings have nothing
to do with obsolete functions.
IOW, even if we cut the warnings from there by half, we've already
done a good job. because currently I cannot even see the file names
due to the warnings, they drown.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 17:37 ` John Wiegley
@ 2015-11-19 17:46 ` Dmitry Gutov
2015-11-19 17:54 ` Eli Zaretskii
` (2 subsequent siblings)
3 siblings, 0 replies; 52+ messages in thread
From: Dmitry Gutov @ 2015-11-19 17:46 UTC (permalink / raw
To: John Wiegley; +Cc: Richard Stallman, 21953
On 11/19/2015 07:37 PM, John Wiegley wrote:
> If that's the case, I'm willing to filter those from the final count before
> closing this issue. Then, in 25.2, we can focus on eliminating those as well.
Is anything going to change for these packages after the 25.1 release?
>> We _should_ be able to take care of CEDET warnings, but probably after their
>> development migrates here.
>
> That's good to hear; but can that happen for 25.1? CEDET is rather egregious
> in the warnings category right now.
Many of those can be fixed semi-mechanically, by removing colons from
the keyword names. That should be deferred until after the transition,
though, in order not to cause needless merge conflicts.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 17:37 ` John Wiegley
2015-11-19 17:46 ` Dmitry Gutov
@ 2015-11-19 17:54 ` Eli Zaretskii
2015-11-19 18:18 ` John Wiegley
` (2 more replies)
2015-11-19 20:01 ` David Engster
2015-11-20 10:41 ` Stephen Leake
3 siblings, 3 replies; 52+ messages in thread
From: Eli Zaretskii @ 2015-11-19 17:54 UTC (permalink / raw
To: John Wiegley; +Cc: dgutov, rms, 21953
> From: "John Wiegley" <jwiegley@gmail.com>
> Date: Thu, 19 Nov 2015 09:37:16 -0800
> Cc: Richard Stallman <rms@gnu.org>, 21953@debbugs.gnu.org
>
> By 25.2, anything that is built using "make" should be warning free, both C
> and Emacs Lisp
We can stop worrying about warnings in C: there are none, and a few
people regularly compile with pedantic compiler switches and fix
whatever they flag.
The problem of warnings is limited to Lisp, and then mostly to a few
specific packages. Dmitry mentioned some of them. From my POV, the
worst barrage is in CEDET, so IMO that should be the place where we
apply the first efforts.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 17:54 ` Eli Zaretskii
@ 2015-11-19 18:18 ` John Wiegley
2015-11-19 18:34 ` Juanma Barranquero
2015-11-25 20:58 ` Andy Moreton
2 siblings, 0 replies; 52+ messages in thread
From: John Wiegley @ 2015-11-19 18:18 UTC (permalink / raw
To: Eli Zaretskii; +Cc: dgutov, rms, 21953
>>>>> Eli Zaretskii <eliz@gnu.org> writes:
> The problem of warnings is limited to Lisp, and then mostly to a few
> specific packages. Dmitry mentioned some of them. From my POV, the worst
> barrage is in CEDET, so IMO that should be the place where we apply the
> first efforts.
Agreed.
John
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 17:54 ` Eli Zaretskii
2015-11-19 18:18 ` John Wiegley
@ 2015-11-19 18:34 ` Juanma Barranquero
2015-11-19 19:05 ` John Wiegley
2015-11-19 20:25 ` Eli Zaretskii
2015-11-25 20:58 ` Andy Moreton
2 siblings, 2 replies; 52+ messages in thread
From: Juanma Barranquero @ 2015-11-19 18:34 UTC (permalink / raw
To: Eli Zaretskii; +Cc: John Wiegley, dgutov, Richard Stallman, 21953
[-- Attachment #1: Type: text/plain, Size: 4138 bytes --]
On Thu, Nov 19, 2015 at 6:54 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> We can stop worrying about warnings in C: there are none, and a few
> people regularly compile with pedantic compiler switches and fix
> whatever they flag.
At least on Windows, that's not entirely true. I compile with very pedantic
switches.
I had to add "-Wno-missing-prototypes -Wno-missing-declarations
-Wno-redundant-decls -Wno-pointer-sign" to my CFLAGS because of the sheer
number of warnings.
Even so, I get 322 cases of *"initialization discards 'const' qualifier
from pointer target type*", and leaving these aside, also this (# of warns,
warning message)
14 assignment discards 'const' qualifier from pointer target type [enabled
by default]
14 passing argument 1 of 'w32_getenv' discards 'const' qualifier from
pointer target type [enabled by default]
5 return discards 'const' qualifier from pointer target type [enabled by
default]
5 function might be possible candidate for 'ms_printf' format attribute
[-Wsuggest-attribute=format]
4 pointer of type 'void *' used in arithmetic [-Wpointer-arith]
3 format '%d' expects argument of type 'int', but argument 3 has type
'printmax_t' [-Wformat=]
3 passing argument 1 of 'set_user_model' discards 'const' qualifier from
pointer target type [enabled by default]
2 nested extern declaration of '_execvp' [-Wnested-externs]
2 passing argument 2 of 'CreateProcessA' discards 'const' qualifier from
pointer target type [enabled by default]
2 format '%d' expects argument of type 'int', but argument 2 has type
'DWORD' [-Wformat=]
2 unused variable 'status' [-Wunused-variable]
2 passing argument 2 of 'otf_features' discards 'const' qualifier from
pointer target type [enabled by default]
2 ordered comparison of pointer with integer zero [-Wextra]
2 implicit conversion from 'float' to 'double' when passing argument to
function [-Wdouble-promotion]
1 unused variable 'terminal' [-Wunused-variable]
1 'dummy' defined but not used [-Wunused-variable]
1 macro "g_type_init" is not used [-Wunused-macros]
1 unused variable 'st' [-Wunused-variable]
1 macro "NOMINMAX" is not used [-Wunused-macros]
1 nested extern declaration of 'is_slow_fs' [-Wnested-externs]
1 function might be candidate for attribute 'noreturn'
[-Wsuggest-attribute=noreturn]
1 variable 'face' set but not used [-Wunused-but-set-variable]
1 'timeout' may be used uninitialized in this function
[-Wmaybe-uninitialized]
1 implicit conversion from 'float' to 'double' to match other operand of
binary expression [-Wdouble-promotion]
1 macro "x_display_info" is not used [-Wunused-macros]
1 macro "OFFSET_TO_RVA" is not used [-Wunused-macros]
1 unused variable 'oldset' [-Wunused-variable]
1 macro "DATAGRAM_CHAN_P" is not used [-Wunused-macros]
1 unused variable 'size' [-Wunused-variable]
1 control reaches end of non-void function [-Wreturn-type]
1 macro "_ANONYMOUS_UNION" is not used [-Wunused-macros]
1 unused variable 'address' [-Wunused-variable]
1 unknown conversion type character 'e' in format [-Wformat=]
1 unused variable 'dpyinfo' [-Wunused-variable]
1 nested extern declaration of 'g_b_init_compare_string_w'
[-Wnested-externs]
1 nested extern declaration of '_resetstkoflw' [-Wnested-externs]
1 passing argument 1 of 'find_section' discards 'const' qualifier from
pointer target type [enabled by default]
1 passing argument 1 of 'w32_get_rdb_resource' discards 'const' qualifier
from pointer target type [enabled by default]
1 unused variable 'n_to_read' [-Wunused-variable]
1 macro "WTMP_FILE" is not used [-Wunused-macros]
1 nested extern declaration of 'mainCRTStartup' [-Wnested-externs]
1 variable 'f' set but not used [-Wunused-but-set-variable]
1 macro "DefaultDepthOfScreen" is not used [-Wunused-macros]
1 macro "RVA_TO_PTR" is not used [-Wunused-macros]
1 macro "gnutls_x509_crt_get_signature" is not used [-Wunused-macros]
1 variable 'ctty' set but not used [-Wunused-but-set-variable]
1 nested extern declaration of 'menubar_selection_callback'
[-Wnested-externs]
1 macro "MAX_ENCODED_BYTES" is not used [-Wunused-macros]
[-- Attachment #2: Type: text/html, Size: 7412 bytes --]
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 18:34 ` Juanma Barranquero
@ 2015-11-19 19:05 ` John Wiegley
2015-11-19 20:29 ` Eli Zaretskii
2015-11-19 20:25 ` Eli Zaretskii
1 sibling, 1 reply; 52+ messages in thread
From: John Wiegley @ 2015-11-19 19:05 UTC (permalink / raw
To: Juanma Barranquero; +Cc: dgutov, Richard Stallman, 21953
>>>>> Juanma Barranquero <lekktu@gmail.com> writes:
> At least on Windows, that's not entirely true. I compile with very pedantic
> switches.
I'd love to address those as well, although I can't make it a blocker for
release. GNU platforms will have to determine the "gold standard", even if we
make it a point of pride to tackle warnings everywhere we find them.
On that note (and I think I mentioned in another thread), I'm working with
aconole on IRC to get the Coverity build up and running again regularly, which
should produce another volume of warnings to scan through. If it works well,
it should be like getting some free code review on our C. We'll see.
Finally, there is running under valgrind, and addressing warnings that appear
there too.
I would be quite happy if the 25.x cycle emphasized correctness and fewer bugs
over "headline features" leading up 26. It might not be as sexy or print-
worthy, but it builds a better foundation for future contributors.
John
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 17:37 ` John Wiegley
2015-11-19 17:46 ` Dmitry Gutov
2015-11-19 17:54 ` Eli Zaretskii
@ 2015-11-19 20:01 ` David Engster
2015-11-19 20:26 ` John Wiegley
2015-11-19 20:32 ` Eli Zaretskii
2015-11-20 10:41 ` Stephen Leake
3 siblings, 2 replies; 52+ messages in thread
From: David Engster @ 2015-11-19 20:01 UTC (permalink / raw
To: John Wiegley; +Cc: Dmitry Gutov, Richard Stallman, 21953
John Wiegley writes:
>>>>>> Dmitry Gutov <dgutov@yandex.ru> writes:
>
>> I can get behind taking care of "correctness" warnings, but if we lose the
>> obsolete functions warnings, we risk forgetting to take care of their
>> causes.
>>
>> And it's not like we can actually fix all instances of obsolete usages
>> before the current release: a significant part of the warnings comes from
>> gnus, org, cc-mode and calendar, all of which, I'm assuming, have to support
>> older Emacsen.
>
> If that's the case, I'm willing to filter those from the final count before
> closing this issue. Then, in 25.2, we can focus on eliminating those as well.
>
>> We _should_ be able to take care of CEDET warnings, but probably after their
>> development migrates here.
>
> That's good to hear; but can that happen for 25.1? CEDET is rather egregious
> in the warnings category right now. If that means suppressing warnings
> throughout CEDET for this release, I'm OK with that as a temporary measure.
We will fix those warnings for 25.1.
As you can see, almost all those warning are due to changes in EIEIO. We
couldn't fix those warnings until now because we wanted to support older
Emacsen as well. Since supporting both EIEIO versions would be a huge
hassle, we reluctantly decided to drop support for older Emacsen. At the
same time, we will also drop our upstream repository and move
development to Emacs.
I will have to do one last merge, but before I can do that, I have to
port our test suite to make sure I do it correctly. I hope I will find
the time to do all this before the new year.
-David
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 18:34 ` Juanma Barranquero
2015-11-19 19:05 ` John Wiegley
@ 2015-11-19 20:25 ` Eli Zaretskii
2015-11-19 20:31 ` Juanma Barranquero
1 sibling, 1 reply; 52+ messages in thread
From: Eli Zaretskii @ 2015-11-19 20:25 UTC (permalink / raw
To: Juanma Barranquero; +Cc: jwiegley, dgutov, rms, 21953
> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Thu, 19 Nov 2015 19:34:07 +0100
> Cc: John Wiegley <jwiegley@gmail.com>, dgutov@yandex.ru, Richard Stallman <rms@gnu.org>,
> 21953@debbugs.gnu.org
>
> Even so, I get 322 cases of "initialization discards 'const' qualifier from
> pointer target type", and leaving these aside, also this (# of warns, warning
> message)
Feel free to fix those, and thanks.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 20:01 ` David Engster
@ 2015-11-19 20:26 ` John Wiegley
2015-11-19 20:32 ` Eli Zaretskii
1 sibling, 0 replies; 52+ messages in thread
From: John Wiegley @ 2015-11-19 20:26 UTC (permalink / raw
To: David Engster; +Cc: Dmitry Gutov, Richard Stallman, 21953
>>>>> David Engster <deng@randomsample.de> writes:
> We will fix those warnings for 25.1.
[...]
> I will have to do one last merge, but before I can do that, I have to port
> our test suite to make sure I do it correctly. I hope I will find the time
> to do all this before the new year.
This is great to hear, thanks David!
John
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 19:05 ` John Wiegley
@ 2015-11-19 20:29 ` Eli Zaretskii
0 siblings, 0 replies; 52+ messages in thread
From: Eli Zaretskii @ 2015-11-19 20:29 UTC (permalink / raw
To: John Wiegley; +Cc: lekktu, dgutov, rms, 21953
> From: John Wiegley <jwiegley@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, dgutov@yandex.ru, Richard Stallman <rms@gnu.org>, 21953@debbugs.gnu.org
> Date: Thu, 19 Nov 2015 11:05:31 -0800
>
> >>>>> Juanma Barranquero <lekktu@gmail.com> writes:
>
> > At least on Windows, that's not entirely true. I compile with very pedantic
> > switches.
>
> I'd love to address those as well, although I can't make it a blocker for
> release. GNU platforms will have to determine the "gold standard", even if we
> make it a point of pride to tackle warnings everywhere we find them.
There's no reason whatsoever that warnings about discarding 'const'
should block any release.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 20:25 ` Eli Zaretskii
@ 2015-11-19 20:31 ` Juanma Barranquero
2015-11-19 20:51 ` Eli Zaretskii
0 siblings, 1 reply; 52+ messages in thread
From: Juanma Barranquero @ 2015-11-19 20:31 UTC (permalink / raw
To: Eli Zaretskii; +Cc: John Wiegley, dgutov, Richard Stallman, 21953
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
On Thu, Nov 19, 2015 at 9:25 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> Feel free to fix those, and thanks.
I'm assuming you don't mean the "discards 'const' qualifier" warnings, but
the others... ;-)
[-- Attachment #2: Type: text/html, Size: 334 bytes --]
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 20:01 ` David Engster
2015-11-19 20:26 ` John Wiegley
@ 2015-11-19 20:32 ` Eli Zaretskii
1 sibling, 0 replies; 52+ messages in thread
From: Eli Zaretskii @ 2015-11-19 20:32 UTC (permalink / raw
To: David Engster; +Cc: jwiegley, dgutov, rms, 21953
> From: David Engster <deng@randomsample.de>
> Date: Thu, 19 Nov 2015 21:01:35 +0100
> Cc: Dmitry Gutov <dgutov@yandex.ru>, Richard Stallman <rms@gnu.org>,
> 21953@debbugs.gnu.org
>
> I will have to do one last merge, but before I can do that, I have to
> port our test suite to make sure I do it correctly. I hope I will find
> the time to do all this before the new year.
I think this is good enough, thanks.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 20:31 ` Juanma Barranquero
@ 2015-11-19 20:51 ` Eli Zaretskii
2015-11-20 0:26 ` Juanma Barranquero
0 siblings, 1 reply; 52+ messages in thread
From: Eli Zaretskii @ 2015-11-19 20:51 UTC (permalink / raw
To: Juanma Barranquero; +Cc: jwiegley, dgutov, rms, 21953
> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Thu, 19 Nov 2015 21:31:15 +0100
> Cc: John Wiegley <jwiegley@gmail.com>, dgutov@yandex.ru, Richard Stallman <rms@gnu.org>,
> 21953@debbugs.gnu.org
>
> On Thu, Nov 19, 2015 at 9:25 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
> > Feel free to fix those, and thanks.
>
> I'm assuming you don't mean the "discards 'const' qualifier" warnings, but the
> others... ;-)
I mean whatever your itch is.
I routinely examine these warnings, usually when I add some
significant new code, and each time I find the warnings to be false
alarms. The problem with fixing them is that either you need to
sprinkle ugly casts everywhere, or you start changing declarations,
and that spreads warnings like cancer through all the related code,
and you end up changing too much, or hit a brick wall and use casts
again. So I normally fix low-hanging fruit, and leave the rest for a
rainy day.
But that's me. Any changes that bring these warnings down are
welcome, if you have no itches that need scratching more urgently.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 20:51 ` Eli Zaretskii
@ 2015-11-20 0:26 ` Juanma Barranquero
0 siblings, 0 replies; 52+ messages in thread
From: Juanma Barranquero @ 2015-11-20 0:26 UTC (permalink / raw
To: Eli Zaretskii; +Cc: John Wiegley, dgutov, Richard Stallman, 21953
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
On Thu, Nov 19, 2015 at 9:51 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> I routinely examine these warnings, usually when I add some
> significant new code, and each time I find the warnings to be false
> alarms. The problem with fixing them is that either you need to
> sprinkle ugly casts everywhere, or you start changing declarations,
> and that spreads warnings like cancer through all the related code,
> and you end up changing too much, or hit a brick wall and use casts
> again. So I normally fix low-hanging fruit, and leave the rest for a
> rainy day.
I do the same. There are quite a few that I've looked at, and decided they
were false alarms, or the fix was ugly.
[-- Attachment #2: Type: text/html, Size: 850 bytes --]
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 17:37 ` John Wiegley
` (2 preceding siblings ...)
2015-11-19 20:01 ` David Engster
@ 2015-11-20 10:41 ` Stephen Leake
3 siblings, 0 replies; 52+ messages in thread
From: Stephen Leake @ 2015-11-20 10:41 UTC (permalink / raw
To: John Wiegley; +Cc: Dmitry Gutov, Richard Stallman, 21953
"John Wiegley" <jwiegley@gmail.com> writes:
>>>>>> Dmitry Gutov <dgutov@yandex.ru> writes:
>
>> I can get behind taking care of "correctness" warnings, but if we lose the
>> obsolete functions warnings, we risk forgetting to take care of their
>> causes.
>>
>> And it's not like we can actually fix all instances of obsolete usages
>> before the current release: a significant part of the warnings comes from
>> gnus, org, cc-mode and calendar, all of which, I'm assuming, have to support
>> older Emacsen.
>
> If that's the case, I'm willing to filter those from the final count before
> closing this issue. Then, in 25.2, we can focus on eliminating those as well.
>
>> We _should_ be able to take care of CEDET warnings, but probably after their
>> development migrates here.
>
> That's good to hear; but can that happen for 25.1?
It must; some of CEDET is broken right now.
> CEDET is rather egregious
> in the warnings category right now. If that means suppressing warnings
> throughout CEDET for this release, I'm OK with that as a temporary
> measure.
No, some of those warnings are bugs. I've fixed a few, but I have not
fixed them all; I'm waiting for the merge.
--
-- Stephe
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-18 18:44 ` Eli Zaretskii
@ 2015-11-23 19:10 ` Glenn Morris
2015-11-23 22:04 ` John Wiegley
0 siblings, 1 reply; 52+ messages in thread
From: Glenn Morris @ 2015-11-23 19:10 UTC (permalink / raw
To: Eli Zaretskii; +Cc: 21953
Eli Zaretskii wrote:
> I agree that we cannot silence or solve all of them, but we should be
> able to do that with most of them.
I'm no fan of compilation warnings and have done my bit to remove them
over the years. There was a brief glorious period a long time ago when
there were none, but it did not last, and I doubt it will return.
Actually really removing all warnings will require changes of a scale
and nature that are incompatible (IMO) with a release branch, and
break backwards compatibility all over the place. There may be a
handful of issues that are "real" and can be fixed simply, but most of
these are about relatively deep changes in Emacs infrastructure (eg
prep for lexical binding) for which the codebase hasn't been entirely
updated. Slapping with-no-warnings all over the place would be
pointless at best, frankly harmful since it just covers the issue up
without dealing with it (might as well just set byte-compile-warnings
= nil in the Makefile for all the good it would do).
In any case, .elc files are pre-built in release tarfiles, so people
building releases don't even see these warnings. So making it a release
goal doesn't make sense to me.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-23 19:10 ` Glenn Morris
@ 2015-11-23 22:04 ` John Wiegley
2015-11-23 22:47 ` Drew Adams
2015-11-24 3:30 ` Eli Zaretskii
0 siblings, 2 replies; 52+ messages in thread
From: John Wiegley @ 2015-11-23 22:04 UTC (permalink / raw
To: Glenn Morris; +Cc: 21953
>>>>> Glenn Morris <rgm@gnu.org> writes:
> In any case, .elc files are pre-built in release tarfiles, so people
> building releases don't even see these warnings. So making it a release goal
> doesn't make sense to me.
You know, that's a really good point.
Perhaps this then: Development goal to reduce warnings as much as is feasible.
Long-term development goal to eliminate them. Release is not block either way.
How does that sound, Eli, if Drew is right about users not seeing the
warnings?
John
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-23 22:04 ` John Wiegley
@ 2015-11-23 22:47 ` Drew Adams
2015-11-24 3:30 ` Eli Zaretskii
1 sibling, 0 replies; 52+ messages in thread
From: Drew Adams @ 2015-11-23 22:47 UTC (permalink / raw
To: John Wiegley, Glenn Morris; +Cc: 21953
> >>>>> Glenn Morris <rgm@gnu.org> writes:
> > In any case, .elc files are pre-built in release tarfiles, so people
> > building releases don't even see these warnings. So making it a release
> > goal doesn't make sense to me.
...
> How does that sound, Eli, if Drew is right about users not seeing the
> warnings?
s/Drew/Glenn
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-23 22:04 ` John Wiegley
2015-11-23 22:47 ` Drew Adams
@ 2015-11-24 3:30 ` Eli Zaretskii
2015-11-24 3:40 ` John Wiegley
1 sibling, 1 reply; 52+ messages in thread
From: Eli Zaretskii @ 2015-11-24 3:30 UTC (permalink / raw
To: John Wiegley; +Cc: 21953
> From: John Wiegley <jwiegley@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, 21953@debbugs.gnu.org
> Date: Mon, 23 Nov 2015 14:04:15 -0800
>
> >>>>> Glenn Morris <rgm@gnu.org> writes:
>
> > In any case, .elc files are pre-built in release tarfiles, so people
> > building releases don't even see these warnings. So making it a release goal
> > doesn't make sense to me.
>
> You know, that's a really good point.
>
> Perhaps this then: Development goal to reduce warnings as much as is feasible.
> Long-term development goal to eliminate them. Release is not block either way.
>
> How does that sound, Eli, if Drew is right about users not seeing the
> warnings?
I thought this was how things were anyway.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-24 3:30 ` Eli Zaretskii
@ 2015-11-24 3:40 ` John Wiegley
2015-11-24 17:40 ` Glenn Morris
0 siblings, 1 reply; 52+ messages in thread
From: John Wiegley @ 2015-11-24 3:40 UTC (permalink / raw
To: Eli Zaretskii; +Cc: 21953
>>>>> Eli Zaretskii <eliz@gnu.org> writes:
>> > In any case, .elc files are pre-built in release tarfiles, so people
>> > building releases don't even see these warnings. So making it a release goal
>> > doesn't make sense to me.
>>
>> You know, that's a really good point.
>>
>> Perhaps this then: Development goal to reduce warnings as much as is feasible.
>> Long-term development goal to eliminate them. Release is not block either way.
>>
>> How does that sound, Eli, if Drew is right about users not seeing the
>> warnings?
> I thought this was how things were anyway.
Alright, business as normal then.
John
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-24 3:40 ` John Wiegley
@ 2015-11-24 17:40 ` Glenn Morris
2015-11-25 1:03 ` John Wiegley
0 siblings, 1 reply; 52+ messages in thread
From: Glenn Morris @ 2015-11-24 17:40 UTC (permalink / raw
To: John Wiegley; +Cc: 21953
In that case I suggest that having this as an open bug report won't
really help much, so personally I suggest closing it.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
[not found] ` <mailman.233.1447954214.31583.bug-gnu-emacs@gnu.org>
@ 2015-11-24 19:55 ` Alan Mackenzie
2015-11-25 0:28 ` Dmitry Gutov
0 siblings, 1 reply; 52+ messages in thread
From: Alan Mackenzie @ 2015-11-24 19:55 UTC (permalink / raw
To: 21953; +Cc: Dmitry Gutov
In article <mailman.233.1447954214.31583.bug-gnu-emacs@gnu.org> you wrote:
> On 11/19/2015 04:06 AM, John Wiegley wrote:
>> I've never worked on a project where getting to warning free was not both
>> achievable, and a good idea.
> What will you get, as a result?
> I can get behind taking care of "correctness" warnings, but if we lose
> the obsolete functions warnings, we risk forgetting to take care of
> their causes.
> And it's not like we can actually fix all instances of obsolete usages
> before the current release: a significant part of the warnings comes
> from gnus, org, cc-mode .....
Sir, I take exception to that! :-) Last time I looked (about 10 minutes
ago), CC Mode produced but a single byte compiler warning.
> .... and calendar, all of which, I'm assuming, have to support older
> Emacsen.
That partly explains the warning left in CC Mode, yes.
> We _should_ be able to take care of CEDET warnings, but probably after
> their development migrates here.
--
Alan Mackenzie (Nuremberg, Germany).
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-24 19:55 ` Alan Mackenzie
@ 2015-11-25 0:28 ` Dmitry Gutov
2015-11-25 9:31 ` Alan Mackenzie
0 siblings, 1 reply; 52+ messages in thread
From: Dmitry Gutov @ 2015-11-25 0:28 UTC (permalink / raw
To: Alan Mackenzie, 21953
On 11/24/2015 09:55 PM, Alan Mackenzie wrote:
> Sir, I take exception to that! :-) Last time I looked (about 10 minutes
> ago), CC Mode produced but a single byte compiler warning.
That's a pretty cool result. I don't see any warnings left, actually.
> That partly explains the warning left in CC Mode, yes.
I see you're taking a systematic approach to backward compatibility,
with dynamic selection of definitions, aliases (and probably something
else). Were any of those made specifically to avoid a byte-compilation
warning? I wonder if that's worth it.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-24 17:40 ` Glenn Morris
@ 2015-11-25 1:03 ` John Wiegley
0 siblings, 0 replies; 52+ messages in thread
From: John Wiegley @ 2015-11-25 1:03 UTC (permalink / raw
To: Glenn Morris; +Cc: 21953-done
>>>>> Glenn Morris <rgm@gnu.org> writes:
> In that case I suggest that having this as an open bug report won't really
> help much, so personally I suggest closing it.
Done.
John
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-25 0:28 ` Dmitry Gutov
@ 2015-11-25 9:31 ` Alan Mackenzie
2015-11-25 14:36 ` Dmitry Gutov
2015-11-25 18:54 ` Glenn Morris
0 siblings, 2 replies; 52+ messages in thread
From: Alan Mackenzie @ 2015-11-25 9:31 UTC (permalink / raw
To: Dmitry Gutov; +Cc: 21953
Hello, Dmitry.
On Wed, Nov 25, 2015 at 02:28:32AM +0200, Dmitry Gutov wrote:
> On 11/24/2015 09:55 PM, Alan Mackenzie wrote:
> > Sir, I take exception to that! :-) Last time I looked (about 10 minutes
> > ago), CC Mode produced but a single byte compiler warning.
> That's a pretty cool result. I don't see any warnings left, actually.
Actually, at the time I wrote that email, there were two. One of those
only showed itself when the cc-*.el files were compiled one at a time
(as is done in building Emacs) rather than all together. But I've got
rid of these last two too.
> > That partly explains the warning left in CC Mode, yes.
> I see you're taking a systematic approach to backward compatibility,
> with dynamic selection of definitions, aliases (and probably something
> else). Were any of those made specifically to avoid a byte-compilation
> warning? I wonder if that's worth it.
The backward compatibility stuff has been there for decades (well, over
ten years anyway, possibly over twenty). Most of the stuff in cc-fix.el
has been fixed in all supported platforms, in particular in Emacs. That
is why cc-fix.el isn't needed (and doesn't exist) in Emacs. But
`delete-dups' still doesn't exist in XEmacs 21.4.x.
Whether it's worth it? I suppose, some time "soon", I should get rid of
backward compatibility stuff not needed any more, and also wierd hacks
(like defining a function with "(eval '(defun cc-bytecomp-load ...))"
because a proper byte compilation caused XEmacs to dump core back in
2003).
--
Alan Mackenzie (Nuremberg, Germany).
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-25 9:31 ` Alan Mackenzie
@ 2015-11-25 14:36 ` Dmitry Gutov
2015-11-25 15:50 ` Alan Mackenzie
2015-11-25 18:54 ` Glenn Morris
1 sibling, 1 reply; 52+ messages in thread
From: Dmitry Gutov @ 2015-11-25 14:36 UTC (permalink / raw
To: Alan Mackenzie; +Cc: 21953
Hi Alan,
On 11/25/2015 11:31 AM, Alan Mackenzie wrote:
> Actually, at the time I wrote that email, there were two. One of those
> only showed itself when the cc-*.el files were compiled one at a time
> (as is done in building Emacs) rather than all together. But I've got
> rid of these last two too.
Right. Apparently, I just tested with that last fix already pulled.
> The backward compatibility stuff has been there for decades (well, over
> ten years anyway, possibly over twenty). Most of the stuff in cc-fix.el
> has been fixed in all supported platforms, in particular in Emacs. That
> is why cc-fix.el isn't needed (and doesn't exist) in Emacs. But
> `delete-dups' still doesn't exist in XEmacs 21.4.x.
I meant specifically compatibility code designed to avoid byte
compilation warnings (like ones about obsolete functions usage), but not
errors, on any of the supported platforms.
I've been under impression that an old-enough package must have some of
those.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-25 14:36 ` Dmitry Gutov
@ 2015-11-25 15:50 ` Alan Mackenzie
0 siblings, 0 replies; 52+ messages in thread
From: Alan Mackenzie @ 2015-11-25 15:50 UTC (permalink / raw
To: Dmitry Gutov; +Cc: 21953
Hello, Dmitry.
On Wed, Nov 25, 2015 at 04:36:28PM +0200, Dmitry Gutov wrote:
> Hi Alan,
> On 11/25/2015 11:31 AM, Alan Mackenzie wrote:
> > Actually, at the time I wrote that email, there were two. One of those
> > only showed itself when the cc-*.el files were compiled one at a time
> > (as is done in building Emacs) rather than all together. But I've got
> > rid of these last two too.
> Right. Apparently, I just tested with that last fix already pulled.
> > The backward compatibility stuff has been there for decades (well, over
> > ten years anyway, possibly over twenty). Most of the stuff in cc-fix.el
> > has been fixed in all supported platforms, in particular in Emacs. That
> > is why cc-fix.el isn't needed (and doesn't exist) in Emacs. But
> > `delete-dups' still doesn't exist in XEmacs 21.4.x.
> I meant specifically compatibility code designed to avoid byte
> compilation warnings (like ones about obsolete functions usage), but not
> errors, on any of the supported platforms.
There are none of these in CC Mode, so far as I'm aware.
But it seems to me we are getting a lot more of these "obsolete"
warnings than we used to - well over 800 at the latest count.
> I've been under impression that an old-enough package must have some of
> those.
I would have thought so too.
--
Alan Mackenzie (Nuremberg, Germany).
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-25 9:31 ` Alan Mackenzie
2015-11-25 14:36 ` Dmitry Gutov
@ 2015-11-25 18:54 ` Glenn Morris
1 sibling, 0 replies; 52+ messages in thread
From: Glenn Morris @ 2015-11-25 18:54 UTC (permalink / raw
To: Alan Mackenzie; +Cc: Dmitry Gutov, 21953
Alan Mackenzie wrote:
> The backward compatibility stuff has been there for decades (well, over
> ten years anyway, possibly over twenty). Most of the stuff in cc-fix.el
> has been fixed in all supported platforms, in particular in Emacs. That
> is why cc-fix.el isn't needed (and doesn't exist) in Emacs. But
> `delete-dups' still doesn't exist in XEmacs 21.4.x.
>
> Whether it's worth it? I suppose, some time "soon", I should get rid of
> backward compatibility stuff not needed any more, and also wierd hacks
> (like defining a function with "(eval '(defun cc-bytecomp-load ...))"
> because a proper byte compilation caused XEmacs to dump core back in
> 2003).
Stefan has offered to clean this stuff up several times, eg most recently
http://debbugs.gnu.org/21466
I really wish you'd take him up on his offers.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-19 17:54 ` Eli Zaretskii
2015-11-19 18:18 ` John Wiegley
2015-11-19 18:34 ` Juanma Barranquero
@ 2015-11-25 20:58 ` Andy Moreton
2015-11-26 17:55 ` Eli Zaretskii
2 siblings, 1 reply; 52+ messages in thread
From: Andy Moreton @ 2015-11-25 20:58 UTC (permalink / raw
To: 21953
On Thu 19 Nov 2015, Eli Zaretskii wrote:
>> From: "John Wiegley" <jwiegley@gmail.com>
>> Date: Thu, 19 Nov 2015 09:37:16 -0800
>> Cc: Richard Stallman <rms@gnu.org>, 21953@debbugs.gnu.org
>>
>> By 25.2, anything that is built using "make" should be warning free, both C
>> and Emacs Lisp
>
> We can stop worrying about warnings in C: there are none, and a few
> people regularly compile with pedantic compiler switches and fix
> whatever they flag.
There are three in the mingw64 build (on emacs-25 or master branch):
../../src/w32.c: In function 'sys_socket':
../../src/w32.c:7435:14: warning: overflow in implicit constant conversion [-Woverflow]
return INVALID_SOCKET;
^
../../src/w32.c: In function 'maybe_load_unicows_dll':
../../src/w32.c:9273:25: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
pMultiByteToWideChar = GetProcAddress (ret, "MultiByteToWideChar");
^
../../src/w32.c:9274:25: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
pWideCharToMultiByte = GetProcAddress (ret, "WideCharToMultiByte");
^
The following patch fixes them. Note that on 64bit windows a socket
handle is a 64bit type, so using int for socket handles is not entirely
correct, but does not seem to cause problems.
diff --git a/src/w32.c b/src/w32.c
index 9601012acd6a..bf91742ca405 100644
--- a/src/w32.c
+++ b/src/w32.c
@@ -7432,7 +7432,7 @@ sys_socket (int af, int type, int protocol)
if (winsock_lib == NULL)
{
errno = ENETDOWN;
- return INVALID_SOCKET;
+ return (int) INVALID_SOCKET;
}
check_errno ();
@@ -9270,8 +9270,10 @@ maybe_load_unicows_dll (void)
pointers, and assign the correct addresses to these
pointers at program startup (see emacs.c, which calls
this function early on). */
- pMultiByteToWideChar = GetProcAddress (ret, "MultiByteToWideChar");
- pWideCharToMultiByte = GetProcAddress (ret, "WideCharToMultiByte");
+ pMultiByteToWideChar =
+ (MultiByteToWideChar_Proc) GetProcAddress (ret, "MultiByteToWideChar");
+ pWideCharToMultiByte =
+ (WideCharToMultiByte_Proc) GetProcAddress (ret, "WideCharToMultiByte");
return ret;
}
else
diff --git a/src/w32.h b/src/w32.h
index 2c711502593a..ee321a388945 100644
--- a/src/w32.h
+++ b/src/w32.h
@@ -179,8 +179,11 @@ extern int _sys_wait_connect (int fd);
extern HMODULE w32_delayed_load (Lisp_Object);
-extern int (WINAPI *pMultiByteToWideChar)(UINT,DWORD,LPCSTR,int,LPWSTR,int);
-extern int (WINAPI *pWideCharToMultiByte)(UINT,DWORD,LPCWSTR,int,LPSTR,int,LPCSTR,LPBOOL);
+typedef int (WINAPI *MultiByteToWideChar_Proc)(UINT,DWORD,LPCSTR,int,LPWSTR,int);
+extern MultiByteToWideChar_Proc pMultiByteToWideChar;
+
+typedef int (WINAPI *WideCharToMultiByte_Proc)(UINT,DWORD,LPCWSTR,int,LPSTR,int,LPCSTR,LPBOOL);
+extern WideCharToMultiByte_Proc pWideCharToMultiByte;
extern void init_environment (char **);
extern void check_windows_init_file (void);
^ permalink raw reply related [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-18 17:44 bug#21953: Eliminate warnings in the emacs-25 release branch John Wiegley
` (5 preceding siblings ...)
[not found] ` <mailman.233.1447954214.31583.bug-gnu-emacs@gnu.org>
@ 2015-11-26 8:33 ` Andreas Röhler
2015-11-26 15:51 ` Eli Zaretskii
6 siblings, 1 reply; 52+ messages in thread
From: Andreas Röhler @ 2015-11-26 8:33 UTC (permalink / raw
To: 21953; +Cc: John Wiegley
Am 18.11.2015 um 18:44 schrieb John Wiegley:
> By my count today, there are 461 byte-compilation warnings on the emacs-25
> branch. This issue is here as a release blocker to deal with, or silence,
> these warnings.
>
> How do I mark this as a release blocker when creating an e-mail report?
>
> John
>
> abbrev.el:847:8:Warning: ‘with-wrapper-hook’ is an obsolete macro (as of
> emacs-lisp/byte-run.el:48:1:Warning: ‘macro-declaration-function’ is an
> emacs-lisp/float-sup.el:31:1:Warning: global/dynamic var ‘pi’ lacks a prefix
> emacs-lisp/lisp.el:367:27:Warning: ‘syntax-begin-function’ is an obsolete
> files.el:1697:8:Warning: function create-file-buffer used to take 0+
> font-lock.el:641:47:Warning: ‘font-lock-fontify-buffer’ is for interactive use
> font-lock.el:1755:34:Warning: ‘syntax-begin-function’ is an obsolete variable
> menu-bar.el:417:11:Warning: reference to free variable ‘xref-find-function’
> minibuffer.el:1697:12:Warning: display-completion-list called with 2
> minibuffer.el:1966:62:Warning: ‘with-wrapper-hook’ is an obsolete macro (as of
> minibuffer.el:2924:1:Warning: Unused lexical variable ‘p1’
> minibuffer.el:2924:1:Warning: Unused lexical variable ‘p2’
> replace.el:2235:36:Warning: looking-back called with 1 argument, but requires
> simple.el:4018:52:Warning: ‘with-wrapper-hook’ is an obsolete macro (as of
> startup.el:115:1:Warning: global/dynamic var ‘argv’ lacks a prefix
> startup.el:122:1:Warning: global/dynamic var ‘argi’ lacks a prefix
> subr.el:32:11:Warning: macro declare-function used to take 2+ arguments, now
> dirtrack.el:183:1:Warning: global/dynamic var ‘dirtrackp’ lacks a prefix
> ehelp.el:358:10:Warning: ‘execute-extended-command’ is for interactive use
> epa-mail.el:75:4:Warning: ‘epa-decrypt-armor-in-region’ is for interactive use
> epa-mail.el:83:4:Warning: ‘epa-verify-cleartext-in-region’ is for interactive
> epa-mail.el:109:10:Warning: ‘epa-sign-region’ is for interactive use only.
> epa-mail.el:228:12:Warning: ‘epa-encrypt-region’ is for interactive use only.
> epa.el:1008:19:Warning: ‘epa-verify-region’ is for interactive use only.
> ffap.el:984:63:Warning: assignment to free variable ‘kpsewhich-args’
> ffap.el:984:59:Warning: reference to free variable ‘kpsewhich-args’
> htmlfontify.el:1820:13:Warning: ‘font-lock-fontify-buffer’ is for interactive
> isearchb.el:80:1:Warning: Package iswitchb is obsolete!
> pcmpl-gnu.el:162:47:Warning: ‘pcomplete-suffix-list’ is an obsolete variable
> pcomplete.el:1017:11:Warning: macro ‘pcomplete-here’ defined too late
> server.el:1705:1:Warning: the function ‘cygwin-convert-file-name-from-windows’
> calendar/appt.el:548:1:Warning: global/dynamic var ‘number’ lacks a prefix
> calendar/cal-bahai.el:316:1:Warning: global/dynamic var ‘date’ lacks a prefix
> calendar/cal-china.el:635:1:Warning: global/dynamic var ‘date’ lacks a prefix
> calendar/cal-china.el:653:1:Warning: global/dynamic var ‘entry’ lacks a prefix
> calendar/cal-coptic.el:171:1:Warning: global/dynamic var ‘date’ lacks a prefix
> calendar/cal-french.el:246:1:Warning: global/dynamic var ‘date’ lacks a prefix
> calendar/cal-hebrew.el:751:1:Warning: global/dynamic var ‘date’ lacks a prefix
> calendar/cal-hebrew.el:759:1:Warning: global/dynamic var ‘entry’ lacks a
> calendar/cal-islam.el:308:1:Warning: global/dynamic var ‘date’ lacks a prefix
> calendar/cal-iso.el:132:1:Warning: global/dynamic var ‘date’ lacks a prefix
> calendar/cal-julian.el:186:1:Warning: global/dynamic var ‘date’ lacks a prefix
> calendar/cal-mayan.el:356:1:Warning: global/dynamic var ‘date’ lacks a prefix
> calendar/cal-persia.el:199:1:Warning: global/dynamic var ‘date’ lacks a prefix
> calendar/diary-lib.el:715:1:Warning: global/dynamic var ‘number’ lacks a
> calendar/diary-lib.el:1812:1:Warning: global/dynamic var ‘date’ lacks a prefix
> calendar/diary-lib.el:1813:1:Warning: global/dynamic var ‘entry’ lacks a
> calendar/lunar.el:244:1:Warning: global/dynamic var ‘date’ lacks a prefix
> calendar/solar.el:890:1:Warning: global/dynamic var ‘date’ lacks a prefix
> calendar/time-date.el:134:11:Warning: ‘encode-time-value’ is an obsolete
> calendar/time-date.el:260:24:Warning: ‘encode-time-value’ is an obsolete
> calendar/time-date.el:268:27:Warning: ‘encode-time-value’ is an obsolete
> calendar/todo-mode.el:4664:24:Warning: looking-back called with 1 argument,
> cedet/ede.el:1540:1:Warning: the following functions might not be defined at
> cedet/mode-local.el:641:42:Warning: reference to free variable
> cedet/semantic.el:1188:15:Warning: Unknown slot ‘bounds’
> cedet/ede/base.el:631:34:Warning: Unknown slot ‘:file’
> cedet/ede/base.el:634:69:Warning: Unknown slot ‘:directory’
> cedet/ede/config.el:164:17:Warning: Unknown slot ‘:directory’
> cedet/ede/config.el:260:23:Warning: Unknown slot ‘:debug-command’
> cedet/ede/config.el:277:34:Warning: Unknown slot ‘:run-command’
> cedet/ede/config.el:308:22:Warning: Unknown slot ‘:build-command’
> cedet/ede/config.el:383:17:Warning: Unknown slot ‘:c-preprocessor-files’
> cedet/ede/config.el:386:11:Warning: Unknown slot ‘lexical-table’
> cedet/ede/config.el:388:5:Warning: Unknown slot ‘:c-preprocessor-table’
> cedet/ede/config.el:413:36:Warning: Unknown slot ‘:classpath’
> cedet/ede/cpp-root.el:284:13:Warning: Unknown slot ‘:file’
> cedet/ede/cpp-root.el:444:30:Warning: Unknown slot ‘lexical-table’
> cedet/ede/cpp-root.el:456:78:Warning: Unknown slot ‘:compile-command’
> cedet/ede/cpp-root.el:464:30:Warning: Unknown slot ‘:local-variables’
> cedet/ede/cpp-root.el:472:75:Warning: Unknown slot ‘:project’
> cedet/ede/detect.el:204:49:Warning: ‘eieio-object-name-string’ is an obsolete
> cedet/ede/emacs.el:227:13:Warning: Unknown slot ‘lexical-table’
> cedet/ede/emacs.el:227:43:Warning: Unknown slot ‘lexical-table’
> cedet/ede/files.el:123:26:Warning: Unknown slot ‘:directory’
> cedet/ede/files.el:211:31:Warning: Unknown slot ‘:directory’
> cedet/ede/files.el:207:20:Warning: Unknown slot ‘:directory’
> cedet/ede/files.el:231:36:Warning: Unknown slot ‘:directory’
> cedet/ede/files.el:359:12:Warning: Unknown slot ‘:directory’
> cedet/ede/files.el:368:13:Warning: Unknown slot ‘:directory’
> cedet/ede/linux.el:309:29:Warning: Unknown slot ‘lexical-table’
> cedet/ede/proj-archive.el:35:1:Warning: Obsolete name arg "ede-archive-linker"
> cedet/ede/proj-aux.el:36:1:Warning: Obsolete name arg "ede-aux-source-txt" to
> cedet/ede/proj-elisp.el:79:1:Warning: Obsolete name arg "ede-emacs-source" to
> cedet/ede/proj-elisp.el:86:1:Warning: Obsolete name arg "ede-emacs-compiler"
> cedet/ede/proj-elisp.el:97:18:Warning: Obsolete name arg
> cedet/ede/proj-elisp.el:325:1:Warning: Obsolete name arg
> cedet/ede/proj-elisp.el:336:89:Warning: Obsolete name arg "clean-autoloads" to
> cedet/ede/proj-info.el:45:1:Warning: Obsolete name arg "ede-makeinfo-source"
> cedet/ede/proj-info.el:52:1:Warning: Obsolete name arg "ede-makeinfo-compiler"
> cedet/ede/proj-info.el:63:1:Warning: Obsolete name arg
> cedet/ede/proj-misc.el:51:1:Warning: Obsolete name arg "ede-misc-source" to
> cedet/ede/proj-misc.el:57:1:Warning: Obsolete name arg "ede-misc-compile" to
> cedet/ede/proj-obj.el:85:1:Warning: Obsolete name arg "ede-source-c" to
> cedet/ede/proj-obj.el:93:1:Warning: Obsolete name arg "ede-c-compiler-gcc" to
> cedet/ede/proj-obj.el:105:18:Warning: Obsolete name arg "c-inference-rule" to
> cedet/ede/proj-obj.el:116:1:Warning: Obsolete name arg "ede-cc-linker" to
> cedet/ede/proj-obj.el:126:1:Warning: Obsolete name arg "ede-source-c++" to
> cedet/ede/proj-obj.el:134:1:Warning: Obsolete name arg "ede-c-compiler-g++" to
> cedet/ede/proj-obj.el:147:18:Warning: Obsolete name arg "c++-inference-rule"
> cedet/ede/proj-obj.el:158:1:Warning: Obsolete name arg "ede-g++-linker" to
> cedet/ede/proj-obj.el:171:1:Warning: Obsolete name arg "ede-source-lex" to
> cedet/ede/proj-obj.el:178:1:Warning: Obsolete name arg "ede-lex-compiler" to
> cedet/ede/proj-obj.el:187:1:Warning: Obsolete name arg "ede-source-yacc" to
> cedet/ede/proj-obj.el:194:1:Warning: Obsolete name arg "ede-yacc-compiler" to
> cedet/ede/proj-obj.el:205:1:Warning: Obsolete name arg "ede-source-f90" to
> cedet/ede/proj-obj.el:213:1:Warning: Obsolete name arg "ede-source-f77" to
> cedet/ede/proj-obj.el:221:1:Warning: Obsolete name arg
> cedet/ede/proj-obj.el:233:18:Warning: Obsolete name arg "f90-inference-rule"
> cedet/ede/proj-obj.el:254:1:Warning: Obsolete name arg "ede-gfortran-linker"
> cedet/ede/proj-obj.el:266:1:Warning: Obsolete name arg "ede-ld-linker" to
> cedet/ede/proj-shared.el:81:24:Warning: Obsolete name arg
> cedet/ede/proj-shared.el:128:24:Warning: Obsolete name arg
> cedet/ede/project-am.el:662:32:Warning: Unknown slot ‘:file’
> cedet/ede/project-am.el:697:66:Warning: Unknown slot ‘:source’
> cedet/ede/project-am.el:699:16:Warning: Unknown slot ‘:name’
> cedet/ede/project-am.el:801:49:Warning: Unknown slot ‘:path’
> cedet/ede/project-am.el:809:17:Warning: Unknown slot ‘:include’
> cedet/ede/project-am.el:818:49:Warning: Unknown slot ‘:path’
> cedet/ede/project-am.el:818:68:Warning: Unknown slot ‘:source’
> cedet/ede/project-am.el:830:48:Warning: Unknown slot ‘:name’
> cedet/ede/project-am.el:996:31:Warning: Unknown slot ‘:directory’
> cedet/ede/shell.el:41:20:Warning: Unknown slot ‘:directory’
> cedet/ede/simple.el:48:15:Warning: Obsolete name arg "simple-overlay" to
> cedet/ede/source.el:158:1:Warning: Obsolete name arg "ede-source-scheme" to
> cedet/ede/util.el:44:28:Warning: Unknown slot ‘:version’
> cedet/semantic/analyze.el:205:18:Warning: Unknown slot ‘:prefix’
> cedet/semantic/analyze.el:213:5:Warning: Unknown slot ‘:function’
> cedet/semantic/analyze.el:218:5:Warning: Unknown slot ‘:assignee’
> cedet/semantic/analyze.el:666:22:Warning: Obsolete name arg "functionargument"
> cedet/semantic/analyze.el:673:24:Warning: Obsolete name arg "assignment" to
> cedet/semantic/analyze.el:698:15:Warning: Obsolete name arg "context" to
> cedet/semantic/analyze.el:748:13:Warning: Unknown slot ‘:buffer’
> cedet/semantic/analyze.el:749:38:Warning: Unknown slot ‘:bounds’
> cedet/semantic/chart.el:155:34:Warning: Unknown slot ‘filestream’
> cedet/semantic/chart.el:155:37:Warning: Unknown slot ‘includestream’
> cedet/semantic/chart.el:158:31:Warning: Unknown slot ‘fullscope’
> cedet/semantic/chart.el:165:41:Warning: Unknown slot ‘localvar’
> cedet/semantic/complete.el:1286:49:Warning: Unknown slot ‘:table’
> cedet/semantic/complete.el:1892:43:Warning: Obsolete name arg "simple" to
> cedet/semantic/complete.el:1947:8:Warning: Obsolete name arg "inline" to
> cedet/semantic/complete.el:2038:22:Warning: Obsolete name arg "inline" to
> cedet/semantic/db-el.el:80:1:Warning: Obsolete name arg "Emacs" to constructor
> cedet/semantic/db-el.el:346:1:Warning: the function
> cedet/semantic/db-find.el:366:49:Warning: ‘semanticdb-table-child-p’ is an
> cedet/semantic/db-find.el:407:23:Warning: ‘semanticdb-abstract-table-child-p’
> cedet/semantic/db-find.el:912:20:Warning: ‘semanticdb-abstract-table-child-p’
> cedet/semantic/db-find.el:942:39:Warning: ‘semanticdb-abstract-table-child-p’
> cedet/semantic/db-global.el:93:8:Warning: Obsolete name arg "global" to
> cedet/semantic/db-global.el:194:26:Warning: Unknown slot ‘:hit-text’
> cedet/semantic/db-javascript.el:99:1:Warning: Obsolete name arg "Javascript"
> cedet/semantic/db-ref.el:91:49:Warning: ‘semanticdb-table-child-p’ is an
> cedet/semantic/db-ref.el:168:50:Warning: Obsolete name arg "DEBUG" to
> cedet/semantic/db-typecache.el:562:49:Warning: Unknown slot ‘:major-mode’
> cedet/semantic/debug.el:171:88:Warning: Unknown slot ‘:source-buffer’
> cedet/semantic/debug.el:213:17:Warning: Unknown slot ‘:parser-buffer’
> cedet/semantic/debug.el:365:28:Warning: Obsolete name arg "Debug Interface" to
> cedet/semantic/ede-grammar.el:69:1:Warning: Obsolete name arg
> cedet/semantic/ede-grammar.el:81:1:Warning: Obsolete name arg
> cedet/semantic/ede-grammar.el:92:18:Warning: Obsolete name arg
> cedet/semantic/ede-grammar.el:100:1:Warning: Obsolete name arg
> cedet/semantic/ede-grammar.el:108:1:Warning: Obsolete name arg
> cedet/semantic/ede-grammar.el:119:18:Warning: Obsolete name arg
> cedet/semantic/grammar.el:1923:40:Warning: Unknown slot ‘:prefix’
> cedet/semantic/grammar.el:1933:10:Warning: Unknown slot ‘prefixclass’
> cedet/semantic/idle.el:905:38:Warning: Unknown slot ‘bounds’
> cedet/semantic/idle.el:906:37:Warning: Unknown slot ‘prefix’
> cedet/semantic/idle.el:1189:25:Warning: Unknown slot ‘parents’
> cedet/semantic/idle.el:1189:44:Warning: Unknown slot ‘tag’
> cedet/semantic/mru-bookmark.el:168:1:Warning: Obsolete name arg "Ring" to
> cedet/semantic/mru-bookmark.el:322:36:Warning: Unknown slot ‘:object-name’
> cedet/semantic/scope.el:319:23:Warning: Obsolete name arg "mini" to
> cedet/semantic/senator.el:577:23:Warning: Unknown slot ‘parents’
> cedet/semantic/symref.el:110:24:Warning: Unknown slot ‘:metasubproject’
> cedet/semantic/symref.el:332:20:Warning: Unknown slot ‘:hit-lines’
> cedet/semantic/symref.el:365:31:Warning: Unknown slot ‘:searchfor’
> cedet/semantic/symref.el:365:31:Warning: Unknown slot ‘:created-by’
> cedet/semantic/symref.el:366:48:Warning: Unknown slot ‘:searchtype’
> cedet/semantic/symref.el:546:44:Warning: Unknown slot ‘:resulttype’
> cedet/semantic/texi.el:415:17:Warning: Unknown slot ‘:prefix’
> cedet/semantic/texi.el:428:64:Warning: Unknown slot ‘:prefixclass’
> cedet/semantic/texi.el:691:1:Warning: the function ‘semantic-analyze-context’
> cedet/semantic/util.el:113:11:Warning: ‘semanticdb-abstract-table-child-p’ is
> cedet/semantic/analyze/complete.el:91:24:Warning:
> cedet/semantic/analyze/debug.el:478:63:Warning: Unknown slot ‘:scope’
> cedet/semantic/analyze/refs.el:106:29:Warning: Unknown slot ‘:tag’
> cedet/semantic/bovine/debug.el:61:52:Warning: Obsolete name arg "frame" to
> cedet/semantic/bovine/debug.el:119:50:Warning: Obsolete name arg "frame" to
> cedet/semantic/bovine/make.el:200:15:Warning: Unknown slot ‘:prefixclass’
> cedet/semantic/bovine/make.el:196:63:Warning: Unknown slot ‘:prefix’
> cedet/semantic/bovine/scm-by.el:231:1:Warning: the function
> cedet/semantic/decorate/include.el:444:8:Warning: Unknown slot ‘:major-mode’
> cedet/semantic/decorate/include.el:447:15:Warning: Unknown slot ‘:tags’
> cedet/semantic/decorate/include.el:451:8:Warning: Unknown slot ‘:pointmax’
> cedet/semantic/decorate/include.el:806:58:Warning: ‘eieio-object-name-string’
> cedet/semantic/decorate/include.el:812:46:Warning: ‘eieio-object-name-string’
> cedet/semantic/symref/cscope.el:54:14:Warning: Unknown slot ‘:searchfor’
> cedet/semantic/symref/cscope.el:54:45:Warning: Unknown slot ‘:searchtype’
> cedet/semantic/symref/cscope.el:55:45:Warning: Unknown slot ‘:resulttype’
> cedet/semantic/symref/cscope.el:56:45:Warning: Unknown slot ‘:searchscope’
> cedet/semantic/symref/global.el:43:13:Warning: Unknown slot ‘:searchfor’
> cedet/semantic/symref/global.el:43:48:Warning: Unknown slot ‘:searchtype’
> cedet/semantic/symref/global.el:44:48:Warning: Unknown slot ‘:resulttype’
> cedet/semantic/symref/global.el:45:48:Warning: Unknown slot ‘:searchscope’
> cedet/semantic/symref/grep.el:90:1:Warning: global/dynamic var ‘grepflags’
> cedet/semantic/symref/grep.el:91:1:Warning: global/dynamic var ‘greppattern’
> cedet/semantic/symref/grep.el:143:19:Warning: Unknown slot ‘:searchtype’
> cedet/semantic/symref/grep.el:180:68:Warning: Unknown slot ‘:resulttype’
> cedet/semantic/symref/idutils.el:43:13:Warning: Unknown slot ‘:searchfor’
> cedet/semantic/symref/idutils.el:43:45:Warning: Unknown slot ‘:searchtype’
> cedet/semantic/symref/idutils.el:44:45:Warning: Unknown slot ‘:resulttype’
> cedet/semantic/symref/idutils.el:45:45:Warning: Unknown slot ‘:searchscope’
> cedet/semantic/symref/list.el:214:24:Warning: Unknown slot ‘:hit-tags’
> cedet/semantic/symref/list.el:408:4:Warning: Unknown slot ‘:searchfor’
> cedet/semantic/symref/list.el:408:4:Warning: Unknown slot ‘:created-by’
> cedet/srecode/args.el:180:37:Warning: Unknown slot ‘:version’
> cedet/srecode/compile.el:141:34:Warning: Unknown slot ‘key’
> cedet/srecode/compile.el:552:34:Warning: Unknown slot ‘:object-name’
> cedet/srecode/compile.el:553:46:Warning: Unknown slot ‘:context’
> cedet/srecode/compile.el:601:4:Warning: ‘eieio-object-name-string’ is an
> cedet/srecode/compile.el:647:4:Warning: ‘eieio-object-name-string’ is an
> cedet/srecode/compile.el:647:36:Warning: Unknown slot ‘:secondname’
> cedet/srecode/cpp.el:122:59:Warning: Unknown slot ‘:prime’
> cedet/srecode/ctxt.el:179:9:Warning: Unknown slot ‘object-name’
> cedet/srecode/dictionary.el:125:35:Warning: Unknown slot ‘:value’
> cedet/srecode/dictionary.el:227:18:Warning: Unknown slot ‘:tables’
> cedet/srecode/dictionary.el:541:29:Warning: Unknown slot ‘:object-name’
> cedet/srecode/dictionary.el:543:22:Warning: Unknown slot ‘prompt’
> cedet/srecode/dictionary.el:544:22:Warning: Unknown slot ‘read-fcn’
> cedet/srecode/el.el:86:54:Warning: Unknown slot ‘:prime’
> cedet/srecode/extract.el:90:46:Warning: Obsolete name arg "state" to
> cedet/srecode/extract.el:163:33:Warning: Unknown slot ‘:object-name’
> cedet/srecode/find.el:99:53:Warning: Unknown slot ‘:project’
> cedet/srecode/find.el:142:22:Warning: Unknown slot ‘:tables’
> cedet/srecode/find.el:148:54:Warning: Unknown slot ‘:application’
> cedet/srecode/find.el:151:9:Warning: Unknown slot ‘:major-mode’
> cedet/srecode/find.el:248:57:Warning: Unknown slot ‘:application’
> cedet/srecode/insert.el:473:35:Warning: Unknown slot ‘:object-name’
> cedet/srecode/insert.el:479:27:Warning: Unknown slot ‘:secondname’
> cedet/srecode/insert.el:552:48:Warning: Unknown slot ‘:object-name’
> cedet/srecode/insert.el:589:40:Warning: Unknown slot ‘:defaultfcn’
> cedet/srecode/insert.el:626:26:Warning: Unknown slot ‘:read-fcn’
> cedet/srecode/insert.el:808:6:Warning: ‘eieio-object-name-string’ is an
> cedet/srecode/insert.el:864:53:Warning: Unknown slot ‘:object-name’
> cedet/srecode/insert.el:866:25:Warning: ‘eieio-object-name-string’ is an
> cedet/srecode/insert.el:925:43:Warning: Unknown slot ‘:secondname’
> cedet/srecode/insert.el:978:8:Warning: Unknown slot ‘:object-name’
> cedet/srecode/insert.el:1059:22:Warning: Unknown slot ‘:object-name’
> cedet/srecode/map.el:273:18:Warning: Obsolete name arg "SRecode Map" to
> cedet/srecode/map.el:302:10:Warning: Obsolete name arg "SRecode Map" to
> cedet/srecode/mode.el:199:40:Warning: Unknown slot ‘:tables’
> cedet/srecode/mode.el:242:31:Warning: ‘eieio-object-name-string’ is an
> cedet/srecode/mode.el:344:52:Warning: Unknown slot ‘:table’
> cedet/srecode/mode.el:325:10:Warning: Unknown slot ‘:file’
> cedet/srecode/mode.el:325:30:Warning: Unknown slot ‘:object-name’
> cedet/srecode/mode.el:339:26:Warning: Unknown slot ‘:context’
> cedet/srecode/semantic.el:66:8:Warning: Unknown slot ‘:prime’
> cedet/srecode/semantic.el:106:44:Warning: Unknown slot ‘:prime’
> cedet/srecode/srt-mode.el:247:45:Warning: Unknown slot ‘key’
> cedet/srecode/srt-mode.el:500:33:Warning: Obsolete name arg "TMP" to
> cedet/srecode/srt-mode.el:505:34:Warning: Unknown slot ‘:object-name’
> cedet/srecode/srt-mode.el:508:61:Warning: Unknown slot ‘:secondname’
> cedet/srecode/srt-mode.el:508:33:Warning: Unknown slot ‘key’
> cedet/srecode/srt-mode.el:631:26:Warning: Unknown slot ‘:prefix’
> cedet/srecode/srt-mode.el:649:29:Warning: Unknown slot ‘:argument’
> cedet/srecode/table.el:203:49:Warning: Unknown slot ‘:priority’
> cedet/srecode/table.el:204:51:Warning: Unknown slot ‘:priority’
> cedet/srecode/table.el:242:4:Warning: Unknown slot ‘:major-mode’
> cedet/srecode/table.el:243:4:Warning: Unknown slot ‘:tables’
> cedet/srecode/table.el:255:4:Warning: ‘eieio-object-name-string’ is an
> cedet/srecode/table.el:257:4:Warning: Unknown slot ‘:priority’
> cedet/srecode/table.el:257:20:Warning: Unknown slot ‘:application’
> cedet/srecode/table.el:260:22:Warning: Unknown slot ‘:framework’
> cedet/srecode/table.el:263:22:Warning: Unknown slot ‘:project’
> cedet/srecode/texi.el:156:8:Warning: Unknown slot ‘:prime’
> emacs-lisp/chart.el:130:44:Warning: Unknown slot ‘title’
> emacs-lisp/eieio-custom.el:202:41:Warning: ‘eieio-object-name-string’ is an
> emacs-lisp/eieio-custom.el:469:14:Warning: Unknown slot ‘name’
> emacs-lisp/eieio-datadebug.el:64:16:Warning: ‘eieio-object-name-string’ is an
> emacs-lisp/eieio-datadebug.el:90:6:Warning: ‘eieio-object-name-string’ is an
> emacs-lisp/eieio-opt.el:154:65:Warning: ‘eieio-help-class’ is an obsolete
> emacs-lisp/eieio-speedbar.el:199:43:Warning: ‘eieio-object-name-string’ is an
> emacs-lisp/eieio-speedbar.el:207:49:Warning: ‘eieio-object-name-string’ is an
> emacs-lisp/ewoc.el:501:1:Warning: Unused lexical variable ‘dll’
> emacs-lisp/package.el:3412:1:Warning: the function
> emacs-lisp/pcase.el:501:8:Warning: function pcase--mutually-exclusive-p used
> emulation/viper-ex.el:551:13:Warning: looking-back called with 1 argument, but
> emulation/viper-ex.el:553:13:Warning: looking-back called with 1 argument, but
> emulation/viper-ex.el:552:26:Warning: looking-back called with 1 argument, but
> emulation/viper-ex.el:2014:6:Warning: ‘find-tag’ is an obsolete function (as
> emulation/viper-ex.el:2018:36:Warning: ‘find-tag-other-window’ is an obsolete
> erc/erc.el:5401:27:Warning: global/dynamic var ‘str’ lacks a prefix
> eshell/em-alias.el:217:1:Warning: Unused lexical argument ‘args’
> eshell/em-cmpl.el:271:8:Warning: ‘pcomplete-suffix-list’ is an obsolete
> eshell/em-dirs.el:186:1:Warning: Unused lexical argument ‘args’
> eshell/em-dirs.el:303:1:Warning: Unused lexical argument ‘args’
> eshell/em-rebind.el:225:49:Warning: ‘delete-backward-char’ is for interactive
> eshell/em-script.el:60:1:Warning: Unused lexical argument ‘args’
> eshell/em-tramp.el:97:1:Warning: Unused lexical variable ‘args’
> eshell/em-unix.el:933:1:Warning: Unused lexical variable ‘args’
> eshell/em-unix.el:963:1:Warning: Unused lexical argument ‘args’
> eshell/esh-io.el:325:1:Warning: Unused lexical variable ‘gui-select-enable-clipboard’
> eshell/esh-mode.el:491:15:Warning: ‘find-tag’ is an obsolete function (as of
> eshell/esh-proc.el:161:1:Warning: Unused lexical argument ‘args’
> eshell/esh-var.el:346:1:Warning: Unused lexical variable ‘args’
> gnus/gnus-cite.el:1239:17:Warning: ‘font-lock-fontify-buffer’ is for
> gnus/gnus-group.el:1637:4:Warning: global/dynamic var ‘ticked’ lacks a prefix
> gnus/gnus-group.el:1637:23:Warning: global/dynamic var ‘score’ lacks a prefix
> gnus/gnus-group.el:1637:39:Warning: global/dynamic var ‘level’ lacks a prefix
> gnus/gnus-group.el:1637:54:Warning: global/dynamic var ‘mailp’ lacks a prefix
> gnus/gnus-group.el:1638:4:Warning: global/dynamic var ‘total’ lacks a prefix
> gnus/gnus-group.el:1638:19:Warning: global/dynamic var ‘unread’ lacks a prefix
> gnus/message.el:1913:1:Warning: ‘make-variable-buffer-local’ not called at
> gnus/message.el:6045:1:Warning: global/dynamic var ‘Date’ lacks a prefix
> gnus/message.el:6047:1:Warning: global/dynamic var ‘Organization’ lacks a
> gnus/message.el:6048:1:Warning: global/dynamic var ‘From’ lacks a prefix
> gnus/message.el:6049:1:Warning: global/dynamic var ‘Path’ lacks a prefix
> gnus/message.el:6050:1:Warning: global/dynamic var ‘Subject’ lacks a prefix
> gnus/message.el:6051:1:Warning: global/dynamic var ‘Newsgroups’ lacks a prefix
> gnus/message.el:6053:1:Warning: global/dynamic var ‘References’ lacks a prefix
> gnus/message.el:6054:1:Warning: global/dynamic var ‘To’ lacks a prefix
> gnus/message.el:6055:1:Warning: global/dynamic var ‘Distribution’ lacks a
> gnus/message.el:6056:1:Warning: global/dynamic var ‘Lines’ lacks a prefix
> gnus/message.el:6058:1:Warning: global/dynamic var ‘Expires’ lacks a prefix
> gnus/mm-decode.el:1933:1:Warning: the function ‘gnus-format-message’ is not
> gnus/mm-uu.el:339:1:Warning: global/dynamic var ‘entry’ lacks a prefix
> gnus/mm-view.el:528:18:Warning: ‘font-lock-fontify-buffer’ is for interactive
> gnus/mml-smime.el:601:1:Warning: the function ‘gnus-format-message’ is not
> gnus/mml1991.el:194:8:Warning: ‘mm-with-unibyte-current-buffer’ is an obsolete
> gnus/mml1991.el:363:33:Warning: ‘mm-with-unibyte-current-buffer’ is an
> gnus/mml2015.el:476:14:Warning: ‘mm-with-unibyte-current-buffer’ is an
> gnus/nnmail.el:1962:31:Warning: ‘rmail-dont-reply-to-names’ is an obsolete
> gnus/nnmaildir.el:1781:42:Warning: global/dynamic var ‘flist’ lacks a prefix
> gnus/nnmaildir.el:1782:4:Warning: global/dynamic var ‘ls’ lacks a prefix
> gnus/nnmaildir.el:1782:19:Warning: global/dynamic var ‘dirs’ lacks a prefix
> gnus/nnmaildir.el:1782:31:Warning: global/dynamic var ‘dir’ lacks a prefix
> gnus/nnmaildir.el:1782:45:Warning: global/dynamic var ‘files’ lacks a prefix
> gnus/nnmaildir.el:1783:4:Warning: global/dynamic var ‘file’ lacks a prefix
> gnus/nnmaildir.el:1783:19:Warning: global/dynamic var ‘x’ lacks a prefix
> gnus/nnrss.el:590:22:Warning: ‘mm-with-unibyte-current-buffer’ is an obsolete
> gnus/nnspool.el:348:37:Warning: ‘mm-with-unibyte-current-buffer’ is an
> gnus/nnweb.el:107:22:Warning: ‘mm-with-unibyte-current-buffer’ is an obsolete
> gnus/nnweb.el:157:39:Warning: ‘mm-with-unibyte-current-buffer’ is an obsolete
> gnus/nnweb.el:166:45:Warning: ‘mm-with-unibyte-current-buffer’ is an obsolete
> gnus/nnweb.el:390:42:Warning: ‘mm-with-unibyte-current-buffer’ is an obsolete
> gnus/plstore.el:419:14:Warning: ‘epg-context-set-armor’ is an obsolete
> gnus/registry.el:186:18:Warning: Unknown slot ‘:tracker’
> gnus/utf7.el:123:43:Warning: ‘mm-with-unibyte-current-buffer’ is an obsolete
> mail/mailalias.el:55:1:Warning: global/dynamic var ‘pattern’ lacks a prefix
> mail/mailheader.el:102:1:Warning: global/dynamic var ‘headers’ lacks a prefix
> mail/rmail.el:4583:1:Warning: Unused lexical variable ‘rmail-mime-render-html-function’
> mail/rmail.el:4950:1:Warning: the function ‘rmail-mime-entity-truncated’ is
> mail/supercite.el:709:1:Warning: global/dynamic var ‘curline’ lacks a prefix
> obsolete/cc-compat.el:166:1:Warning: the following functions might not be
> obsolete/complete.el:836:33:Warning: ‘completion-base-size’ is an obsolete
> obsolete/otodo-mode.el:928:1:Warning: global/dynamic var ‘date’ lacks a prefix
> obsolete/otodo-mode.el:929:1:Warning: global/dynamic var ‘entry’ lacks a
> obsolete/vc-mcvs.el:443:29:Warning: reference to free variable
> obsolete/vc-mcvs.el:594:1:Warning: the function ‘vc-stay-local-p’ is not known
> obsolete/vi.el:1389:22:Warning: ‘mark-whole-buffer’ is for interactive use
> obsolete/vip.el:1860:17:Warning: ‘delete-backward-char’ is for interactive use
> obsolete/vip.el:2980:6:Warning: ‘find-tag’ is an obsolete function (as of
> obsolete/vip.el:2983:32:Warning: ‘find-tag-other-window’ is an obsolete
> org/ob-lilypond.el:250:34:Warning: ‘show-all’ is an obsolete function (as of
> org/org-agenda.el:8307:32:Warning: ‘show-entry’ is an obsolete function (as of
> org/org-agenda.el:8527:34:Warning: ‘show-entry’ is an obsolete function (as of
> org/org-agenda.el:8565:16:Warning: ‘show-subtree’ is an obsolete function (as
> org/org-agenda.el:8596:10:Warning: ‘hide-subtree’ is an obsolete function (as
> org/org-agenda.el:8604:10:Warning: ‘show-entry’ is an obsolete function (as of
> org/org-agenda.el:8605:8:Warning: ‘show-children’ is an obsolete function (as
> org/org-agenda.el:8611:10:Warning: ‘show-subtree’ is an obsolete function (as
> org/org-agenda.el:8619:15:Warning: ‘show-subtree’ is an obsolete function (as
> org/org-agenda.el:8628:10:Warning: ‘show-subtree’ is an obsolete function (as
> org/org-archive.el:347:36:Warning: ‘show-all’ is an obsolete function (as of
> org/org-archive.el:314:37:Warning: ‘show-subtree’ is an obsolete function (as
> org/org-archive.el:443:27:Warning: ‘hide-subtree’ is an obsolete function (as
> org/org-archive.el:517:14:Warning: ‘hide-subtree’ is an obsolete function (as
> org/org-capture.el:1001:54:Warning: ‘show-all’ is an obsolete function (as of
> org/org-clock.el:1934:6:Warning: org-font-lock-ensure called with 0 arguments,
> org/org-colview.el:563:11:Warning: ‘hide-entry’ is an obsolete function (as of
> org/org-compat.el:484:19:Warning: ‘font-lock-fontify-buffer’ is for
> org/org-crypt.el:191:19:Warning: ‘hide-subtree’ is an obsolete function (as of
> org/org-ctags.el:361:6:Warning: ‘find-tag’ is an obsolete function (as of
> org/org-ctags.el:530:19:Warning: ‘find-tag’ is an obsolete function (as of
> org/org-feed.el:405:12:Warning: ‘hide-subtree’ is an obsolete function (as of
> org/org-feed.el:409:12:Warning: ‘show-children’ is an obsolete function (as of
> org/org-mouse.el:218:18:Warning: ‘redisplay-dont-pause’ is an obsolete
> org/org-mouse.el:590:15:Warning: org-looking-back called with 1 argument, but
> org/org-pcomplete.el:96:19:Warning: org-looking-back called with 1 argument,
> org/org-pcomplete.el:96:47:Warning: org-looking-back called with 1 argument,
> org/org-src.el:919:14:Warning: org-font-lock-ensure called with 0 arguments,
> org/org-src.el:957:1:Warning: the function ‘org-some’ is not known to be
> org/org.el:6378:8:Warning: org-font-lock-ensure called with 0 arguments, but
> org/org.el:6633:15:Warning: ‘show-all’ is an obsolete function (as of 25.1);
> org/org.el:6724:38:Warning: ‘show-all’ is an obsolete function (as of 25.1);
> org/org.el:6797:10:Warning: ‘show-children’ is an obsolete function (as of
> org/org.el:6855:17:Warning: ‘show-all’ is an obsolete function (as of 25.1);
> org/org.el:6856:8:Warning: ‘hide-sublevels’ is an obsolete function (as of
> org/org.el:6873:32:Warning: ‘show-all’ is an obsolete function (as of 25.1);
> org/org.el:6893:12:Warning: ‘hide-subtree’ is an obsolete function (as of
> org/org.el:6899:20:Warning: ‘hide-subtree’ is an obsolete function (as of
> org/org.el:6900:14:Warning: ‘show-children’ is an obsolete function (as of
> org/org.el:6906:18:Warning: ‘show-subtree’ is an obsolete function (as of
> org/org.el:6932:34:Warning: ‘hide-sublevels’ is an obsolete function (as of
> org/org.el:6949:23:Warning: ‘show-children’ is an obsolete function (as of
> org/org.el:6950:32:Warning: ‘show-branches’ is an obsolete function (as of
> org/org.el:7001:36:Warning: ‘hide-entry’ is an obsolete function (as of 25.1);
> org/org.el:7102:28:Warning: ‘hide-sublevels’ is an obsolete function (as of
> org/org.el:7162:9:Warning: ‘show-all’ is an obsolete function (as of 25.1);
> org/org.el:7527:10:Warning: ‘show-all’ is an obsolete function (as of 25.1);
> org/org.el:8227:16:Warning: ‘hide-subtree’ is an obsolete function (as of
> org/org.el:8231:8:Warning: ‘show-children’ is an obsolete function (as of
> org/org.el:8394:15:Warning: ‘hide-subtree’ is an obsolete function (as of
> org/org.el:8706:18:Warning: ‘show-subtree’ is an obsolete function (as of
> org/org.el:8827:20:Warning: ‘show-all’ is an obsolete function (as of 25.1);
> org/org.el:12841:19:Warning: assignment to free variable ‘e’
> org/org.el:12841:19:Warning: reference to free variable ‘e’
> org/org.el:14894:37:Warning: assignment to free variable ‘e’
> org/org.el:14894:37:Warning: reference to free variable ‘e’
> org/org.el:15718:12:Warning: ‘hide-entry’ is an obsolete function (as of
> org/org.el:16251:24:Warning: looking-back called with 1 argument, but requires
> org/org.el:17513:21:Warning: org-looking-back called with 1 argument, but
> org/org.el:19520:40:Warning: ‘show-subtree’ is an obsolete function (as of
> org/org.el:20484:12:Warning: ‘hide-subtree’ is an obsolete function (as of
> org/org.el:20524:16:Warning: org-looking-back called with 1 argument, but
> org/org.el:23060:22:Warning: ‘hide-subtree’ is an obsolete function (as of
> org/org.el:24031:1:Warning: the function ‘format-spec’ might not be defined at
> org/ox-html.el:1858:25:Warning: org-font-lock-ensure called with 0 arguments,
> org/ox-odt.el:3143:21:Warning: org-font-lock-ensure called with 0 arguments,
> org/ox-org.el:257:10:Warning: org-font-lock-ensure called with 0 arguments,
> org/ox-org.el:257:10:Warning: ‘show-all’ is an obsolete function (as of 25.1);
> play/dunnet.el:1205:22:Warning: ‘end-of-buffer’ is for interactive use only;
> progmodes/cc-defs.el:2505:1:Warning: the following functions might not be
> progmodes/cc-vars.el:1780:1:Warning: the following functions might not be
> progmodes/cc-langs.el:3362:1:Warning: the following functions might not be
> progmodes/cc-engine.el:11298:1:Warning: the following functions might not be
> progmodes/cc-align.el:1353:1:Warning: the following functions might not be
> progmodes/cc-awk.el:1155:1:Warning: the following functions might not be
> progmodes/cc-cmds.el:4777:1:Warning: the following functions might not be
> progmodes/cc-fonts.el:2712:1:Warning: the following functions might not be
> progmodes/cc-guess.el:581:1:Warning: the following functions might not be
> progmodes/cc-menus.el:529:1:Warning: the following functions might not be
> progmodes/cc-styles.el:671:1:Warning: the following functions might not be
> progmodes/cc-mode.el:105:21:Warning: ‘font-lock-syntactic-keywords’ is an
> progmodes/cc-mode.el:154:53:Warning: (lambda nil ...) quoted with ' rather
> progmodes/cc-mode.el:154:53:Warning: (lambda nil ...) quoted with ' rather
> progmodes/cc-mode.el:155:53:Warning: (lambda nil ...) quoted with ' rather
> progmodes/cc-mode.el:156:53:Warning: (lambda nil ...) quoted with ' rather
> progmodes/cc-mode.el:1927:1:Warning: the following functions might not be
> progmodes/etags.el:1020:10:Warning: ‘find-tag-other-window’ is an obsolete
> progmodes/etags.el:1872:18:Warning: ‘tags-loop-continue’ is an obsolete
> progmodes/etags.el:1876:11:Warning: ‘tags-loop-continue’ is an obsolete
> progmodes/etags.el:1901:9:Warning: ‘tags-loop-continue’ is an obsolete
> progmodes/gdb-mi.el:675:1:Warning: Unused lexical argument ‘arg’
> progmodes/gud.el:735:1:Warning: Unused lexical argument ‘arg’
> progmodes/hideshow.el:581:22:Warning: looking-back called with 1 argument, but
> progmodes/idlw-help.el:1185:16:Warning: ‘font-lock-fontify-buffer’ is for
> progmodes/octave.el:1871:1:Warning: the function ‘compilation-forget-errors’
> progmodes/sql.el:2781:31:Warning: looking-back called with 1 argument, but
> textmodes/sgml-mode.el:436:1:Warning: global/dynamic var ‘v2’ lacks a prefix
> vc/add-log.el:476:4:Warning: value returned from (car change-log-find-head) is
>
>
>
Hi,
sorry being late here.
As any change might create a new bug, IMO it's better to tackle this not
shortly before, rather after a release.
It's about an easier development, not function itself.
Glad to see the ship taking course, thanks all,
Andreas
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-26 8:33 ` Andreas Röhler
@ 2015-11-26 15:51 ` Eli Zaretskii
2015-11-28 18:44 ` John Wiegley
0 siblings, 1 reply; 52+ messages in thread
From: Eli Zaretskii @ 2015-11-26 15:51 UTC (permalink / raw
To: Andreas Röhler; +Cc: jwiegley, 21953
> From: Andreas Röhler <andreas.roehler@easy-emacs.de>
> Date: Thu, 26 Nov 2015 09:33:05 +0100
> Cc: John Wiegley <jwiegley@gmail.com>
>
> As any change might create a new bug, IMO it's better to tackle this not
> shortly before, rather after a release.
Experience shows that things deferred toll "after the release" tend to
remain unhandled.
We still have a lot of time before the release, and didn't get
anywhere close to a stable codebase, so there's nothing wrong in
trying to fix some of the warnings now.
TIA
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-25 20:58 ` Andy Moreton
@ 2015-11-26 17:55 ` Eli Zaretskii
0 siblings, 0 replies; 52+ messages in thread
From: Eli Zaretskii @ 2015-11-26 17:55 UTC (permalink / raw
To: Andy Moreton; +Cc: 21953
> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Wed, 25 Nov 2015 20:58:10 +0000
>
> There are three in the mingw64 build (on emacs-25 or master branch):
>
> ../../src/w32.c: In function 'sys_socket':
> ../../src/w32.c:7435:14: warning: overflow in implicit constant conversion [-Woverflow]
> return INVALID_SOCKET;
> ^
> ../../src/w32.c: In function 'maybe_load_unicows_dll':
> ../../src/w32.c:9273:25: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
> pMultiByteToWideChar = GetProcAddress (ret, "MultiByteToWideChar");
> ^
> ../../src/w32.c:9274:25: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
> pWideCharToMultiByte = GetProcAddress (ret, "WideCharToMultiByte");
> ^
Thanks, fixed on emacs-25.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-26 15:51 ` Eli Zaretskii
@ 2015-11-28 18:44 ` John Wiegley
2015-11-29 9:13 ` Andreas Röhler
0 siblings, 1 reply; 52+ messages in thread
From: John Wiegley @ 2015-11-28 18:44 UTC (permalink / raw
To: Eli Zaretskii; +Cc: 21953
>>>>> Eli Zaretskii <eliz@gnu.org> writes:
> Experience shows that things deferred toll "after the release" tend to
> remain unhandled.
>
> We still have a lot of time before the release, and didn't get anywhere
> close to a stable codebase, so there's nothing wrong in trying to fix some
> of the warnings now.
Completely agree with Eli. I've seen "after the release" become "fifteen years
later, still not done" before.
John
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-28 18:44 ` John Wiegley
@ 2015-11-29 9:13 ` Andreas Röhler
2015-11-30 0:38 ` Richard Stallman
0 siblings, 1 reply; 52+ messages in thread
From: Andreas Röhler @ 2015-11-29 9:13 UTC (permalink / raw
To: John Wiegley, Eli Zaretskii; +Cc: 21953
Am 28.11.2015 um 19:44 schrieb John Wiegley:
>>>>>> Eli Zaretskii <eliz@gnu.org> writes:
>> Experience shows that things deferred toll "after the release" tend to
>> remain unhandled.
>>
>> We still have a lot of time before the release, and didn't get anywhere
>> close to a stable codebase, so there's nothing wrong in trying to fix some
>> of the warnings now.
> Completely agree with Eli. I've seen "after the release" become "fifteen years
> later, still not done" before.
>
> John
Having a usable ToDo-list, which would consider urgency and hierarchy of
some tasks, being re-adjusted from time to time, might change the game.
Not sure if this is possible in a free world :)
Cheers,
Andreas
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#21953: Eliminate warnings in the emacs-25 release branch
2015-11-29 9:13 ` Andreas Röhler
@ 2015-11-30 0:38 ` Richard Stallman
0 siblings, 0 replies; 52+ messages in thread
From: Richard Stallman @ 2015-11-30 0:38 UTC (permalink / raw
To: Andreas Röhler; +Cc: jwiegley, 21953
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> Having a usable ToDo-list, which would consider urgency and hierarchy of
> some tasks, being re-adjusted from time to time, might change the game.
That might be a start, but won't change things by itself. We alsp
need developers who work on items _because_ they are in the todo list.
--
Dr Richard Stallman
President, Free Software Foundation (gnu.org, fsf.org)
Internet Hall-of-Famer (internethalloffame.org)
Skype: No way! See stallman.org/skype.html.
^ permalink raw reply [flat|nested] 52+ messages in thread
end of thread, other threads:[~2015-11-30 0:38 UTC | newest]
Thread overview: 52+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-18 17:44 bug#21953: Eliminate warnings in the emacs-25 release branch John Wiegley
2015-11-18 17:58 ` Eli Zaretskii
2015-11-18 18:04 ` Dmitry Gutov
2015-11-18 18:17 ` Glenn Morris
2015-11-18 18:44 ` Eli Zaretskii
2015-11-23 19:10 ` Glenn Morris
2015-11-23 22:04 ` John Wiegley
2015-11-23 22:47 ` Drew Adams
2015-11-24 3:30 ` Eli Zaretskii
2015-11-24 3:40 ` John Wiegley
2015-11-24 17:40 ` Glenn Morris
2015-11-25 1:03 ` John Wiegley
2015-11-18 19:09 ` Artur Malabarba
2015-11-18 20:36 ` Eli Zaretskii
2015-11-18 20:57 ` Artur Malabarba
2015-11-19 2:06 ` John Wiegley
2015-11-19 17:20 ` Stephen Leake
2015-11-19 17:29 ` Dmitry Gutov
2015-11-19 17:37 ` John Wiegley
2015-11-19 17:46 ` Dmitry Gutov
2015-11-19 17:54 ` Eli Zaretskii
2015-11-19 18:18 ` John Wiegley
2015-11-19 18:34 ` Juanma Barranquero
2015-11-19 19:05 ` John Wiegley
2015-11-19 20:29 ` Eli Zaretskii
2015-11-19 20:25 ` Eli Zaretskii
2015-11-19 20:31 ` Juanma Barranquero
2015-11-19 20:51 ` Eli Zaretskii
2015-11-20 0:26 ` Juanma Barranquero
2015-11-25 20:58 ` Andy Moreton
2015-11-26 17:55 ` Eli Zaretskii
2015-11-19 20:01 ` David Engster
2015-11-19 20:26 ` John Wiegley
2015-11-19 20:32 ` Eli Zaretskii
2015-11-20 10:41 ` Stephen Leake
2015-11-19 17:45 ` Eli Zaretskii
2015-11-18 18:39 ` Ken Brown
2015-11-18 18:52 ` Eli Zaretskii
2015-11-18 19:19 ` Ken Brown
2015-11-18 20:38 ` Eli Zaretskii
2015-11-18 20:57 ` Stephen Berman
[not found] ` <mailman.233.1447954214.31583.bug-gnu-emacs@gnu.org>
2015-11-24 19:55 ` Alan Mackenzie
2015-11-25 0:28 ` Dmitry Gutov
2015-11-25 9:31 ` Alan Mackenzie
2015-11-25 14:36 ` Dmitry Gutov
2015-11-25 15:50 ` Alan Mackenzie
2015-11-25 18:54 ` Glenn Morris
2015-11-26 8:33 ` Andreas Röhler
2015-11-26 15:51 ` Eli Zaretskii
2015-11-28 18:44 ` John Wiegley
2015-11-29 9:13 ` Andreas Röhler
2015-11-30 0:38 ` Richard Stallman
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.