Re: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort

Re: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort

[Ken Brown]

On 11/16/2015 4:10 PM, Paul Eggert wrote:
> branch: emacs-25
> commit 8ff888a07d0500f1274723086469191aade0a33e
> Author: Paul Eggert <eggert@cs.ucla.edu>
> Commit: Paul Eggert <eggert@cs.ucla.edu>
>
>      Improve fix for regex reentrancy abort
>
>      Suggested by Stefan Monnier (Bug#21688).
>      * src/syntax.c (update_syntax_table_forward):
>      Remove recently-added PROPERTIZE arg, and assume it is true.
>      All callers changed.
>      * src/syntax.h (UPDATE_SYNTAX_TABLE_FORWARD_FAST):
>      Invoke update_syntax_table directly.

The message-mode-propertize test fails after this commit.

$ make -C test/automated/ message-mode-tests

Test message-mode-propertize backtrace:
   #[0 "\303\304!r\211q\210\305\306\307\310\311!\312\"\313$\216\314\21
   ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
   ert-run-test([cl-struct-ert-test message-mode-propertize nil #[0 "\3
   ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test m
   ert-run-tests(t #[385 "\306\307\"\203G\211\211G\310U\203\211@\20
   ert-run-tests-batch(nil)
   ert-run-tests-batch-and-exit()
   command-line-1(("-L" ":../../../emacs-25/test/automated" "-l" "ert"
   command-line()
   normal-top-level()
Test message-mode-propertize condition:
     (ert-test-failed
      ((should
        (string= "here's an opener "
                 (buffer-substring-no-properties ... ...)))
       :form
       (string= "here's an opener " "here's a sad face :-")
       :value nil))
    FAILED  1/1  message-mode-propertize

Ken

Re: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort

[John Wiegley]

>>>>> Ken Brown <kbrown@cornell.edu> writes:

>> branch: emacs-25
>> commit 8ff888a07d0500f1274723086469191aade0a33e
> The message-mode-propertize test fails after this commit.

Let's make sure all tests are run prior to any commits on the emacs-25 branch.
This may be a case where it doesn't break on the committer's machine; but I'll
let Paul speak to that.

John

Re: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort

[Paul Eggert]

John Wiegley wrote:
> This may be a case where it doesn't break on the committer's machine; but I'll
> let Paul speak to that.

Here, the bug fix (fixing a core dump when searching) was more important than 
the test case (whether a smiley face is properly parsed :-). I haven't had time 
yet to investigate the test case, but I'll try to get around to it eventually. 
The smiley-face problem is lower priority than some of the other problems I have 
right now (e.g., Emacs doesn't build for me with the recent dynamic module 
additions).

bug#21688: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort

[Paul Eggert]

John Wiegley wrote:
>>>>>> Ken Brown<kbrown@cornell.edu>  writes:
>>> >>branch: emacs-25
>>> >>commit 8ff888a07d0500f1274723086469191aade0a33e
>> >The message-mode-propertize test fails after this commit.
> Let's make sure all tests are run prior to any commits on the emacs-25 branch.

I briefly looked into getting that test working, but couldn't figure it out 
quickly, so I have reverted the fix for the regex reentrancy abort, in emacs-25 
commit 8e84823f3f06714d0668060d62456cf7e3100e6c.  This means Bug#21688 is no 
longer fixed, i.e., Emacs can dump core when aligning Perl code.  I'll reopen 
Bug#21688.

Perhaps Stefan or someone else will be able to knock a few cycles free to fix 
this. I'm afraid I've been spending most of my time elsewhere in Emacs recently, 
what with the new module code and all.

bug#21688: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort

[Stefan Monnier]

> Perhaps Stefan or someone else will be able to knock a few cycles free to
> fix this. I'm afraid I've been spending most of my time elsewhere in Emacs
> recently, what with the new module code and all.

My crystal ball tells me that maybe it's just the following hunk which
is to blame:

   diff --git a/src/syntax.c b/src/syntax.c
   index 5b0ec6d..f939a76 100644
   --- a/src/syntax.c
   +++ b/src/syntax.c
   @@ -514,7 +514,6 @@ update_syntax_table_forward (ptrdiff_t charpos, bool init,
        {
          eassert (NILP (object));
          eassert (charpos >= gl_state.e_property);
   -      parse_sexp_propertize (charpos);
        }
      else
        {

I think this hunk is just a mistake that was introduced during the
"back&forth" that took place when you added and then removed the "bool
propertize" argument.


        Stefan