From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#21955: 25.0.50; vc-next-action fails from *vc-change-log* buffer Date: Thu, 19 Nov 2015 03:40:51 +0200 Message-ID: <564D28A3.3030806@yandex.ru> References: <877flfi1pn.fsf@turtle.gmx.de> <564CC911.7090702@yandex.ru> <87y4dvgkla.fsf@turtle.gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1447897286 24308 80.91.229.3 (19 Nov 2015 01:41:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Nov 2015 01:41:26 +0000 (UTC) Cc: 21955@debbugs.gnu.org To: Sven Joachim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 19 02:41:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZzEDo-0007QA-1d for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Nov 2015 02:41:12 +0100 Original-Received: from localhost ([::1]:39084 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzEDn-0004KA-BL for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Nov 2015 20:41:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzEDj-0004K4-L4 for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2015 20:41:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzEDe-00087A-Kr for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2015 20:41:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzEDe-00086w-Gg for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2015 20:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZzEDe-0007RP-62 for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2015 20:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Nov 2015 01:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21955 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21955-submit@debbugs.gnu.org id=B21955.144789725828582 (code B ref 21955); Thu, 19 Nov 2015 01:41:02 +0000 Original-Received: (at 21955) by debbugs.gnu.org; 19 Nov 2015 01:40:58 +0000 Original-Received: from localhost ([127.0.0.1]:43912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZzEDZ-0007Qw-Dx for submit@debbugs.gnu.org; Wed, 18 Nov 2015 20:40:57 -0500 Original-Received: from mail-wm0-f46.google.com ([74.125.82.46]:38323) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZzEDX-0007Ql-DA for 21955@debbugs.gnu.org; Wed, 18 Nov 2015 20:40:55 -0500 Original-Received: by wmec201 with SMTP id c201so97854223wme.1 for <21955@debbugs.gnu.org>; Wed, 18 Nov 2015 17:40:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=eDk3WiFIew4uuhyeAm5g+IDyG1YqzQF1e4fEQLjELwI=; b=NcJiK17kgBX49Vssgazok1zNhelk3CQLAFNRf7JcGh3JtG9mLVVvMfAHqdSaT6ijqS tgyHhE/LJuUtErXKdqtlcJhS7lQvc8OqMzrBbbzNWp3yhhOQCt5PvtdN4/00gdwmj0Pa 7gwLadv8IgMIo3VB3LIKrP4rWitJ5QB24jm3EV4XVzMQkfgmZfEsV/7kjrkaexM/kNr9 zdmttBjhtSAjDUT0eiN43552bV2ZO5qKiBF/6PPqQDj/n9lTg9zgUAV0MG5TmFpUM6oF dioMwiYb6skytODRqcSSNbRyu0urD8aAd2HEPlBqUmrDllg1kQiDbNV6vurUmHcoqwcs dMKw== X-Received: by 10.194.112.131 with SMTP id iq3mr5130915wjb.35.1447897254577; Wed, 18 Nov 2015 17:40:54 -0800 (PST) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id h4sm5367057wjx.41.2015.11.18.17.40.52 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 Nov 2015 17:40:53 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Thunderbird/42.0 In-Reply-To: <87y4dvgkla.fsf@turtle.gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108895 Archived-At: On 11/18/2015 09:42 PM, Sven Joachim wrote: > It used to work in Emacs 24, and I have come to rely on that behavior. > Apparently the fix for bug #19084 changed it, vc-deduce-fileset in the > *vc-change-log* buffer no longer returns the file whose history is > displayed, but rather the directory it is in. All right, I've tweaked the fix to the above bug, so that both behaviors work. Pushed to emacs-25. Please check and mark it as done, if everything works fine. But I don't think this behavior makes a lot of sense, in general. So e.g. vc-print-root-log displays the log for the whole repository, but vc-next-action will offer you to commit the changes to the file you opened the log buffer from, and not the whole repository. Same for vc-root-diff. > Certainly the behavior of C-x v L is more correct now, but the one of > C-x v l has regressed. Indeed, it also regressed the more sensible scenario: when vc-print-log was called after selecting a few items in vc-dir buffer.