* Re: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort
[not found] ` <E1ZyR2b-0003Gm-BV@vcs.savannah.gnu.org>
@ 2015-11-18 16:31 ` Ken Brown
2015-11-18 16:38 ` John Wiegley
0 siblings, 1 reply; 5+ messages in thread
From: Ken Brown @ 2015-11-18 16:31 UTC (permalink / raw)
To: emacs-devel, Paul Eggert
On 11/16/2015 4:10 PM, Paul Eggert wrote:
> branch: emacs-25
> commit 8ff888a07d0500f1274723086469191aade0a33e
> Author: Paul Eggert <eggert@cs.ucla.edu>
> Commit: Paul Eggert <eggert@cs.ucla.edu>
>
> Improve fix for regex reentrancy abort
>
> Suggested by Stefan Monnier (Bug#21688).
> * src/syntax.c (update_syntax_table_forward):
> Remove recently-added PROPERTIZE arg, and assume it is true.
> All callers changed.
> * src/syntax.h (UPDATE_SYNTAX_TABLE_FORWARD_FAST):
> Invoke update_syntax_table directly.
The message-mode-propertize test fails after this commit.
$ make -C test/automated/ message-mode-tests
Test message-mode-propertize backtrace:
#[0 "\303\304!r\211q\210\305\306\307\310\311!\312\"\313$\216\314\21
ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
ert-run-test([cl-struct-ert-test message-mode-propertize nil #[0 "\3
ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test m
ert-run-tests(t #[385 "\306\307\"\203G\211\211G\310U\203\211@\20
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-L" ":../../../emacs-25/test/automated" "-l" "ert"
command-line()
normal-top-level()
Test message-mode-propertize condition:
(ert-test-failed
((should
(string= "here's an opener "
(buffer-substring-no-properties ... ...)))
:form
(string= "here's an opener " "here's a sad face :-")
:value nil))
FAILED 1/1 message-mode-propertize
Ken
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort
2015-11-18 16:31 ` [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort Ken Brown
@ 2015-11-18 16:38 ` John Wiegley
2015-11-19 7:17 ` Paul Eggert
2015-11-21 22:23 ` bug#21688: " Paul Eggert
0 siblings, 2 replies; 5+ messages in thread
From: John Wiegley @ 2015-11-18 16:38 UTC (permalink / raw)
To: Ken Brown; +Cc: Paul Eggert, emacs-devel
>>>>> Ken Brown <kbrown@cornell.edu> writes:
>> branch: emacs-25
>> commit 8ff888a07d0500f1274723086469191aade0a33e
> The message-mode-propertize test fails after this commit.
Let's make sure all tests are run prior to any commits on the emacs-25 branch.
This may be a case where it doesn't break on the committer's machine; but I'll
let Paul speak to that.
John
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort
2015-11-18 16:38 ` John Wiegley
@ 2015-11-19 7:17 ` Paul Eggert
2015-11-21 22:23 ` bug#21688: " Paul Eggert
1 sibling, 0 replies; 5+ messages in thread
From: Paul Eggert @ 2015-11-19 7:17 UTC (permalink / raw)
To: Ken Brown, emacs-devel
John Wiegley wrote:
> This may be a case where it doesn't break on the committer's machine; but I'll
> let Paul speak to that.
Here, the bug fix (fixing a core dump when searching) was more important than
the test case (whether a smiley face is properly parsed :-). I haven't had time
yet to investigate the test case, but I'll try to get around to it eventually.
The smiley-face problem is lower priority than some of the other problems I have
right now (e.g., Emacs doesn't build for me with the recent dynamic module
additions).
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#21688: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort
2015-11-18 16:38 ` John Wiegley
2015-11-19 7:17 ` Paul Eggert
@ 2015-11-21 22:23 ` Paul Eggert
2015-11-22 2:23 ` Stefan Monnier
1 sibling, 1 reply; 5+ messages in thread
From: Paul Eggert @ 2015-11-21 22:23 UTC (permalink / raw)
To: Ken Brown, 21688; +Cc: John Wiegley, Stefan Monnier
John Wiegley wrote:
>>>>>> Ken Brown<kbrown@cornell.edu> writes:
>>> >>branch: emacs-25
>>> >>commit 8ff888a07d0500f1274723086469191aade0a33e
>> >The message-mode-propertize test fails after this commit.
> Let's make sure all tests are run prior to any commits on the emacs-25 branch.
I briefly looked into getting that test working, but couldn't figure it out
quickly, so I have reverted the fix for the regex reentrancy abort, in emacs-25
commit 8e84823f3f06714d0668060d62456cf7e3100e6c. This means Bug#21688 is no
longer fixed, i.e., Emacs can dump core when aligning Perl code. I'll reopen
Bug#21688.
Perhaps Stefan or someone else will be able to knock a few cycles free to fix
this. I'm afraid I've been spending most of my time elsewhere in Emacs recently,
what with the new module code and all.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#21688: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort
2015-11-21 22:23 ` bug#21688: " Paul Eggert
@ 2015-11-22 2:23 ` Stefan Monnier
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2015-11-22 2:23 UTC (permalink / raw)
To: Paul Eggert; +Cc: John Wiegley, 21688
> Perhaps Stefan or someone else will be able to knock a few cycles free to
> fix this. I'm afraid I've been spending most of my time elsewhere in Emacs
> recently, what with the new module code and all.
My crystal ball tells me that maybe it's just the following hunk which
is to blame:
diff --git a/src/syntax.c b/src/syntax.c
index 5b0ec6d..f939a76 100644
--- a/src/syntax.c
+++ b/src/syntax.c
@@ -514,7 +514,6 @@ update_syntax_table_forward (ptrdiff_t charpos, bool init,
{
eassert (NILP (object));
eassert (charpos >= gl_state.e_property);
- parse_sexp_propertize (charpos);
}
else
{
I think this hunk is just a mistake that was introduced during the
"back&forth" that took place when you added and then removed the "bool
propertize" argument.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-11-22 2:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151116211021.12530.98760@vcs.savannah.gnu.org>
[not found] ` <E1ZyR2b-0003Gm-BV@vcs.savannah.gnu.org>
2015-11-18 16:31 ` [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort Ken Brown
2015-11-18 16:38 ` John Wiegley
2015-11-19 7:17 ` Paul Eggert
2015-11-21 22:23 ` bug#21688: " Paul Eggert
2015-11-22 2:23 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.