From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort Date: Wed, 18 Nov 2015 11:31:58 -0500 Message-ID: <564CA7FE.7030709@cornell.edu> References: <20151116211021.12530.98760@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1447864330 12331 80.91.229.3 (18 Nov 2015 16:32:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Nov 2015 16:32:10 +0000 (UTC) To: emacs-devel@gnu.org, Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 18 17:32:01 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zz5eH-0004JL-Pj for ged-emacs-devel@m.gmane.org; Wed, 18 Nov 2015 17:31:57 +0100 Original-Received: from localhost ([::1]:36811 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz5eH-0008GO-BJ for ged-emacs-devel@m.gmane.org; Wed, 18 Nov 2015 11:31:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz5eD-0008GG-Li for emacs-devel@gnu.org; Wed, 18 Nov 2015 11:31:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz5eA-0004kl-VW for emacs-devel@gnu.org; Wed, 18 Nov 2015 11:31:53 -0500 Original-Received: from limerock04.mail.cornell.edu ([128.84.13.244]:55014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz5eA-0004kB-Rc for emacs-devel@gnu.org; Wed, 18 Nov 2015 11:31:50 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id tAIGVhXc022091; Wed, 18 Nov 2015 11:31:43 -0500 Original-Received: from [192.168.1.6] (cpe-67-249-176-138.twcny.res.rr.com [67.249.176.138]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id tAIGVgRn010654 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 18 Nov 2015 11:31:43 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 128.84.13.244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194715 Archived-At: On 11/16/2015 4:10 PM, Paul Eggert wrote: > branch: emacs-25 > commit 8ff888a07d0500f1274723086469191aade0a33e > Author: Paul Eggert > Commit: Paul Eggert > > Improve fix for regex reentrancy abort > > Suggested by Stefan Monnier (Bug#21688). > * src/syntax.c (update_syntax_table_forward): > Remove recently-added PROPERTIZE arg, and assume it is true. > All callers changed. > * src/syntax.h (UPDATE_SYNTAX_TABLE_FORWARD_FAST): > Invoke update_syntax_table directly. The message-mode-propertize test fails after this commit. $ make -C test/automated/ message-mode-tests Test message-mode-propertize backtrace: #[0 "\303\304!r\211q\210\305\306\307\310\311!\312\"\313$\216\314\21 ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc ert-run-test([cl-struct-ert-test message-mode-propertize nil #[0 "\3 ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test m ert-run-tests(t #[385 "\306\307\"\203G\211\211G\310U\203\211@\20 ert-run-tests-batch(nil) ert-run-tests-batch-and-exit() command-line-1(("-L" ":../../../emacs-25/test/automated" "-l" "ert" command-line() normal-top-level() Test message-mode-propertize condition: (ert-test-failed ((should (string= "here's an opener " (buffer-substring-no-properties ... ...))) :form (string= "here's an opener " "here's a sad face :-") :value nil)) FAILED 1/1 message-mode-propertize Ken