From: Ken Brown <kbrown@cornell.edu>
To: emacs-devel@gnu.org, Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort
Date: Wed, 18 Nov 2015 11:31:58 -0500 [thread overview]
Message-ID: <564CA7FE.7030709@cornell.edu> (raw)
In-Reply-To: <E1ZyR2b-0003Gm-BV@vcs.savannah.gnu.org>
On 11/16/2015 4:10 PM, Paul Eggert wrote:
> branch: emacs-25
> commit 8ff888a07d0500f1274723086469191aade0a33e
> Author: Paul Eggert <eggert@cs.ucla.edu>
> Commit: Paul Eggert <eggert@cs.ucla.edu>
>
> Improve fix for regex reentrancy abort
>
> Suggested by Stefan Monnier (Bug#21688).
> * src/syntax.c (update_syntax_table_forward):
> Remove recently-added PROPERTIZE arg, and assume it is true.
> All callers changed.
> * src/syntax.h (UPDATE_SYNTAX_TABLE_FORWARD_FAST):
> Invoke update_syntax_table directly.
The message-mode-propertize test fails after this commit.
$ make -C test/automated/ message-mode-tests
Test message-mode-propertize backtrace:
#[0 "\303\304!r\211q\210\305\306\307\310\311!\312\"\313$\216\314\21
ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
ert-run-test([cl-struct-ert-test message-mode-propertize nil #[0 "\3
ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test m
ert-run-tests(t #[385 "\306\307\"\203G\211\211G\310U\203\211@\20
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-L" ":../../../emacs-25/test/automated" "-l" "ert"
command-line()
normal-top-level()
Test message-mode-propertize condition:
(ert-test-failed
((should
(string= "here's an opener "
(buffer-substring-no-properties ... ...)))
:form
(string= "here's an opener " "here's a sad face :-")
:value nil))
FAILED 1/1 message-mode-propertize
Ken
next parent reply other threads:[~2015-11-18 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151116211021.12530.98760@vcs.savannah.gnu.org>
[not found] ` <E1ZyR2b-0003Gm-BV@vcs.savannah.gnu.org>
2015-11-18 16:31 ` Ken Brown [this message]
2015-11-18 16:38 ` [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort John Wiegley
2015-11-19 7:17 ` Paul Eggert
2015-11-21 22:23 ` bug#21688: " Paul Eggert
2015-11-22 2:23 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564CA7FE.7030709@cornell.edu \
--to=kbrown@cornell.edu \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.