From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#21245: 25.0.50; [PATCH] SIGSEGV when misusing (backtrace-frame) from custom debugger Date: Mon, 16 Nov 2015 23:16:46 -0800 Organization: UCLA Computer Science Department Message-ID: <564AD45E.3020004@cs.ucla.edu> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070802050301050302020804" X-Trace: ger.gmane.org 1447744735 21835 80.91.229.3 (17 Nov 2015 07:18:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Nov 2015 07:18:55 +0000 (UTC) Cc: 21245-done@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 17 08:18:44 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZyaXI-0004GE-9f for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Nov 2015 08:18:40 +0100 Original-Received: from localhost ([::1]:56069 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyaXH-0003qC-LQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Nov 2015 02:18:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyaWn-0003A3-2u for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2015 02:18:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyaWi-0008LU-1W for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2015 02:18:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyaWh-0008LP-Tt for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2015 02:18:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZyaWh-00035P-FJ for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2015 02:18:03 -0500 In-Reply-To: Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Nov 2015 07:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 21245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 21245@debbugs.gnu.org, eggert@cs.ucla.edu, pipcet@gmail.com Original-Received: via spool by 21245-done@debbugs.gnu.org id=D21245.144774463211800 (code D ref 21245); Tue, 17 Nov 2015 07:18:02 +0000 Original-Received: (at 21245-done) by debbugs.gnu.org; 17 Nov 2015 07:17:12 +0000 Original-Received: from localhost ([127.0.0.1]:40768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyaVr-00034F-Kw for submit@debbugs.gnu.org; Tue, 17 Nov 2015 02:17:12 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54637) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyaVU-00033R-W0 for 21245-done@debbugs.gnu.org; Tue, 17 Nov 2015 02:17:08 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D55F9160192; Mon, 16 Nov 2015 23:16:47 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id w4FZFSCkpFsg; Mon, 16 Nov 2015 23:16:46 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5688F1601AA; Mon, 16 Nov 2015 23:16:46 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LPie-OrUzosb; Mon, 16 Nov 2015 23:16:46 -0800 (PST) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 33997160192; Mon, 16 Nov 2015 23:16:46 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108810 Archived-At: This is a multi-part message in MIME format. --------------070802050301050302020804 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for the bug report in . Good eye, noticing those dangling pointers -- these could cause problems in obscure circumstances even without custom debuggers. I installed the attached patch into the emacs-25 branch, and (if I understand things correctly) it should address the issues raised in the bug report so I'll close the bug report for now; if I'm wrong and this patch doesn't fix the bugs we can always reopen it. --------------070802050301050302020804 Content-Type: text/plain; charset=UTF-8; name="0001-eval_sub-followed-dangling-pointer-when-debugging.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-eval_sub-followed-dangling-pointer-when-debugging.txt" RnJvbSAxZTM4ZWM3NWZhZDE1OTUyMjE3YzRjMWZkZjYyNjJjOTYwODg4NTc3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBNb24sIDE2IE5vdiAyMDE1IDIzOjA4OjU0IC0wODAwClN1YmplY3Q6IFtQQVRD SF0gZXZhbF9zdWIgZm9sbG93ZWQgZGFuZ2xpbmcgcG9pbnRlciB3aGVuIGRlYnVnZ2luZwpN SU1FLVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRG LTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKUHJvYmxlbSByZXBvcnRlZCBi eSBQaXAgQ2V0IChCdWcjMjEyNDUpLgpUaGlzIGJ1ZyBjb3VsZCBvY2N1ciBpbiBldmFsX3N1 YiBpZiB0aGUgQyBjb21waWxlciByZXVzZWQKc3RvcmFnZSBhc3NvY2lhdGVkIHdpdGggdGhl IOKAmGFyZ3ZhbHPigJkgbG9jYWwgYWZ0ZXIg4oCYYXJndmFsc+KAmQp3ZW50IG91dCBvZiBz Y29wZSwgYW5kIGlmIHRoZSBFbGlzcCBkZWJ1Z2dlciBzdG9wcGVkIG9uIEVsaXNwCmZ1bmN0 aW9uIGV4aXQgYW5kIGFjY2Vzc2VkIOKAmGFyZ3ZhbHPigJkuICBJdCBjb3VsZCBhbHNvIG9j Y3VyIGlmCmEgdmFyaWFkaWMgZnVuY3Rpb24gd2FzIGNhbGxlZCB3aXRoIHNvIG1hbnkgYXJn dW1lbnRzIChvdmVyCjIwNDggYXJncyBvbiB4ODYtNjQpIHRoYXQgU0FGRV9BTExPQ0FfTElT UCBjYWxsZWQgbWFsbG9jLCB0aGVuClNBRkVfRlJFRSBmcmVlZCB0aGUgYXJndW1lbnRzLCB0 aGVuIHRoZSBtZW1vcnkgbWFuYWdlciB1c2VkCnRoZSBzdG9yYWdlIGZvciBvdGhlciBwdXJw b3NlcywgdGhlbiB0aGUgZGVidWdnZXIgYWNjZXNzZWQgdGhlCmFyZ3VtZW50cy4KKiBzcmMv ZXZhbC5jIChldmFsX3N1Yik6IERlY2xhcmUg4oCYYXJndmFsc+KAmSBhdCB0b3AgbGV2ZWwg b2YKZnVuY3Rpb24gYm9keS4JU2ltcGxpZnkgbG9jYWwgZGVjbHMuCldoZW4gYWxsb2NhdGlu ZyBhcmdzIHZpYSBTQUZFX0FMTE9DQSwgY2FsbApkZWJ1Z2dlciBiZWZvcmUgaW52b2tpbmcg U0FGRV9GUkVFLCBhcyB0aGUgZGVidWdnZXIgbmVlZHMKYWNjZXNzIHRvIHRoZSBhcmdzLgoo ZXZhbF9zdWIsIGFwcGx5X2xhbWJkYSk6IFJld29yayB0byBhdm9pZCBuZWVkIGZvcgpzZXRf YmFja3RyYWNlX2RlYnVnX29uX2V4aXQgaGFjay4gIFRoaXMgaXMgY2xlYW5lciwKYW5kIHNo b3VsZCB3b3JrIGJldHRlciB3aXRoIGJ1Z2d5IGN1c3RvbSBkZWJ1Z2dlcnMuCi0tLQogc3Jj L2V2YWwuYyB8IDM3ICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KIDEg ZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9zcmMvZXZhbC5jIGIvc3JjL2V2YWwuYwppbmRleCBkNDYwMDQ4Li4zZWUwN2E3 IDEwMDY0NAotLS0gYS9zcmMvZXZhbC5jCisrKyBiL3NyYy9ldmFsLmMKQEAgLTIwMTQsNiAr MjAxNCwxMCBAQCBldmFsX3N1YiAoTGlzcF9PYmplY3QgZm9ybSkKICAgTGlzcF9PYmplY3Qg ZnVuY2FyOwogICBwdHJkaWZmX3QgY291bnQ7CiAKKyAgLyogRGVjbGFyZSBoZXJlLCBhcyB0 aGlzIGFycmF5IG1heSBiZSBhY2Nlc3NlZCBieSBjYWxsX2RlYnVnZ2VyIG5lYXIKKyAgICAg dGhlIGVuZCBvZiB0aGlzIGZ1bmN0aW9uLiAgU2VlIEJ1ZyMyMTI0NS4gICovCisgIExpc3Bf T2JqZWN0IGFyZ3ZhbHNbOF07CisKICAgaWYgKFNZTUJPTFAgKGZvcm0pKQogICAgIHsKICAg ICAgIC8qIExvb2sgdXAgaXRzIGJpbmRpbmcgaW4gdGhlIGxleGljYWwgZW52aXJvbm1lbnQu CkBAIC0yMDY2LDEzICsyMDcwLDggQEAgZXZhbF9zdWIgKExpc3BfT2JqZWN0IGZvcm0pCiAK ICAgaWYgKFNVQlJQIChmdW4pKQogICAgIHsKLSAgICAgIExpc3BfT2JqZWN0IG51bWFyZ3M7 Ci0gICAgICBMaXNwX09iamVjdCBhcmd2YWxzWzhdOwotICAgICAgTGlzcF9PYmplY3QgYXJn c19sZWZ0OwotICAgICAgcmVnaXN0ZXIgaW50IGksIG1heGFyZ3M7Ci0KLSAgICAgIGFyZ3Nf bGVmdCA9IG9yaWdpbmFsX2FyZ3M7Ci0gICAgICBudW1hcmdzID0gRmxlbmd0aCAoYXJnc19s ZWZ0KTsKKyAgICAgIExpc3BfT2JqZWN0IGFyZ3NfbGVmdCA9IG9yaWdpbmFsX2FyZ3M7Cisg ICAgICBMaXNwX09iamVjdCBudW1hcmdzID0gRmxlbmd0aCAoYXJnc19sZWZ0KTsKIAogICAg ICAgY2hlY2tfY29uc19saXN0ICgpOwogCkBAIC0yMTAxLDExICsyMTAwLDIwIEBAIGV2YWxf c3ViIChMaXNwX09iamVjdCBmb3JtKQogCSAgc2V0X2JhY2t0cmFjZV9hcmdzIChzcGVjcGRs ICsgY291bnQsIHZhbHMsIFhJTlQgKG51bWFyZ3MpKTsKIAogCSAgdmFsID0gKFhTVUJSIChm dW4pLT5mdW5jdGlvbi5hTUFOWSkgKFhJTlQgKG51bWFyZ3MpLCB2YWxzKTsKKworCSAgY2hl Y2tfY29uc19saXN0ICgpOworCSAgbGlzcF9ldmFsX2RlcHRoLS07CisJICAvKiBEbyB0aGUg ZGVidWctb24tZXhpdCBub3csIHdoaWxlIFZBTFMgc3RpbGwgZXhpc3RzLiAgKi8KKwkgIGlm IChiYWNrdHJhY2VfZGVidWdfb25fZXhpdCAoc3BlY3BkbCArIGNvdW50KSkKKwkgICAgdmFs ID0gY2FsbF9kZWJ1Z2dlciAobGlzdDIgKFFleGl0LCB2YWwpKTsKIAkgIFNBRkVfRlJFRSAo KTsKKwkgIHNwZWNwZGxfcHRyLS07CisJICByZXR1cm4gdmFsOwogCX0KICAgICAgIGVsc2UK IAl7Ci0JICBtYXhhcmdzID0gWFNVQlIgKGZ1biktPm1heF9hcmdzOworCSAgaW50IGksIG1h eGFyZ3MgPSBYU1VCUiAoZnVuKS0+bWF4X2FyZ3M7CisKIAkgIGZvciAoaSA9IDA7IGkgPCBt YXhhcmdzOyBpKyspCiAJICAgIHsKIAkgICAgICBhcmd2YWxzW2ldID0gZXZhbF9zdWIgKEZj YXIgKGFyZ3NfbGVmdCkpOwpAQCAtMjE2NSw3ICsyMTczLDcgQEAgZXZhbF9zdWIgKExpc3Bf T2JqZWN0IGZvcm0pCiAJfQogICAgIH0KICAgZWxzZSBpZiAoQ09NUElMRURQIChmdW4pKQot ICAgIHZhbCA9IGFwcGx5X2xhbWJkYSAoZnVuLCBvcmlnaW5hbF9hcmdzLCBjb3VudCk7Cisg ICAgcmV0dXJuIGFwcGx5X2xhbWJkYSAoZnVuLCBvcmlnaW5hbF9hcmdzLCBjb3VudCk7CiAg IGVsc2UKICAgICB7CiAgICAgICBpZiAoTklMUCAoZnVuKSkKQEAgLTIxOTUsNyArMjIwMyw3 IEBAIGV2YWxfc3ViIChMaXNwX09iamVjdCBmb3JtKQogCX0KICAgICAgIGVsc2UgaWYgKEVR IChmdW5jYXIsIFFsYW1iZGEpCiAJICAgICAgIHx8IEVRIChmdW5jYXIsIFFjbG9zdXJlKSkK LQl2YWwgPSBhcHBseV9sYW1iZGEgKGZ1biwgb3JpZ2luYWxfYXJncywgY291bnQpOworCXJl dHVybiBhcHBseV9sYW1iZGEgKGZ1biwgb3JpZ2luYWxfYXJncywgY291bnQpOwogICAgICAg ZWxzZQogCXhzaWduYWwxIChRaW52YWxpZF9mdW5jdGlvbiwgb3JpZ2luYWxfZnVuKTsKICAg ICB9CkBAIC0yNzUwLDE0ICsyNzU4LDEzIEBAIGFwcGx5X2xhbWJkYSAoTGlzcF9PYmplY3Qg ZnVuLCBMaXNwX09iamVjdCBhcmdzLCBwdHJkaWZmX3QgY291bnQpCiAgIHNldF9iYWNrdHJh Y2VfYXJncyAoc3BlY3BkbCArIGNvdW50LCBhcmdfdmVjdG9yLCBpKTsKICAgdGVtID0gZnVu Y2FsbF9sYW1iZGEgKGZ1biwgbnVtYXJncywgYXJnX3ZlY3Rvcik7CiAKKyAgY2hlY2tfY29u c19saXN0ICgpOworICBsaXNwX2V2YWxfZGVwdGgtLTsKICAgLyogRG8gdGhlIGRlYnVnLW9u LWV4aXQgbm93LCB3aGlsZSBhcmdfdmVjdG9yIHN0aWxsIGV4aXN0cy4gICovCiAgIGlmIChi YWNrdHJhY2VfZGVidWdfb25fZXhpdCAoc3BlY3BkbCArIGNvdW50KSkKLSAgICB7Ci0gICAg ICAvKiBEb24ndCBkbyBpdCBhZ2FpbiB3aGVuIHdlIHJldHVybiB0byBldmFsLiAgKi8KLSAg ICAgIHNldF9iYWNrdHJhY2VfZGVidWdfb25fZXhpdCAoc3BlY3BkbCArIGNvdW50LCBmYWxz ZSk7Ci0gICAgICB0ZW0gPSBjYWxsX2RlYnVnZ2VyIChsaXN0MiAoUWV4aXQsIHRlbSkpOwot ICAgIH0KKyAgICB0ZW0gPSBjYWxsX2RlYnVnZ2VyIChsaXN0MiAoUWV4aXQsIHRlbSkpOwog ICBTQUZFX0ZSRUUgKCk7CisgIHNwZWNwZGxfcHRyLS07CiAgIHJldHVybiB0ZW07CiB9CiAK LS0gCjIuMS4wCgo= --------------070802050301050302020804--