From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#50067: Context menus Date: Sat, 21 Aug 2021 12:57:23 +0200 Message-ID: <56454B2B-0250-4BC6-BC26-E1C5579ACF49@acm.org> References: <83sfz639lh.fsf@gnu.org> <8735r6ppf0.fsf@mail.linkov.net> <83o89u37gh.fsf@gnu.org> <87wnohx5zd.fsf@mail.linkov.net> <831r6p3lzc.fsf@gnu.org> <87o89sh96g.fsf@mail.linkov.net> <837dgg1hdg.fsf@gnu.org> <87mtpcf79p.fsf@mail.linkov.net> <83zgtcyp2k.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20609"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Juri Linkov , Tak Kunihiro , tkk@misasa.okayama-u.ac.jp, 50067@debbugs.gnu.org, Lars Ingebrigtsen To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 21 12:58:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHOhU-00058R-Li for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Aug 2021 12:58:08 +0200 Original-Received: from localhost ([::1]:59830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHOhT-0005VH-G8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Aug 2021 06:58:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHOhN-0005V2-UZ for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2021 06:58:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mHOhN-00046I-NA for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2021 06:58:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mHOhN-0003vR-Jo for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2021 06:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Aug 2021 10:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50067 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 50067-submit@debbugs.gnu.org id=B50067.162954346215061 (code B ref 50067); Sat, 21 Aug 2021 10:58:01 +0000 Original-Received: (at 50067) by debbugs.gnu.org; 21 Aug 2021 10:57:42 +0000 Original-Received: from localhost ([127.0.0.1]:35901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHOgz-0003um-NW for submit@debbugs.gnu.org; Sat, 21 Aug 2021 06:57:41 -0400 Original-Received: from mail202c50.megamailservers.eu ([91.136.10.212]:49814 helo=mail193c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHOgt-0003uY-2a for 50067@debbugs.gnu.org; Sat, 21 Aug 2021 06:57:35 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629543448; bh=Sx5FHpeyjrTmCR6Kp3RamaYgo6GPZ2UIvE1Owlv6hB0=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=MbWWLbQGnEJeA9KRq76VwXHqvu9B4iSKo70kMcoavIsxTcVwqjZOURLdexz8IqB0E 9Rfz83g54mcZ0BEgx52wWwsQtrGzeaZVzRuX9eV9Z8XjcJCy1lMLOTEjxla/4tW9yb cougcajLJxyZ+pNMU3yrX4B/2zJc+BP5Z7ZEiLkU= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail193c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17LAvNZA026257; Sat, 21 Aug 2021 10:57:25 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F1B.6120DC18.001E, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=GJV27dFK c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=hIj89exaAAAA:8 a=vaJtXVxTAAAA:8 a=SlV3f15FWa3tu2RXqD0A:9 a=CjuIK1q_8ugA:10 a=lS9wXHQM5UdnNJ4u63Ry:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212327 Archived-At: (Reply to multiple messages) 21 aug. 2021 kl. 11.42 skrev Alan Third : > GNUstep, and I believe NEXTstep and old school macOS, allows you to > "tear off" menus and leave them on screen as sort of custom toolbars. > Hence the title on each menu. >=20 > Emacs doesn't support this with the main menus (it was the source of a > crash, so I removed it), but I don't know if it's something we should > support. I suspect not because once Emacs updates the menus it > probably can't handle clicks on old ones. Thank you, I pushed the removal of the default "Select" title: titles = will still be there if given explicitly. If this causes trouble for = Gnustep, then we'll reinsert the default title for that platform only. 21 aug. 2021 kl. 01.31 skrev Dmitry Gutov : >> * If I start emacs -Q and enable context-menu-mode, right-clicking on = an identifier in an elisp buffer still doesn't produce the Find = Definition entry, presumably because xref hasn't been loaded. Shouldn't = it be arranged to be autoloaded somehow, which is how xref works when = invoked by keystrokes? >=20 > I wonder what could be the reason for that. It would seem the menu = should handle autoloaded commands fine. Even the visibility predicate = should work: xref-find-backend is autoloaded as well. It was just a (featurep 'xref) test which didn't seem to be needed; as = you say, all the functions involved are autoloaded and I have verified = that xref will indeed be loaded when the menu is used the first time. = Pushed to master. >> * `xref-make-match` requires (contrary to its doc string) its = LOCATION argument to be of type `xref-file-location`, but some backends = may only be able to make an `xref-buffer-location`. Would anyone object = to changing the :location slot of `xref-match-item` to have type = `xref-location`? I don't see how it could hurt. >=20 > Makes sense to me, seems like an accident. I've done this change = locally, no obvious bugs fell out. Thank you, fixed on master. Also pushed: * Previous patch that adds "Find References" to the menu; it seemed to = be the right thing to do. * A fringe arrow is now used to indicate the current position in the = *xref* buffer * Messages added to assuage the boredom of users while searching for = references. Could be moved, rephrased, made optional or removed = altogether, but it did look a lot better than freezing for a long time.