From: Dmitry Gutov <dgutov@yandex.ru>
To: "Simen Heggestøyl" <simenheg@gmail.com>
Cc: 21798@debbugs.gnu.org
Subject: bug#21798: 25.0.50; [PATCH] Add support for retrieving paths to JSON elements
Date: Sun, 8 Nov 2015 18:16:32 +0200 [thread overview]
Message-ID: <563F7560.1000409@yandex.ru> (raw)
In-Reply-To: <1446985933.1975.0@smtp.gmail.com>
Hi again, Simen.
On 11/08/2015 02:32 PM, Simen Heggestøyl wrote:
> Yes, maybe they should. The only drawback I see is that 'json-read' then
> needs to accept an optional parameter, which is the JSON key of the
> current element.
>
> A revised patch implementing your suggestion is attached.
Thank you, but since `json-read' needs an optional argument in this case
(which is not trivial to describe), I'd rather we go back to the
previous patch.
How about renaming json-pre-read-function to
json-pre-element-read-function, maybe? And same for the other one.
If you're fine with that, please install the result. (Or without the
rename, it's up to you).
> Benchmarks follow below, with the usual setup!
>
> Before the patch:
>
> (benchmark-run 100 (json-read-from-string huge-json))
> ⇒ (18.782874379000003 1007 5.674178575000008)
>
> After the patch:
>
> (benchmark-run 100 (json-read-from-string huge-json))
> ⇒ (18.233328517999997 1007 4.907621599000008)
Nice! The extra code made it faster. :)
Apparently, the difference is within the margin of error.
next prev parent reply other threads:[~2015-11-08 16:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-31 8:46 bug#21798: 25.0.50; [PATCH] Add support for retrieving paths to JSON elements Simen Heggestøyl
2015-10-31 14:23 ` Dmitry Gutov
2015-11-01 19:52 ` Simen Heggestøyl
2015-11-01 23:27 ` Simen Heggestøyl
2015-11-03 2:00 ` Dmitry Gutov
2015-11-06 16:31 ` Simen Heggestøyl
2015-11-06 17:15 ` Dmitry Gutov
2015-11-07 13:23 ` Richard Stallman
2015-11-07 13:43 ` Dmitry Gutov
2015-11-07 18:50 ` Simen Heggestøyl
2015-11-07 19:18 ` Dmitry Gutov
2015-11-08 12:32 ` Simen Heggestøyl
2015-11-08 12:34 ` Simen Heggestøyl
2015-11-08 16:16 ` Dmitry Gutov [this message]
2015-11-08 21:12 ` Simen Heggestøyl
2015-11-09 0:20 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563F7560.1000409@yandex.ru \
--to=dgutov@yandex.ru \
--cc=21798@debbugs.gnu.org \
--cc=simenheg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.