From: David Caldwell <david@porkrind.org>
To: 21862@debbugs.gnu.org
Subject: bug#21862: 24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6
Date: Sun, 8 Nov 2015 05:16:07 -0800 [thread overview]
Message-ID: <563F4B17.6090308@porkrind.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1910 bytes --]
I'm getting this when trying to build on Mac OS X 10.6:
CC nsterm.o
nsterm.m: In function '-[EmacsView toggleFullScreen:]':
nsterm.m:7058: error: 'NSWindowWillEnterFullScreenNotification'
undeclared (first use in this function)
nsterm.m:7058: error: (Each undeclared identifier is reported only once
nsterm.m:7058: error: for each function it appears in.)
nsterm.m:7066: error: 'NSWindowDidEnterFullScreenNotification'
undeclared (first use in this function)
nsterm.m:7098: error: 'NSWindowWillExitFullScreenNotification'
undeclared (first use in this function)
nsterm.m:7104: error: 'NSWindowDidExitFullScreenNotification'
undeclared (first use in this function)
make[1]: *** [nsterm.o] Error 1
make: *** [src] Error 2
make failed
Looks like this commit is the culprit:
commit 35cd51814507987b916c4b4e0a7b45e09e454341
Author: David Reitter <david.reitter@gmail.com>
Date: Sat Nov 7 20:43:29 2015 -0500
Provide NS notification objects where required to eliminate warnings
* nsterm.m (windowDidResize:, toggleFullScreen:):
Call notification functions with notification objects
as per delegate APIs.
NSWindow.h says:
APPKIT_EXTERN NSString * const NSWindowWillEnterFullScreenNotification
NS_AVAILABLE_MAC(10_7);
APPKIT_EXTERN NSString * const NSWindowDidEnterFullScreenNotification
NS_AVAILABLE_MAC(10_7);
APPKIT_EXTERN NSString * const NSWindowWillExitFullScreenNotification
NS_AVAILABLE_MAC(10_7);
APPKIT_EXTERN NSString * const NSWindowDidExitFullScreenNotification
NS_AVAILABLE_MAC(10_7);
We could fix this by wrapping NSWindow*FullScreenNotification with
preprocessor guards. On the other hand, that's getting awfully bulky for
creating a bunch of NSNotifications that aren't ever used (follow the
function calls).
Perhaps we can fix the warning a different way?
-David
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4239 bytes --]
next reply other threads:[~2015-11-08 13:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 13:16 David Caldwell [this message]
[not found] ` <handler.21862.B.14469886195908.ack@debbugs.gnu.org>
2015-11-10 19:37 ` bug#21862: Acknowledgement (24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6) David Caldwell
2015-11-10 19:43 ` David Reitter
2015-11-10 21:02 ` David Reitter
2015-11-10 21:11 ` David Caldwell
2015-11-10 21:39 ` Anders Lindgren
2015-11-10 22:10 ` David Reitter
2015-11-11 6:56 ` Anders Lindgren
2015-11-14 20:14 ` Anders Lindgren
2015-11-14 20:23 ` David Reitter
2015-11-14 23:23 ` John Wiegley
2015-11-15 7:18 ` Anders Lindgren
2015-11-15 17:57 ` Anders Lindgren
2015-11-10 22:12 ` David Caldwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563F4B17.6090308@porkrind.org \
--to=david@porkrind.org \
--cc=21862@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.