From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Peter Eisentraut Newsgroups: gmane.emacs.devel Subject: Re: package-install-from-buffer moves point Date: Sat, 7 Nov 2015 13:03:58 -0500 Message-ID: <563E3D0E.3080503@eisentraut.org> References: <55AA5AB3.1070505@eisentraut.org> <55ABCC84.4000400@eisentraut.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1446919950 5840 80.91.229.3 (7 Nov 2015 18:12:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 7 Nov 2015 18:12:30 +0000 (UTC) Cc: emacs-devel To: bruce.connor.am@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 07 19:12:20 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zv7yN-0003uz-DI for ged-emacs-devel@m.gmane.org; Sat, 07 Nov 2015 19:12:19 +0100 Original-Received: from localhost ([::1]:44844 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zv7yM-0005Dx-QO for ged-emacs-devel@m.gmane.org; Sat, 07 Nov 2015 13:12:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zv7rV-0004Ch-6G for emacs-devel@gnu.org; Sat, 07 Nov 2015 13:05:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zv7rS-0008To-0a for emacs-devel@gnu.org; Sat, 07 Nov 2015 13:05:13 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zv7rR-0008TE-Nx for emacs-devel@gnu.org; Sat, 07 Nov 2015 13:05:09 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 589CC20210 for ; Sat, 7 Nov 2015 13:05:07 -0500 (EST) Original-Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Sat, 07 Nov 2015 13:05:07 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=eisentraut.org; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=wc17LQL+Y8LvnTNz99CJFtI2Kas=; b=VA3aCq k7V5Ii3m1VwRVV2ip2RKb+s2iPEpQKM+NOPku4U8WSuHQOGxw5ZqS23eYKW9P42j f5NupxTwFmK5loDtTmLrqwOedKBmDkwQf2CC+0IXUVqZMpzyshWZUuCyszS5/Dfk 6FICbUfldsW8OajDHM1kKtpK+3X2n+mRAscDw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=wc17LQL+Y8LvnTN z99CJFtI2Kas=; b=DXmpSqxp0aMYgWIMHZOGzIDBcxGHoZoFSp5YjRr1O6bnPaT RM/4zrc3ixkwkkbxflEZ+Af63LToahjk5q934TiWpby10kpb+Y+F3mK4oJVdYcxN WqUPmFl/4qq+sE7Ywnc517dkV7EaDkodMvxF7OfDP5hfxuEEqlRY8gfccd68= X-Sasl-enc: gBdz3QIshlVWZCPfgagGSqCkZ5LgUzMrshSagnUo3VCw 1446919505 Original-Received: from [10.0.0.7] (c-73-13-69-21.hsd1.pa.comcast.net [73.13.69.21]) by mail.messagingengine.com (Postfix) with ESMTPA id A316BC016C4; Sat, 7 Nov 2015 13:05:04 -0500 (EST) User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.28 X-Mailman-Approved-At: Sat, 07 Nov 2015 13:12:15 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193553 Archived-At: On 7/19/15 1:06 PM, Artur Malabarba wrote: >>> This is due to calls to some `lm-*' functions inside >>> `package-buffer-info' (possibly one of the calls I added myself >>> yesterday). I can just wrap those in save-excursions, but I'm thinking >>> that the `lm-*' functions themselves should not be moving the point. >>> Shall I use save-excursion inside those functions instead? >> >> Well, there is also a goto-char call right at the top of >> package-buffer-info. > > Clearly I should stop replying to messages on my phone where I can't > look at the code first. :) > >> But I agree that the lm-* functions should >> probably save the point themselves, too. There are some calls to >> save-excursion in lisp-mnt.el, but it seems it's not applied consistently. > > Yes. `lm-header' always moves point to the header (besides returning > it). All the others I looked through seem to be fine. Did you (or someone) have a chance to work on this?