all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: yuan.mei.list@gmail.com, emacs-devel@gnu.org
Subject: Re: Font related crash?
Date: Fri, 06 Nov 2015 12:26:11 +0100	[thread overview]
Message-ID: <563C8E53.3040104@gmx.at> (raw)
In-Reply-To: <83oaf8s2xv.fsf@gnu.org>

 > It can't, but later we have this:
 >
 >    FRAME_DISPLAY_INFO (f)->n_fonts++;
 >    if (FRAME_DISPLAY_INFO (f)->n_fonts == 1)
 >      {
 >        FRAME_SMALLEST_CHAR_WIDTH (f) = min_width;
 >        FRAME_SMALLEST_FONT_HEIGHT (f) = height;
 >        f->fonts_changed = 1;
 >      }
 >    else
 >      {
 >        if (FRAME_SMALLEST_CHAR_WIDTH (f) > min_width)
 > 	FRAME_SMALLEST_CHAR_WIDTH (f) = min_width, f->fonts_changed = 1;
 >        if (FRAME_SMALLEST_FONT_HEIGHT (f) > height)
 > 	FRAME_SMALLEST_FONT_HEIGHT (f) = height, f->fonts_changed = 1;
 >      }
 >
 > If, for some reason, n_fonts is not zero,

Indeed.  Though such behavior would be unforeseen and probably buggy
too.

 > and
 > FRAME_SMALLEST_CHAR_WIDTH is zero, this will not do anything, and will
 > leave FRAME_SMALLEST_CHAR_WIDTH at zero.
 >
[...]
 >>   > Or maybe when we create a frame we should simply initialize
 >>   > FRAME_SMALLEST_CHAR_WIDTH to 1 (and similarly with
 >>   > FRAME_SMALLEST_FONT_HEIGHT).
 >>
 >> Or have these macros never provide zero.  My only concern is that this
 >> might hide some underlying problem.
 >
 > Yes, but which one?  Did you try reproducing this on X?

I don't have these fontsets.

martin



  parent reply	other threads:[~2015-11-06 11:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 22:32 Font related crash? Yuan MEI
2015-11-05  3:37 ` Eli Zaretskii
2015-11-05  6:55   ` Yuan MEI
2015-11-05  7:55     ` martin rudalics
2015-11-05  8:45       ` Yuan MEI
2015-11-05 16:26         ` Eli Zaretskii
2015-11-05 18:16           ` martin rudalics
2015-11-05 18:42             ` Eli Zaretskii
2015-11-06 10:31               ` Yuan MEI
2015-11-06 10:50                 ` Eli Zaretskii
2015-11-06 11:26               ` martin rudalics [this message]
2015-11-06 11:25 ` martin rudalics
2015-11-07  5:52   ` Yuan MEI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563C8E53.3040104@gmx.at \
    --to=rudalics@gmx.at \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=yuan.mei.list@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.