From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 39355bc: Revert "* lisp/subr.el (when): Use `macroexp-progn'" Date: Thu, 5 Nov 2015 17:44:54 -0500 Message-ID: <563BDBE6.9000909@cornell.edu> References: <20151104142253.19562.42500@vcs.savannah.gnu.org> <563BCDC7.6010200@cornell.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1446763527 23638 80.91.229.3 (5 Nov 2015 22:45:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Nov 2015 22:45:27 +0000 (UTC) Cc: emacs-devel To: bruce.connor.am@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 05 23:45:19 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZuTHQ-0000Zv-Hn for ged-emacs-devel@m.gmane.org; Thu, 05 Nov 2015 23:45:16 +0100 Original-Received: from localhost ([::1]:35700 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuTHQ-0008S1-3T for ged-emacs-devel@m.gmane.org; Thu, 05 Nov 2015 17:45:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuTH7-0008PJ-P2 for emacs-devel@gnu.org; Thu, 05 Nov 2015 17:44:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuTH4-0006ZA-Jn for emacs-devel@gnu.org; Thu, 05 Nov 2015 17:44:57 -0500 Original-Received: from limerock04.mail.cornell.edu ([128.84.13.244]:37196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuTH4-0006Z0-Gz for emacs-devel@gnu.org; Thu, 05 Nov 2015 17:44:54 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id tA5Mira0021637; Thu, 5 Nov 2015 17:44:53 -0500 Original-Received: from [192.168.226.19] (chartreuse.rembrandt.nctp.westelcom.com [64.19.84.46]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id tA5MiqpU025211 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 5 Nov 2015 17:44:53 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 128.84.13.244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193349 Archived-At: On 11/5/2015 5:17 PM, Artur Malabarba wrote: > > You only reverted part of the commit, leaving the new test in place. > Was that intentional? > > Yes. No reason to delete the test. :-) This part fails: (should (equal (macroexpand-all '(when a b)) '(if a b))) It should be (should (equal (macroexpand-all '(when a b)) '(if a (progn b)))) Ken