From: Ken Brown <kbrown@cornell.edu>
To: bruce.connor.am@gmail.com
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] master 39355bc: Revert "* lisp/subr.el (when): Use `macroexp-progn'"
Date: Thu, 5 Nov 2015 17:44:54 -0500 [thread overview]
Message-ID: <563BDBE6.9000909@cornell.edu> (raw)
In-Reply-To: <CAAdUY-KczJwtfYc28n7_qAZOZC61m8AYVhRHuHZGT_WpEdCFtA@mail.gmail.com>
On 11/5/2015 5:17 PM, Artur Malabarba wrote:
> > You only reverted part of the commit, leaving the new test in place.
> Was that intentional?
>
> Yes. No reason to delete the test. :-)
This part fails:
(should (equal (macroexpand-all '(when a b))
'(if a b)))
It should be
(should (equal (macroexpand-all '(when a b))
'(if a (progn b))))
Ken
next prev parent reply other threads:[~2015-11-05 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151104142253.19562.42500@vcs.savannah.gnu.org>
[not found] ` <E1Ztyxh-000568-UG@vcs.savannah.gnu.org>
2015-11-05 21:44 ` [Emacs-diffs] master 39355bc: Revert "* lisp/subr.el (when): Use `macroexp-progn'" Ken Brown
2015-11-05 22:17 ` Artur Malabarba
2015-11-05 22:44 ` Ken Brown [this message]
2015-11-06 0:12 ` Artur Malabarba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563BDBE6.9000909@cornell.edu \
--to=kbrown@cornell.edu \
--cc=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.