From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#21799: Requesting review for change to js.el Date: Sat, 31 Oct 2015 14:36:04 +0200 Message-ID: <5634B5B4.6070907@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1446295041 19243 80.91.229.3 (31 Oct 2015 12:37:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 31 Oct 2015 12:37:21 +0000 (UTC) To: Jackson Hamilton , 21799@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 31 13:37:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZsVPB-0006dJ-PG for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Oct 2015 13:37:09 +0100 Original-Received: from localhost ([::1]:55503 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsVPB-00051V-97 for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Oct 2015 08:37:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsVP7-00051P-IH for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2015 08:37:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsVP4-0003dz-D5 for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2015 08:37:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsVP4-0003dv-9e for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2015 08:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZsVP3-0003Ep-UV for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2015 08:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Oct 2015 12:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21799-submit@debbugs.gnu.org id=B21799.144629497012391 (code B ref 21799); Sat, 31 Oct 2015 12:37:01 +0000 Original-Received: (at 21799) by debbugs.gnu.org; 31 Oct 2015 12:36:10 +0000 Original-Received: from localhost ([127.0.0.1]:46761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZsVOE-0003Dm-2G for submit@debbugs.gnu.org; Sat, 31 Oct 2015 08:36:10 -0400 Original-Received: from mail-wm0-f51.google.com ([74.125.82.51]:36459) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZsVOB-0003De-U9 for 21799@debbugs.gnu.org; Sat, 31 Oct 2015 08:36:08 -0400 Original-Received: by wmec75 with SMTP id c75so29553421wme.1 for <21799@debbugs.gnu.org>; Sat, 31 Oct 2015 05:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=I/5nXEXFnBn7cZ1+C85s86svPDuz9Y9RV2Mgj9d1rzQ=; b=WhdA+L5Flp0AC+anecC/C/ulSveRovJtGcP0Oqyl+lwdfDGaElildVdynqfIOkhtq6 Lk0ak0s0SrES9Q7qqhkclhItk7iAvqXSPF2mig957WLPpH2kUTHCIaft9S6cMYGZRF0K eFAF4u4nhPYWHIPM5LIkueB6AbKoRoU1bf28X9rJLe+6Ze5zHKzovHCE3m6cTwOLqu19 EvHGWmm9+8s+nO/Kg9Uu4RPo321y6flZBSFOefTQ+eNDXCSFGQeQQ24dITTSOHzgAZDg r6q6uTEsEP7nyPCUL0lrG0F7qLqZisdXw+Nlpn3sra+iqkBbTzLWTRJ48fdspksJ767R gzNg== X-Received: by 10.28.87.67 with SMTP id l64mr3193231wmb.72.1446294967344; Sat, 31 Oct 2015 05:36:07 -0700 (PDT) Original-Received: from [10.9.0.103] (nat.webazilla.com. [78.140.128.228]) by smtp.googlemail.com with ESMTPSA id gh9sm11914844wjb.27.2015.10.31.05.36.05 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 31 Oct 2015 05:36:06 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Thunderbird/42.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108227 Archived-At: On 10/31/2015 11:37 AM, Jackson Hamilton wrote: > See attached patch. Adds JSX indentation support to js-mode. Hi Jackson, JSX files have a different extension, right? Why don't we make it a separate major mode? It can also live in js.el and derive from js-mode. The only thing it'll change (for now?) is the indentation function. And for those who also want the js2-mode AST, we can either tell them to use js2-minor-mode, or also create a js2-jsx-mode that would derive from js2-mode and use the indentation function defined here. Then there will be no need for the option js-indent-jsx.