all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: michael.albinus@gmx.de, emacs-devel@gnu.org
Subject: Re: Collation tests in fns-tests.el
Date: Fri, 30 Oct 2015 18:16:29 -0400	[thread overview]
Message-ID: <5633EC3D.4070903@cornell.edu> (raw)
In-Reply-To: <83bnbgyr87.fsf@gnu.org>

On 10/30/2015 5:35 PM, Eli Zaretskii wrote:
>> Cc: michael.albinus@gmx.de, emacs-devel@gnu.org
>> From: Ken Brown <kbrown@cornell.edu>
>> Date: Fri, 30 Oct 2015 17:10:48 -0400
>>
>> On 10/30/2015 4:28 PM, Eli Zaretskii wrote:
>>> You already said in that discussion what I'd suggest ;-)
>>>
>>> Since Cygwin tries to be compatible to GNU/Linux (i.e. glibc), it
>>> should indeed use some non-zero flags in its implementation of string
>>> collation-dependent comparison.  IMO, it makes no sense not to do
>>> that, since users expect that to happen.
>>
>> Yes, I agree completely.  The issue is implementation.  Simply using the
>> NORM_IGNORESYMBOLS flag yields comparison functions that can return 0 on
>> unequal strings.  Eric pointed out the problem with that; moreover, it
>> seriously violates users' expectations and compatibility with glibc.  I
>> thought I had a way around that, but Corinna pointed out in
>> https://www.cygwin.com/ml/cygwin/2015-10/msg00559.html why my suggestion
>> doesn't work.  At this point I'm out of ideas.
>
> I don't see why that conclusion is the only reasonable one (the
> "seriously violates users' expectation" part surprises me), but I
> don't really consider myself an expert on this, certainly not in
> Cygwin.
>
> If Cygwin's implementation of strcoll cannot be fixed, then we should
> treat this test on Cygwin as expected failure.

I'll probably do that, but I'll wait to see if Michael has anything to add.

Ken




  reply	other threads:[~2015-10-30 22:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30 17:51 Collation tests in fns-tests.el Ken Brown
2015-10-30 20:28 ` Eli Zaretskii
2015-10-30 20:40   ` Eli Zaretskii
2015-10-30 21:10   ` Ken Brown
2015-10-30 21:35     ` Eli Zaretskii
2015-10-30 22:16       ` Ken Brown [this message]
2015-10-31  8:49         ` Michael Albinus
2015-10-31  9:07           ` Eli Zaretskii
2015-11-02 16:25             ` Ken Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5633EC3D.4070903@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.