From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?iso-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: Not a regression, but shuld go into emacs-24 Date: Tue, 3 Jun 2014 07:10:49 +0200 Message-ID: <56311164-C9D0-4A58-A85C-2E3F821299AA@swipnet.se> References: <538B03D4.6030502@swipnet.se> <538B1D0D.3010102@gmx.at> <538B6CC4.1060309@swipnet.se> <538C2250.1090805@gmx.at> <66A6FA1C-3A31-4331-8421-50E5B012CB6F@swipnet.se> <538CBC2F.1050306@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1401772276 1816 80.91.229.3 (3 Jun 2014 05:11:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Jun 2014 05:11:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 03 07:11:09 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wrh09-00031M-0x for ged-emacs-devel@m.gmane.org; Tue, 03 Jun 2014 07:11:09 +0200 Original-Received: from localhost ([::1]:50400 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wrh08-0006qU-Bd for ged-emacs-devel@m.gmane.org; Tue, 03 Jun 2014 01:11:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wrh00-0006qC-5B for emacs-devel@gnu.org; Tue, 03 Jun 2014 01:11:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wrgzs-0002ev-JR for emacs-devel@gnu.org; Tue, 03 Jun 2014 01:11:00 -0400 Original-Received: from mailfe09.swip.net ([212.247.155.1]:42372 helo=swip.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wrgzs-0002ej-Cj for emacs-devel@gnu.org; Tue, 03 Jun 2014 01:10:52 -0400 X-T2-Spam-Status: No, hits=0.0 required=5.0 Original-Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe09.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 332772908; Tue, 03 Jun 2014 07:10:50 +0200 In-Reply-To: <538CBC2F.1050306@gmx.at> X-Mailer: Apple Mail (2.1878.2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 212.247.155.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172277 Archived-At: Hello. 2 jun 2014 kl. 20:02 skrev martin rudalics : > > Only for a jump scroll. When dragging or scrolling by page, PORTION > > passed to x_send_scroll_bar_event is zero, as is WHOLE. >=20 > IIUC in XmCR_DRAG we set PORTION to 'cs->value', XmCR_DRAG is jump in Motif speak. > in xg_scroll_callback > we set PORTION to 'position' No we don't, please look at the current code. portion and whole are = initialized to 0 and only set for JUMP. > and in xaw_scroll_callback we explicitly > pass 'position' as PORTION argument. Because that callback does not distinguish between the different scroll = modes. > So in all three cases we pass a > position. And IIUC we pass zero for PORTION and WHOLE iff when we end > scrolling (when the user releases the slider). Iff is clearly wrong. Look at xg_scroll_callback and do tell me how = portion and whole gets a value other than zero when scroll is not = GTK_SCROLL_JUMP. Ditto for xm_scroll_callback when cs->reason is not XmCR_DRAG. >=20 > > For jump scroll, PORTION is the position of the scroll bar thumb = that we jump to. >=20 > I didn't look into jump scroll so far. But what you say here = indicates > that jump scroll also passes a position via the PORTION argument. >=20 > > The values of PORTION in x_send_scroll_bar_event and > > x_set_toolkit_scroll_bar_thumb are different. The first has values = as > > defined by the scroll bar. For Gtk+, Motif and Xaw this is a value > > between 0 or 1 and 10000000. >=20 > Yes (in my experience Gtk+ can handle WHOLE directly as is). This looks ugly when WHOLE changes. The Gtk+ scroll bar does not redraw = nicely. Jan D. >=20 > > The values to x_set_toolkit_scroll_bar_thumb are in characters, > > i.e. show PORTION characters for the buffer, starting at character > > POSITION. The buffer has a total of WHOLE characters. >=20 > But the values passed to x_send_scroll_bar_event are in characters too > (and the value of WHOLE is supposed to be the same as when setting the > thumb). Or am I missing something? >=20 > martin