From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Thum Subject: Re: Regression in Org triggered from helm Date: Tue, 27 Oct 2015 21:48:19 +0000 Message-ID: <562FF123.2070306@gmx.de> References: <562FDD12.7000702@gmx.de> <877fm9bb40.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqpdL-000653-0t for emacs-orgmode@gnu.org; Mon, 26 Oct 2015 17:48:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqpdG-0004Bf-Ti for emacs-orgmode@gnu.org; Mon, 26 Oct 2015 17:48:50 -0400 In-Reply-To: <877fm9bb40.fsf@kyleam.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Kyle Meyer Cc: Bastien , emacs-orgmode On 10/26/15 20:58, Kyle Meyer wrote: > Hello, > > Simon Thum writes: > >> Hi, >> >> after updating helm I came across a possible regression on Org. I >> Already filed a helm bug, but Thierry thinks it's Org's fault. > > What version of Org are you using? Org-mode 8.3.2 - I just upgraded from 8.3 beta hoping to fix this. > >> https://github.com/emacs-helm/helm/issues/1246 >> >> In short, M-x helm-org-agenda-files-headings breaks. >> >> I had some success working around it, but for reasons beyond me that >> doesn't work any more. I'll try to work out a MCE but for the time in >> between, maybe someone has an idea what's wrong, and where (org or >> helm)? > > I haven't had any luck reproducing this. Isolating the error with a > minimal configuration and minimal Org file would be very helpful. I know, but ATM my time is limited. I tried to debug but only got as far as Edebug: edebug-anon74105 edebug-signal: Symbol's value as variable is void: Debugger At which point I figured reporting the bug might be sensible enough. > >> >> Here is the complete stacktrace (the -my function is textually >> equivalent to its non-my counterpart in helm-org): >> >> >> Debugger entered--Lisp error: (args-out-of-range "LoD" 0 -3) >> substring("LoD" 0 -6) >> (setq h (substring h 0 (- maxwidth 2)) total (+ total maxwidth 1)) > > At some point, maxwidth is being set very low (-4 here). Try to see > where this happens. For example, what value for width does > helm-get-org-candidates-in-file send into org-format-outline-path? If > that seems to be appropriate, debug org-format-outline-path and see when > it's getting set to the low value. Arrgh - you're on the spot. That explains a lot, including my difficulties with reproducing. It sends window-width. Increase to window(-width) and I'm done. But that means it's arguably Org which should be more graceful than it is. Bastien, I cc'ed you as the maintainer, I guess you know who's best qualified to fix this. Thanks for your input Kyle! Cheers, Simon