From: martin rudalics <rudalics@gmx.at>
To: Juanma Barranquero <lekktu@gmail.com>,
Markus Triska <triska@metalevel.at>
Cc: 21766@debbugs.gnu.org
Subject: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace
Date: Tue, 27 Oct 2015 09:05:52 +0100 [thread overview]
Message-ID: <562F3060.9050301@gmx.at> (raw)
In-Reply-To: <CAAeL0SQ2X62q1YWEdTjj4Tkh6=mTRo6EmJmY-4F0fE0bgm8JyA@mail.gmail.com>
> Now, the question is, should skip-syntax-backward preserve the
> match data, or must delete-trailing-whitespace be coded defensively?
The latter.
> The
> usual policy has been that code that needs the match data preserved should
> make sure itself that it is so.
Shouldn't we remove that "\\s-$" rigmarole? Something like the largely
untested
(let ((end-marker (copy-marker (or end (point-max))))
old-bol new-eol new-bol)
(goto-char (or start (point-min)))
(while (re-search-forward "\\\n" end-marker t)
(setq new-bol (point))
(goto-char (setq new-eol (match-beginning 0)))
(if (or (zerop (skip-syntax-backward
"-" (or old-bol (line-beginning-position))))
(looking-at-p ".*\f"))
(goto-char new-bol)
(delete-region (point) new-eol)
(forward-char))
(setq old-bol (point)))
It's still not very clean (should line-beginning-position be allowed to
go before START?) so if someone wants to polish it up ....
martin
next prev parent reply other threads:[~2015-10-27 8:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 23:07 bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace Markus Triska
2015-10-27 0:15 ` Juanma Barranquero
2015-10-27 7:07 ` Andreas Röhler
2015-10-27 7:53 ` Juanma Barranquero
2015-10-27 8:05 ` martin rudalics [this message]
2015-10-27 8:12 ` Juanma Barranquero
2015-10-27 8:25 ` martin rudalics
2015-10-27 8:32 ` Juanma Barranquero
2015-10-27 9:01 ` Andreas Schwab
2015-10-27 9:16 ` Juanma Barranquero
2015-10-27 9:24 ` martin rudalics
2015-10-27 9:46 ` Andreas Schwab
2015-10-27 10:21 ` Juanma Barranquero
2015-10-27 16:03 ` Juanma Barranquero
2015-10-28 1:51 ` Stephen Leake
2015-10-28 9:08 ` Juanma Barranquero
2015-10-28 17:38 ` Juanma Barranquero
2015-10-28 9:08 ` Juanma Barranquero
2015-10-28 1:51 ` Stephen Leake
2015-10-27 16:03 ` Juanma Barranquero
2015-10-28 19:19 ` Stefan Monnier
2015-10-29 6:30 ` Andreas Röhler
2015-10-29 9:41 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F3060.9050301@gmx.at \
--to=rudalics@gmx.at \
--cc=21766@debbugs.gnu.org \
--cc=lekktu@gmail.com \
--cc=triska@metalevel.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.