From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 5e43955 1/2: Don't declare vc-exec-after anymore Date: Fri, 23 Oct 2015 16:38:57 +0300 Message-ID: <562A3871.7010702@yandex.ru> References: <20151020190758.14547.6515@vcs.savannah.gnu.org> <5628D1C5.4070300@yandex.ru> <83eggnt054.fsf@gnu.org> <83fv12rqk2.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1445607574 28531 80.91.229.3 (23 Oct 2015 13:39:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 Oct 2015 13:39:34 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Eli Zaretskii , lekktu@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 23 15:39:29 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZpcYs-0002ja-Fm for ged-emacs-devel@m.gmane.org; Fri, 23 Oct 2015 15:39:14 +0200 Original-Received: from localhost ([::1]:38532 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpcYr-0006Sm-UW for ged-emacs-devel@m.gmane.org; Fri, 23 Oct 2015 09:39:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpcYn-0006ST-Ee for emacs-devel@gnu.org; Fri, 23 Oct 2015 09:39:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpcYh-00029G-GP for emacs-devel@gnu.org; Fri, 23 Oct 2015 09:39:09 -0400 Original-Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:34555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpcYh-00028p-9u; Fri, 23 Oct 2015 09:39:03 -0400 Original-Received: by wikq8 with SMTP id q8so77447138wik.1; Fri, 23 Oct 2015 06:39:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=mN2m6pHq0oNtHI408CaCIHzC9ZDiV+evLPMDHQt20Cc=; b=zVXn72AsuAAMAgsNAychzhYg00BECe6GQQe3x6xq19GsRPpmTwQGNsOvCNckUYVRi0 +iA3Fvi97vMGtl0kz8VzmWm3GEqtvVSpAW5rnlijYcESu5SPpxsibJNU9hiJVMw6o4cx oBxwGFDYqJ+0ce2OChfxE0STI0/vardiOUl9/d6+Q2v2L4CwWIewL6854EqVKIwqQckH 9jf55yXxjOmdD6SRA7BA9TghvWtu34pjzWRjjT5VVHBNSiTk19KRX23NMshE4oa/woDM qE2SOryqTrzqAErZ5XVf3udV7wg6oQqQEx3zf1dj4wlOBq6SKbOZ9dgRBJDURV25j1oN XTcQ== X-Received: by 10.180.211.109 with SMTP id nb13mr4515865wic.52.1445607542234; Fri, 23 Oct 2015 06:39:02 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id jt9sm7609217wjc.24.2015.10.23.06.39.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Oct 2015 06:39:01 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Thunderbird/42.0 In-Reply-To: <83fv12rqk2.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192486 Archived-At: On 10/23/2015 10:29 AM, Eli Zaretskii wrote: > I think bug#21724 supplies an answer: eval-when-compile makes this > function known _at_compile_time_, but the warning says it might not be > known _at_run_time_. > > IOW, for a macro it is enough to use eval-when-compile, but if that > macro calls a function, the function should be either auto-loaded, or > the package that defines that function should be require'd. That makes a lot of sense, thank you. Even thought it's counter-intuitive, because that means we not only have to care about the functions we call, we must also know, in this kind of situations, what macros expand to. But the fact that using (autoload foo "pkg") fixes it if pkg loads vc-dispatcher, muddies the problem. For me, it makes compilation succeed without warnings not only in vc-svn, but in vc-hg and vc-cvs as well. Unless anyone has a better suggestion (Stefan?), guess I'll just revert the commit.