From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>, lekktu@gmail.com
Cc: Stefan Monnier <monnier@IRO.UMontreal.CA>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 5e43955 1/2: Don't declare vc-exec-after anymore
Date: Fri, 23 Oct 2015 16:38:57 +0300 [thread overview]
Message-ID: <562A3871.7010702@yandex.ru> (raw)
In-Reply-To: <83fv12rqk2.fsf@gnu.org>
On 10/23/2015 10:29 AM, Eli Zaretskii wrote:
> I think bug#21724 supplies an answer: eval-when-compile makes this
> function known _at_compile_time_, but the warning says it might not be
> known _at_run_time_.
>
> IOW, for a macro it is enough to use eval-when-compile, but if that
> macro calls a function, the function should be either auto-loaded, or
> the package that defines that function should be require'd.
That makes a lot of sense, thank you. Even thought it's
counter-intuitive, because that means we not only have to care about the
functions we call, we must also know, in this kind of situations, what
macros expand to.
But the fact that using (autoload foo "pkg") fixes it if pkg loads
vc-dispatcher, muddies the problem. For me, it makes compilation succeed
without warnings not only in vc-svn, but in vc-hg and vc-cvs as well.
Unless anyone has a better suggestion (Stefan?), guess I'll just revert
the commit.
prev parent reply other threads:[~2015-10-23 13:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151020190758.14547.6515@vcs.savannah.gnu.org>
[not found] ` <E1ZocGN-0003nd-DB@vcs.savannah.gnu.org>
[not found] ` <CAAeL0STEg9P4GgT_XFJh_J0SexBnoT_Vh_=muMxsQYVBoNW-xA@mail.gmail.com>
2015-10-22 12:08 ` [Emacs-diffs] master 5e43955 1/2: Don't declare vc-exec-after anymore Dmitry Gutov
2015-10-22 12:25 ` Juanma Barranquero
2015-10-22 15:04 ` Eli Zaretskii
2015-10-23 7:29 ` Eli Zaretskii
2015-10-23 13:38 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562A3871.7010702@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.