From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add shell-quasiquote. Date: Sat, 17 Oct 2015 19:40:21 -0700 Organization: UCLA Computer Science Department Message-ID: <56230695.4070501@cs.ucla.edu> References: <87si59wj42.fsf@T420.taylan> <83eggt4esi.fsf@gnu.org> <87fv19wh7b.fsf@T420.taylan> <83bnbx4d7e.fsf@gnu.org> <87twppuzfu.fsf@T420.taylan> <83a8rh48if.fsf@gnu.org> <87io65utmt.fsf@T420.taylan> <5622B3C6.4030208@cs.ucla.edu> <871tctuqw5.fsf@T420.taylan> <5622C340.1050001@cs.ucla.edu> <87lhb1t9sm.fsf@T420.taylan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1445136047 1129 80.91.229.3 (18 Oct 2015 02:40:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 18 Oct 2015 02:40:47 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?UTF-8?Q?Taylan_Ulrich_Bay=c4=b1rl=c4=b1/Kammer?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 18 04:40:38 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zndtk-0003oA-SK for ged-emacs-devel@m.gmane.org; Sun, 18 Oct 2015 04:40:37 +0200 Original-Received: from localhost ([::1]:60403 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zndtj-0003qZ-UG for ged-emacs-devel@m.gmane.org; Sat, 17 Oct 2015 22:40:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zndtf-0003qR-Ae for emacs-devel@gnu.org; Sat, 17 Oct 2015 22:40:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZndtY-00064H-Hw for emacs-devel@gnu.org; Sat, 17 Oct 2015 22:40:29 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZndtY-00063w-Cq for emacs-devel@gnu.org; Sat, 17 Oct 2015 22:40:24 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id DFB63160D69; Sat, 17 Oct 2015 19:40:22 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id m7Ue8VpANFFr; Sat, 17 Oct 2015 19:40:22 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 09AAF160E02; Sat, 17 Oct 2015 19:40:22 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id h_Ki3tl9vBNK; Sat, 17 Oct 2015 19:40:21 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D7328160D69; Sat, 17 Oct 2015 19:40:21 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 In-Reply-To: <87lhb1t9sm.fsf@T420.taylan> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191907 Archived-At: Taylan Ulrich Bay=C4=B1rl=C4=B1/Kammer wrote: > Please tell me which shells shell-quote-argument is guaranteed to work > safely on Nobody can tell you that. What we can tell you is that shell-quote-argume= nt=20 works on a superset of uses that shqq--quote-string works on. The trust-b= ased=20 arguments against using shell-quote-argument all apply, with greater forc= e,=20 against using shqq--quote-string. For example, shqq--quote-string is more= =20 vulnerable to code-injection attacks than shell-quote-argument is. I am not a fan of non-POSIX shells. They are a hassle to deal with and ca= n cause=20 significant problems in Emacs maintenance. In areas where they are a sign= ificant=20 problem, we don't need to support them. But this particular instance is n= ot a=20 significant problem. Emacs already has a portable, tested, easy-to-use fu= nction=20 to quote shell arguments, and there's good reason to use it here.