From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#30285: dired-do-chmod vs. top line of dired Date: Thu, 1 Feb 2018 12:50:16 -0800 (PST) Message-ID: <5620cf82-9402-4895-bdd1-fdf5401c8172@default> References: <87mv0wg80c.fsf@jidanni.org> <87efm8snnr.fsf@gmail.com> <83efm8irac.fsf@gnu.org> <87d11sl08v.fsf@gmail.com> <87fu6lwxxu.fsf@mail.linkov.net> <87k1vwcwy1.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1517518778 19922 195.159.176.226 (1 Feb 2018 20:59:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Feb 2018 20:59:38 +0000 (UTC) Cc: 30285@debbugs.gnu.org, jidanni@jidanni.org To: Juri Linkov , Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 01 21:59:33 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehLx9-0004ZG-UY for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Feb 2018 21:59:28 +0100 Original-Received: from localhost ([::1]:34400 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehLzA-0002lC-H7 for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Feb 2018 16:01:32 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:44369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehLvQ-00071U-CF for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2018 15:58:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehLp0-0005Pg-J1 for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2018 15:52:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44881) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ehLp0-0005PQ-CQ for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2018 15:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ehLp0-0008Oa-11 for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2018 15:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Feb 2018 20:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30285 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30285-submit@debbugs.gnu.org id=B30285.151751823032230 (code B ref 30285); Thu, 01 Feb 2018 20:51:01 +0000 Original-Received: (at 30285) by debbugs.gnu.org; 1 Feb 2018 20:50:30 +0000 Original-Received: from localhost ([127.0.0.1]:52778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehLoT-0008Nm-QD for submit@debbugs.gnu.org; Thu, 01 Feb 2018 15:50:29 -0500 Original-Received: from userp2120.oracle.com ([156.151.31.85]:52542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehLoS-0008NZ-AT for 30285@debbugs.gnu.org; Thu, 01 Feb 2018 15:50:28 -0500 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w11KjrCH076097; Thu, 1 Feb 2018 20:50:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=OS/Td4TY+eJ4s1WBmhC8K1A4XHkuubA5BoMn/NQz8xI=; b=Z1PujiwYywpB7GKj4D1OCrtSMEQ1FMzADo7D38bXXytFAuQMOy75lPOqdUt2wrZPyUHj c62wXm8dE8PwAUo95XU1JPInbvzFzreyTpNiJDPzodwD5KgdFfTrjVGXaruaVBQPVmr7 EEYQ56pLA7UmzdYr2L4Y8UFpjX1exE0hst6VD3yFI6fn8/OFIFwVSwHUcEiMgVEAdk0K Mj6JcLqtBujqLdcXUN4yHjYELarhUJ78shtA30Ij4OkJAQ1agXNLTXUrh+38eveYbpFK kTLnPaDMP/3fIBlla3nMp8QTNlzthPKKsqevKf4/iTdqRo59HQB5O30rRXrrJaQ6mMjL wg== Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2fva7980k2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 01 Feb 2018 20:50:22 +0000 Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w11KoJme007833 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 1 Feb 2018 20:50:19 GMT Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w11KoIXV028978; Thu, 1 Feb 2018 20:50:18 GMT In-Reply-To: <87k1vwcwy1.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4639.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8792 signatures=668660 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802010261 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.0 (/) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142781 Archived-At: > Since `dired-mark' from the top line followed by the command in question > is not obvious for users, we could provide a hint in the error message, > i.e. mention the availability of =E2=80=98m=E2=80=99 on the top line with= such message: > =E2=80=9CYou can type `m' here to mark all files for this operation=E2=80= =9D. Not sure how helpful or necessary that is. It's liable to not be helpful (that use case needs no special advertising). And it might even confuse things. I think it just gets in the way of the message, which is, "You are not on a file line." I think we should show the same error message from any non-file line - not just the top line or top-two lines. And I think it should just say that point is not on a file line. Users who are interested or who wonder about the error message can consult the doc string of the command. That's the place, if any is needed, where such info as you mention should be conveyed. Such info is not part of the message we're trying to get across here, which is just that this command cannot be used if point is not on a file line. Dired lets you do all kinds of things. There are lots of ways top mark files and lots of ways to act on marked files. This command should not be advertising any such ways in its error message. > I agree with Drew that better to use existing functions, and not to > duplicate them. Non sunt multiplicanda entia sine necessitate. ;-) > Moreover, we should not change the old semantic of Dired commands: > if users have a habit of operating on the first files by going to the > top > line and typing e.g. =E2=80=98M-< C-5 M=E2=80=99 to change modes of the f= irst 5 files, > this is just fine, we should not prohobit this behaviour now. >=20 > So what we need to do is just check if the list of files returned from > =E2=80=98dired-get-marked-files=E2=80=99 is nil, and show some message in= this case in > all places that you found where the prompt with [0 files] makes no > sense. Yes. Just a simple fix for this minor usability bug, please.