From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Master is broken Date: Sat, 10 Oct 2015 12:01:29 -0700 Organization: UCLA Computer Science Department Message-ID: <56196089.6070809@cs.ucla.edu> References: <838u7bt8id.fsf@gnu.org> <83pp0nrofp.fsf@gnu.org> <56194102.50703@cs.ucla.edu> <83y4far6um.fsf@gnu.org> <83vbaer6k3.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020303030602080403050209" X-Trace: ger.gmane.org 1444503738 19135 80.91.229.3 (10 Oct 2015 19:02:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 10 Oct 2015 19:02:18 +0000 (UTC) Cc: schwab@suse.de, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 10 21:02:08 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZkzPB-0006Ne-7x for ged-emacs-devel@m.gmane.org; Sat, 10 Oct 2015 21:02:05 +0200 Original-Received: from localhost ([::1]:45897 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkzPA-0007eb-Qm for ged-emacs-devel@m.gmane.org; Sat, 10 Oct 2015 15:02:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkzOj-0007dj-S2 for emacs-devel@gnu.org; Sat, 10 Oct 2015 15:01:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZkzOi-0002Aj-No for emacs-devel@gnu.org; Sat, 10 Oct 2015 15:01:37 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:37746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkzOd-00028i-Hq; Sat, 10 Oct 2015 15:01:31 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BE79B1606CC; Sat, 10 Oct 2015 12:01:30 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id q48SE8lmycvQ; Sat, 10 Oct 2015 12:01:29 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 80E6A160D97; Sat, 10 Oct 2015 12:01:29 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1LnKnooC589L; Sat, 10 Oct 2015 12:01:29 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 5DDE91606CC; Sat, 10 Oct 2015 12:01:29 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 In-Reply-To: <83vbaer6k3.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191164 Archived-At: This is a multi-part message in MIME format. --------------020303030602080403050209 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Eli Zaretskii wrote: > Also, when exactly are INLINE_HEADER_BEGIN/END required? puresize.h > doesn't have it, and still compiles; other headers which use INLINE do > have INLINE_HEADER_BEGIN/END. What factor determines whether they are > absolutely required? They're always needed, if you want to build with --enable-gcc-warnings and use GCC older than 5.1. I hope we can drop them once we assume that people who want picky warnings are using GCC 5.1 or later. I forgot to add them to puresize.h since I use GCC 5.2; nobody else has needed them yet, I guess, since nobody with older compilers uses --enable-gcc-warnings. I fixed this with the attached additional patch. --------------020303030602080403050209 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-enable-gcc-warnings-problem-with-older-GCC.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Fix-enable-gcc-warnings-problem-with-older-GCC.patch" RnJvbSAxYjBhYjdkMTMyZjRiNjk1NmIyMDYxYTU1MGU1MzM4MzNiMGJkYzY4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTYXQsIDEwIE9jdCAyMDE1IDExOjU2OjIwIC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gRml4IC0tZW5hYmxlLWdjYy13YXJuaW5ncyBwcm9ibGVtIHdpdGggb2xkZXIgR0NDCgoq IHNyYy9wdXJlc2l6ZS5oOiBBZGQgSU5MSU5FX0hFQURFUl9CRUdJTiwgSU5MSU5FX0hFQURF Ul9FTkQuClRoaXMgaXMgZm9yIGJ1aWxkaW5nIHdpdGggLS1lbmFibGUtZ2NjLXdhcm5pbmdz IHdpdGgKR0NDIDQuNiB0aHJvdWdoIDUuMC4KLS0tCiBzcmMvY29uZl9wb3N0LmggfCA1ICsr KysrCiBzcmMvcHVyZXNpemUuaCAgfCA0ICsrKysKIDIgZmlsZXMgY2hhbmdlZCwgOSBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2NvbmZfcG9zdC5oIGIvc3JjL2NvbmZfcG9z dC5oCmluZGV4IDc4NWU1ZDcuLjJjM2VlZTUgMTAwNjQ0Ci0tLSBhL3NyYy9jb25mX3Bvc3Qu aAorKysgYi9zcmMvY29uZl9wb3N0LmgKQEAgLTMxNiw2ICszMTYsMTEgQEAgZXh0ZXJuIGlu dCBlbWFjc19zZXRlbnZfVFogKGNoYXIgY29uc3QgKik7CiAKICAgIGJlZm9yZSBpbmNsdWRp bmcgY29uZmlnLmggb3IgYW55IG90aGVyIC5oIGZpbGUuCiAgICBPdGhlciAuYyBmaWxlcyBz aG91bGQgbm90IGRlZmluZSBJTkxJTkUuCisgICBGb3IgRW1hY3MsIHRoaXMgaXMgZG9uZSBi eSBoYXZpbmcgZW1hY3MuYyBmaXJzdCAnI2RlZmluZSBJTkxJTkUKKyAgIEVYVEVSTl9JTkxJ TkUnIGFuZCB0aGVuIGluY2x1ZGUgZXZlcnkgLmggZmlsZSB0aGF0IHVzZXMgSU5MSU5FLgor CisgICBUaGUgSU5MSU5FX0hFQURFUl9CRUdJTiBhbmQgSU5MSU5FX0hFQURFUl9FTkQgc3Vw cHJlc3MgYm9ndXMKKyAgIHdhcm5pbmdzIGluIHNvbWUgR0NDIHZlcnNpb25zOyBzZWUgLi4v bTQvZXh0ZXJuLWlubGluZS5tNC4KIAogICAgQzk5IGNvbXBpbGVycyBjb21waWxlIGZ1bmN0 aW9ucyBsaWtlICdpbmNyJyBhcyBDOTktc3R5bGUgZXh0ZXJuCiAgICBpbmxpbmUgZnVuY3Rp b25zLiAgQnVnZ3kgR0NDIGltcGxlbWVudGF0aW9ucyBkbyBzb21ldGhpbmcgc2ltaWxhciB3 aXRoCmRpZmYgLS1naXQgYS9zcmMvcHVyZXNpemUuaCBiL3NyYy9wdXJlc2l6ZS5oCmluZGV4 IGQwOTI2YzYuLmM2MWIzMWYgMTAwNjQ0Ci0tLSBhL3NyYy9wdXJlc2l6ZS5oCisrKyBiL3Ny Yy9wdXJlc2l6ZS5oCkBAIC0xNiw2ICsxNiw4IEBAIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNl bnNlIGZvciBtb3JlIGRldGFpbHMuCiBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5 IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQogYWxvbmcgd2l0aCBHTlUgRW1h Y3MuICBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uICAqLwog CitJTkxJTkVfSEVBREVSX0JFR0lOCisKIC8qIERlZmluZSBQVVJFU0laRSwgdGhlIG51bWJl ciBvZiBieXRlcyBvZiBwdXJlIExpc3AgY29kZSB0byBsZWF2ZSBzcGFjZSBmb3IuCiAKICAg IEF0IG9uZSBwb2ludCwgdGhpcyB3YXMgZGVmaW5lZCBpbiBjb25maWcuaCwgbWVhbmluZyB0 aGF0IGNoYW5naW5nCkBAIC04OCwzICs5MCw1IEBAIENIRUNLX0lNUFVSRSAoTGlzcF9PYmpl Y3Qgb2JqLCB2b2lkICpwdHIpCiAgIGlmIChQVVJFX1AgKHB0cikpCiAgICAgcHVyZV93cml0 ZV9lcnJvciAob2JqKTsKIH0KKworSU5MSU5FX0hFQURFUl9FTkQKLS0gCjIuMS40Cgo= --------------020303030602080403050209--