From: Petr Hracek <phracek@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 20614@debbugs.gnu.org
Subject: bug#20614: Segmentation fault when building on Power8 Little Endian
Date: Mon, 5 Oct 2015 13:23:42 +0200 [thread overview]
Message-ID: <56125DBE.5090305@redhat.com> (raw)
In-Reply-To: <83oagdzmbj.fsf@gnu.org>
On 10/05/2015 11:39 AM, Eli Zaretskii wrote:
>> Cc: 20614@debbugs.gnu.org
>> From: Petr Hracek <phracek@redhat.com>
>> Date: Mon, 5 Oct 2015 11:16:32 +0200
>>
>> (gdb) p old_section_names + NEW_SECTION_H (nn).sh_name
>> $2 = 0x4000128ceb51 <Address 0x4000128ceb51 out of bounds>
> We have a function valid_pointer_p in alloc.c. What happens if you
> use the same code in unexec, before the series of calls to strcmp that
> crash, and only proceed to call strcmp if valid_pointer_p returns a
> positive value?
I have no problem to do it.
I have made a this patch against emacs-24.3
diff --git a/src/unexelf.c b/src/unexelf.c
index d365940..677a1af 100644
--- a/src/unexelf.c
+++ b/src/unexelf.c
@@ -389,6 +389,7 @@ temacs:
#include <unexec.h>
extern void fatal (const char *msgid, ...);
+extern int valid_pointer_p (void *);
#include <sys/types.h>
#include <stdint.h>
@@ -845,8 +846,7 @@ unexec (const char *new_name, const char *old_name)
ElfW (Word) alignment = (NEW_PROGRAM_H (n)).p_align;
if ((OLD_SECTION_H (old_bss_index)).sh_addralign > alignment)
alignment = OLD_SECTION_H (old_bss_index).sh_addralign;
-
-#ifdef __sgi
+#if defined __sgi || defined __powerpc64__
/* According to r02kar@x4u2.desy.de (Karsten Kuenne)
and oliva@gnu.org (Alexandre Oliva), on IRIX 5.2, we
always get "Program segment above .bss" when dumping
@@ -866,8 +866,10 @@ unexec (const char *new_name, const char *old_name)
== round_up (old_bss_addr, alignment)))
break;
}
+#ifndef __powerpc64__
if (n < 0)
fatal ("Couldn't find segment next to .bss in %s\n", old_name, 0);
+#endif
/* Make sure that the size includes any padding before the old .bss
section. */
@@ -1251,6 +1253,12 @@ temacs:
be no harm in that provided that r_offset is always the first
member. */
nn = section.sh_info;
+ valid_pointer_p (old_section_names + NEW_SECTION_H (nn).sh_name);
if (!strcmp (old_section_names + NEW_SECTION_H (nn).sh_name,
".data")
|| !strcmp ((old_section_names + NEW_SECTION_H (nn).sh_name),
".sdata")
But if fails with
/home/phracek/rpmbuild/BUILD/emacs-24.3/src/unexelf.c:1263: undefined
reference to `valid_pointer_p'
collect2: error: ld returned 1 exit status
make[2]: *** [temacs] Error 1
make[2]: Leaving directory `/home/phracek/rpmbuild/BUILD/emacs-24.3/src'
make[1]: *** [src] Error 2
make[1]: Leaving directory `/home/phracek/rpmbuild/BUILD/emacs-24.3'
make: *** [bootstrap] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.QoDw34 (%build)
--
Petr Hracek
Software Engineer
Developer Experience
Red Hat, Inc
Mob: +420777056169
email: phracek@redhat.com
next prev parent reply other threads:[~2015-10-05 11:23 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 7:56 bug#20614: Segmentation fault when building on Power8 Little Endian Petr Hracek
2015-05-20 14:45 ` Eli Zaretskii
2015-05-20 16:12 ` Glenn Morris
2015-05-21 12:55 ` Petr Hracek
2015-07-13 11:27 ` Petr Hracek
2015-07-13 13:16 ` Andreas Schwab
2015-07-14 7:52 ` Petr Hracek
2015-07-14 8:14 ` Andreas Schwab
2015-09-16 11:28 ` Petr Hracek
2015-09-22 10:17 ` Petr Hracek
2015-09-23 8:06 ` Petr Hracek
2015-09-23 9:34 ` Eli Zaretskii
2015-09-23 11:00 ` Petr Hracek
2015-09-23 11:14 ` Eli Zaretskii
2015-09-23 12:11 ` Petr Hracek
2015-09-23 12:23 ` Eli Zaretskii
2015-09-24 11:04 ` Petr Hracek
2015-09-24 15:32 ` Eli Zaretskii
2015-09-24 17:56 ` Petr Hracek
2015-09-26 7:58 ` Eli Zaretskii
2015-09-30 10:39 ` Petr Hracek
2015-10-01 7:43 ` Eli Zaretskii
2015-10-01 8:46 ` Petr Hracek
2015-10-01 11:44 ` Petr Hracek
2015-10-01 11:53 ` Petr Hracek
2015-10-01 12:22 ` Eli Zaretskii
2015-10-01 14:05 ` Petr Hracek
2015-10-01 16:01 ` Eli Zaretskii
2015-10-02 8:36 ` Petr Hracek
2015-10-02 8:49 ` Eli Zaretskii
2015-10-02 12:58 ` Petr Hracek
2015-10-02 13:46 ` Eli Zaretskii
2015-10-05 7:40 ` Petr Hracek
2015-10-05 8:27 ` Eli Zaretskii
2015-10-05 9:16 ` Petr Hracek
2015-10-05 9:39 ` Eli Zaretskii
2015-10-05 11:23 ` Petr Hracek [this message]
2015-10-05 11:40 ` Eli Zaretskii
2015-10-05 14:07 ` Petr Hracek
2015-10-05 16:52 ` Eli Zaretskii
2015-10-06 8:41 ` Petr Hracek
2015-10-06 11:52 ` Petr Hracek
2015-10-06 14:55 ` Eli Zaretskii
2015-10-07 8:17 ` Petr Hracek
2015-10-07 10:56 ` YAMAMOTO Mitsuharu
2015-10-07 12:26 ` Petr Hracek
2015-10-08 0:54 ` YAMAMOTO Mitsuharu
2015-10-08 13:27 ` Jaromir Capik
2015-10-10 1:40 ` YAMAMOTO Mitsuharu
2015-10-10 15:44 ` Andreas Schwab
2015-10-13 7:30 ` Petr Hracek
2015-10-13 8:30 ` Andreas Schwab
2015-10-16 15:24 ` Jaromir Capik
2015-10-19 7:20 ` Andreas Schwab
2015-09-23 12:10 ` Petr Hracek
2015-09-23 12:21 ` Eli Zaretskii
2015-09-23 13:10 ` Petr Hracek
2015-09-23 13:38 ` Petr Hracek
2015-09-23 13:57 ` Eli Zaretskii
2015-09-23 17:25 ` Glenn Morris
2015-09-23 17:47 ` Glenn Morris
2015-09-29 8:15 ` Florian Weimer
2015-07-13 12:17 ` bug#20614: Segmentation fault when building on Power8 Little Endian (ppc64le) Petr Hracek
2015-11-17 1:59 ` bug#20614: alignment problem with recent Emacs unexelf.c changes Paul Eggert
2015-11-17 9:03 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56125DBE.5090305@redhat.com \
--to=phracek@redhat.com \
--cc=20614@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.