all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stephen.berman@gmx.net, emacs-devel@gnu.org
Subject: Re: Compilation warnings in mouse.el
Date: Wed, 13 Jul 2016 17:41:30 +0300	[thread overview]
Message-ID: <56011594-4e83-d357-60fb-022da78c3260@yandex.ru> (raw)
In-Reply-To: <83k2gpa9w3.fsf@gnu.org>

On 07/13/2016 05:30 PM, Eli Zaretskii wrote:

> But if each defcustom has its :group, then the need for consistency is
> no longer a requirement, is it?

The need for consistency is always there when one is writing code.

>> Speaking of personal preference, however, I'd rather using the `mouse'
>> group didn't work, in the absence of a defgroup somewhere.
>
> If we can do something to that effect, I don't think I will object.

We could start with a warning in Emacs 26, and make it so in 28-ish, maybe.

>> How would removing a defcustom, or merely adding one, lead to a bug?
>
> Well, not bug, a compilation warning that suddenly appears out of
> nowhere for code that was there for a long time.

For new code, AFAIU. Not for code that has been there for a while.

> AFAIU, extant defcustoms could start causing warnings, given some
> changes in other defcustom's.  Am I mistaken?

I believe so.

> In short, I think having one defcustom depend on another is bad for
> maintenance.

It would be bad, if it were so. defcustom depend on defgroup.



  reply	other threads:[~2016-07-13 14:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11 14:23 Compilation warnings in mouse.el Eli Zaretskii
2016-07-11 21:55 ` Stephen Berman
2016-07-12  5:04   ` Eli Zaretskii
2016-07-12  8:45     ` Stephen Berman
2016-07-12 22:40     ` John Wiegley
2016-07-12 22:58       ` Stefan Monnier
2016-07-13  9:28         ` Joost Kremers
2016-07-13 12:45           ` Stefan Monnier
2016-07-13 14:08             ` Drew Adams
2016-07-13 14:31         ` Eli Zaretskii
2016-07-13 15:12           ` Stefan Monnier
2016-07-13 15:22             ` Drew Adams
2016-07-13 15:37               ` Stefan Monnier
2016-07-13 16:07                 ` Drew Adams
2016-07-13 15:36             ` Eli Zaretskii
2016-07-13 15:42               ` Stefan Monnier
2016-07-13 16:07                 ` Drew Adams
2016-07-13 16:13                 ` Eli Zaretskii
2016-07-13 16:42                   ` Stefan Monnier
2016-07-12 22:56     ` Dmitry Gutov
2016-07-13 14:30       ` Eli Zaretskii
2016-07-13 14:41         ` Dmitry Gutov [this message]
     [not found] <<8360scdzik.fsf@gnu.org>
     [not found] ` <<87zipnzvo4.fsf@gmx.net>
     [not found]   ` <<8337nfcupy.fsf@gnu.org>
2016-07-12 14:04     ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56011594-4e83-d357-60fb-022da78c3260@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.