From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Commit header lines (was: git history tracking across renames (and emacs support)) Date: Sat, 14 Jul 2018 11:09:27 -0500 Message-ID: <55bb3a0b-e948-9e5d-8332-bed47b913026@cs.ucla.edu> References: <87ind6l2tt.fsf@lifelogs.com> <877etklvsa.fsf@lifelogs.com> <83y3m0pv8u.fsf@gnu.org> <86608msw0h.fsf@dod.no> <838tdiet25.fsf@gnu.org> <87y3li4vh7.fsf@telefonica.net> <87efnan46u.fsf@linux-m68k.org> <86wp12qtgo.fsf@dod.no> <83tvw6chqv.fsf@gnu.org> <86shbprix7.fsf_-_@dod.no> <838t6jgl1k.fsf@gnu.org> <601m6cc6.fsf@lifelogs.com> <83o9fefnv9.fsf@gnu.org> <83d0vtfx4f.fsf@gnu.org> <83o9fce4np.fsf@gnu.org> <8336wneemw.fsf@gnu.org> <907edf27-ed0c-5166-88ea-c3db9d9d7f74@cs.ucla.edu> <83pnzqb8wl.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1531584459 7039 195.159.176.226 (14 Jul 2018 16:07:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Jul 2018 16:07:39 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: emacs-devel@gnu.org To: Eli Zaretskii , rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 14 18:07:34 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1feN52-0001j5-0M for ged-emacs-devel@m.gmane.org; Sat, 14 Jul 2018 18:07:32 +0200 Original-Received: from localhost ([::1]:41886 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1feN78-00037n-Sm for ged-emacs-devel@m.gmane.org; Sat, 14 Jul 2018 12:09:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1feN72-00033t-C8 for emacs-devel@gnu.org; Sat, 14 Jul 2018 12:09:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1feN71-0005N3-Ay for emacs-devel@gnu.org; Sat, 14 Jul 2018 12:09:36 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40142) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1feN6x-0005HT-GQ; Sat, 14 Jul 2018 12:09:31 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B53A9160564; Sat, 14 Jul 2018 09:09:29 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id cPd8ooa8ikLF; Sat, 14 Jul 2018 09:09:29 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id F1A5A1605BB; Sat, 14 Jul 2018 09:09:28 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ht8sI0LJE-IE; Sat, 14 Jul 2018 09:09:28 -0700 (PDT) Original-Received: from [192.168.0.8] (ip72-206-6-38.fv.ks.cox.net [72.206.6.38]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 95D50160564; Sat, 14 Jul 2018 09:09:28 -0700 (PDT) In-Reply-To: <83pnzqb8wl.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227406 Archived-At: On 07/14/2018 01:58 AM, Eli Zaretskii wrote: > There are header lines that don't > add any information to the log message, in many cases they are just > the first entry slightly rephrased. If a summary line is a shorter version of the main text, that's a good thing. It's like a good title for a news article or a research paper: it restates the main text briefly, and there is real value in that. If a summary line is merely a copy of the first sentence of the log, then of course you're right: why bother? Just say it once, in the summary. Again, this is like an article or paper. > In other cases, they say > something uninformative like "Minor copyedits SOMEWHERE". If the copyedits truly are minor those are OK. The main point of one-line summaries is to let readers quickly see which changes are relevant to their concerns. For example the most recent commit using that form, "Minor copyedits in Emacs manual in macos.texi", is OK; unless I'm interested in editing macos.texi I can quickly skip over that commit. If the copyedits aren't truly minor then of course that would be a problem, as would be any incorrect summary line. > And in > many/most of those cases I see no better way to phrase the header line > that would fit into 65 characters. If it's "Minor copyedits in Emacs manual in macos.texi" then we're doing OK already; I wouldn't worry about rephrasing that one, anyway. By the way, the usual suggested length limit for summary lines is 50 characters, not 65.