From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: xref-collect-references picks wrong search backend Date: Fri, 11 Sep 2015 04:12:13 +0300 Message-ID: <55F22A6D.10905@yandex.ru> References: <86fv2m1dwa.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1441933980 5913 80.91.229.3 (11 Sep 2015 01:13:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Sep 2015 01:13:00 +0000 (UTC) To: Stephen Leake , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 11 03:12:51 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZaCtP-0004lT-F1 for ged-emacs-devel@m.gmane.org; Fri, 11 Sep 2015 03:12:43 +0200 Original-Received: from localhost ([::1]:53344 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaCtO-00080Y-RG for ged-emacs-devel@m.gmane.org; Thu, 10 Sep 2015 21:12:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaCtC-00080I-8n for emacs-devel@gnu.org; Thu, 10 Sep 2015 21:12:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZaCt9-0003DS-28 for emacs-devel@gnu.org; Thu, 10 Sep 2015 21:12:30 -0400 Original-Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:37419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaCt8-0003DE-Ru for emacs-devel@gnu.org; Thu, 10 Sep 2015 21:12:27 -0400 Original-Received: by wicfx3 with SMTP id fx3so41406615wic.0 for ; Thu, 10 Sep 2015 18:12:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=tlB/A6y1PSRt5eC03bKbo1W5urCp19j2ANgcC0aJZ2k=; b=wJ1v6tJtXX7MUwtxr/lK2xyBM0O3XimAcjMLndKm/EU2sFBDlj3W0Vgwn49TK1G2A7 2LiuOBoFCLlZLFRriM7vGiZw86eKxHaser5iJSyiJg5k5P2DmzaxzwaC3s3tDAwCfd0Z NmI7ogqT783aGD7IuEo0vT9sscWI9qSojWrcP4Lli7JJyaEumje7p0goAUx0bhsulUkt cktutd1LzlVprO1eFj5DjCLMGPGPpbns18PiMjewChhe2PJM8yvhgAwNHiY60fU9li+W NcMrfV7VCryaoDi23b2qfHovqYvq1tYR1TGkkwL/VhqfP/qUVnEQGFpmXyF81ufs8I2t gyag== X-Received: by 10.180.85.164 with SMTP id i4mr12092745wiz.54.1441933946091; Thu, 10 Sep 2015 18:12:26 -0700 (PDT) Original-Received: from [10.9.0.103] (nat.webazilla.com. [78.140.128.228]) by smtp.googlemail.com with ESMTPSA id ub7sm6801870wib.17.2015.09.10.18.12.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Sep 2015 18:12:25 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:40.0) Gecko/20100101 Thunderbird/40.0 In-Reply-To: <86fv2m1dwa.fsf@stephe-leake.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189827 Archived-At: On 09/10/2015 06:40 PM, Stephen Leake wrote: > I have run Gnu Global on the Emacs root directory, mostly to find out if > that's useful (so far not, because etags is better, but in other projects > it could be useful). Maybe you should run it in the src/ directory, not the top level one. This way, files outside of it won't try to use GNU Global. > I'm actually using an experimental multi-language project setup that > provides an xref-find-function that calls xref-collect-references > directly for elisp searches, so I suggest the following solution: > > - Add an optional symref-tool arg to xref-collect-references; my > xref-find-function can set that to 'grep for elisp searches. If you'll find that useful, sure. But semantic-symref-find-references-by-name in the default implementation was just a way to get out something working quickly. We might even have to bypass it altogether and always use Grep (in the default implementation), because any problems with semantic-symref (like GTAGS being out of date, or, like in this case, the tagging program skipping whole classes of files) are entirely opaque to the user. > elisp--xref-find-references could also set it to 'grep. Since its definition is pretty much the same as the etags one, I was going to merge them and put in the new "default" backend.