From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] * image.c: Fix compiler warning due to missing const Date: Thu, 10 Sep 2015 11:25:20 -0700 Organization: UCLA Computer Science Department Message-ID: <55F1CB10.4020508@cs.ucla.edu> References: <1441856303-4171-1-git-send-email-mitch.special@gmail.com> <55F152C5.9050306@cs.ucla.edu> <83a8su5loz.fsf@gnu.org> <87r3m6nukz.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050409040606020809080704" X-Trace: ger.gmane.org 1441909634 3761 80.91.229.3 (10 Sep 2015 18:27:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Sep 2015 18:27:14 +0000 (UTC) Cc: emacs-devel@gnu.org To: Mitchel Humpherys , Eli Zaretskii , Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 10 20:26:59 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Za6Yg-0007jg-C0 for ged-emacs-devel@m.gmane.org; Thu, 10 Sep 2015 20:26:54 +0200 Original-Received: from localhost ([::1]:51125 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za6Yf-0004XT-PD for ged-emacs-devel@m.gmane.org; Thu, 10 Sep 2015 14:26:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za6XN-0003Al-6v for emacs-devel@gnu.org; Thu, 10 Sep 2015 14:25:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Za6XM-0004pH-37 for emacs-devel@gnu.org; Thu, 10 Sep 2015 14:25:33 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:39440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za6XH-0004oV-Pl; Thu, 10 Sep 2015 14:25:28 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4618C161071; Thu, 10 Sep 2015 11:25:26 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Ok2dU64RjY3n; Thu, 10 Sep 2015 11:25:24 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8423716106E; Thu, 10 Sep 2015 11:25:24 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id hR9MfjcURZGS; Thu, 10 Sep 2015 11:25:24 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 5AE64161066; Thu, 10 Sep 2015 11:25:24 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 In-Reply-To: <87r3m6nukz.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189817 Archived-At: This is a multi-part message in MIME format. --------------050409040606020809080704 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Mitchel Humpherys wrote: > CONTRIBUTE doesn't mention which mailing list you should send it to Actually, it says to send fixes to bug-gnu-emacs@gnu.org. > it doesn't mention `git send-email' Fixed with the attached patch. Glenn Morris wrote: > Paul Eggert wrote: > >> +git send-email --to=bug-gnu-emacs@gnu.org 0001-DESCRIPTION.patch > > I would like to discourage this usage because when there's more than one > patch in a sequence, it will create a separate report for each. > (http://debbugs.gnu.org/15361) The attached patch changes CONTRIBUTE to suggest git send-email only with single patch files. If we fix the bug-reporting mechanism to handle multiple patch files, we can update CONTRIBUTE accordingly. Eli Zaretskii wrote: > I don't really know why we keep maintaining admin/git-workflow. I don't know either. Anyway, the attached patch tries to lessen the maintenance burden by having git-worflow defer to CONTRIBUTE here. --------------050409040606020809080704 Content-Type: text/x-diff; name="0001-CONTRIBUTE-Move-send-email-here-from-git-workflow.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-CONTRIBUTE-Move-send-email-here-from-git-workflow.patch" >From fa7f8cfe28a7b5bcca607f316d16322af17d206e Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 10 Sep 2015 11:21:17 -0700 Subject: [PATCH] * CONTRIBUTE: Move send-email here from git-workflow. --- CONTRIBUTE | 4 +++- admin/notes/git-workflow | 14 ++------------ 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/CONTRIBUTE b/CONTRIBUTE index 7e697dd..5821ee5 100644 --- a/CONTRIBUTE +++ b/CONTRIBUTE @@ -234,7 +234,9 @@ by following links from http://savannah.gnu.org/mail/?group=emacs . To email a patch you can use a shell command like 'git format-patch -1' to create a file, and then attach the file to your email. This nicely -packages the patch's commit message and changes. +packages the patch's commit message and changes. To send just one +such patch without additional remarks, you can use a command like +'git send-email --to=bug-gnu-emacs@gnu.org 0001-DESCRIPTION.patch'. ** Document your changes. diff --git a/admin/notes/git-workflow b/admin/notes/git-workflow index 40dfa6b..92dc791 100644 --- a/admin/notes/git-workflow +++ b/admin/notes/git-workflow @@ -50,18 +50,8 @@ Sending patches =============== If you lack push access or would like feedback before pushing a patch, -you can send a patch file as a bug report. After committing your -change locally, do: - -git format-patch -1 - -This creates a file 0001-DESCRIPTION.patch containing the patch, where -DESCRIPTION comes from the first line of your patch's commit message. -You can attach the patch file to email that you send to -bug-gnu-emacs@gnu.org. You can also configure git to email patches -directly (see ) and do: - -git send-email --to=bug-gnu-emacs@gnu.org 0001-DESCRIPTION.patch +you commit your change locally and then send a patch file as a bug report +as described in ../../CONTRIBUTE. Backporting to emacs-24 -- 2.1.0 --------------050409040606020809080704--