Re: [PATCH] * image.c: Fix compiler warning due to missing const

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]

Mitchel Humpherys wrote:

> CONTRIBUTE doesn't mention which mailing list you should send it to

Actually, it says to send fixes to bug-gnu-emacs@gnu.org.

> it doesn't mention `git send-email'

Fixed with the attached patch.

Glenn Morris wrote:
 > Paul Eggert wrote:
 >
 >> +git send-email --to=bug-gnu-emacs@gnu.org 0001-DESCRIPTION.patch
 >
 > I would like to discourage this usage because when there's more than one
 > patch in a sequence, it will create a separate report for each.
 > (http://debbugs.gnu.org/15361)

The attached patch changes CONTRIBUTE to suggest git send-email only with single 
patch files.  If we fix the bug-reporting mechanism to handle multiple patch 
files, we can update CONTRIBUTE accordingly.

Eli Zaretskii wrote:
 > I don't really know why we keep maintaining admin/git-workflow.

I don't know either.  Anyway, the attached patch tries to lessen the maintenance 
burden by having git-worflow defer to CONTRIBUTE here.

[-- Attachment #2: 0001-CONTRIBUTE-Move-send-email-here-from-git-workflow.patch --]
[-- Type: text/x-diff, Size: 1927 bytes --]

From fa7f8cfe28a7b5bcca607f316d16322af17d206e Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 10 Sep 2015 11:21:17 -0700
Subject: [PATCH] * CONTRIBUTE: Move send-email here from git-workflow.

---
 CONTRIBUTE               |  4 +++-
 admin/notes/git-workflow | 14 ++------------
 2 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/CONTRIBUTE b/CONTRIBUTE
index 7e697dd..5821ee5 100644
--- a/CONTRIBUTE
+++ b/CONTRIBUTE
@@ -234,7 +234,9 @@ by following links from http://savannah.gnu.org/mail/?group=emacs .
 
 To email a patch you can use a shell command like 'git format-patch -1'
 to create a file, and then attach the file to your email.  This nicely
-packages the patch's commit message and changes.
+packages the patch's commit message and changes.  To send just one
+such patch without additional remarks, you can use a command like
+'git send-email --to=bug-gnu-emacs@gnu.org 0001-DESCRIPTION.patch'.
 
 ** Document your changes.
 
diff --git a/admin/notes/git-workflow b/admin/notes/git-workflow
index 40dfa6b..92dc791 100644
--- a/admin/notes/git-workflow
+++ b/admin/notes/git-workflow
@@ -50,18 +50,8 @@ Sending patches
 ===============
 
 If you lack push access or would like feedback before pushing a patch,
-you can send a patch file as a bug report.  After committing your
-change locally, do:
-
-git format-patch -1
-
-This creates a file 0001-DESCRIPTION.patch containing the patch, where
-DESCRIPTION comes from the first line of your patch's commit message.
-You can attach the patch file to email that you send to
-bug-gnu-emacs@gnu.org.  You can also configure git to email patches
-directly (see <http://git-scm.com/docs/git-send-email>) and do:
-
-git send-email --to=bug-gnu-emacs@gnu.org 0001-DESCRIPTION.patch
+you commit your change locally and then send a patch file as a bug report
+as described in ../../CONTRIBUTE.
 
 
 Backporting to emacs-24
-- 
2.1.0