From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master b6c8cb5: Port movemail to RHEL 6 with --enable-gcc-warnings Date: Wed, 9 Sep 2015 15:40:44 -0400 Message-ID: <55F08B3C.2000802@cornell.edu> References: <20150909103629.22141.78303@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1441827680 23115 80.91.229.3 (9 Sep 2015 19:41:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Sep 2015 19:41:20 +0000 (UTC) To: emacs-devel@gnu.org, Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 09 21:41:06 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZZlEn-0000mi-PI for ged-emacs-devel@m.gmane.org; Wed, 09 Sep 2015 21:40:57 +0200 Original-Received: from localhost ([::1]:45231 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZlEn-0002ja-1e for ged-emacs-devel@m.gmane.org; Wed, 09 Sep 2015 15:40:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZlEj-0002jT-PH for emacs-devel@gnu.org; Wed, 09 Sep 2015 15:40:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZlEe-0008QP-Pg for emacs-devel@gnu.org; Wed, 09 Sep 2015 15:40:53 -0400 Original-Received: from limerock01.mail.cornell.edu ([128.84.13.241]:49290) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZlEe-0008Nv-Lb for emacs-devel@gnu.org; Wed, 09 Sep 2015 15:40:48 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id t89JegYX024696; Wed, 9 Sep 2015 15:40:42 -0400 Original-Received: from [192.168.1.3] (cpe-67-249-176-138.twcny.res.rr.com [67.249.176.138]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id t89Jefmm014445 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 9 Sep 2015 15:40:42 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.84.13.241 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189774 Archived-At: On 9/9/2015 6:36 AM, Paul Eggert wrote: > branch: master > commit b6c8cb57fc23f46d431ffc372abff9d8b2ed486c > Author: Paul Eggert > Commit: Paul Eggert > > Port movemail to RHEL 6 with --enable-gcc-warnings > > * lib-src/movemail.c (main): Declare local only if needed. > --- > lib-src/movemail.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib-src/movemail.c b/lib-src/movemail.c > index 231bc22..c25db62 100644 > --- a/lib-src/movemail.c > +++ b/lib-src/movemail.c > @@ -174,8 +174,6 @@ main (int argc, char **argv) > int desc; > #endif /* not MAIL_USE_SYSTEM_LOCK */ > > - char *spool_name = 0; > - > #ifdef MAIL_USE_POP > bool pop_reverse_order = false; > # define ARGSTR "pr" > @@ -247,6 +245,10 @@ main (int argc, char **argv) > > char *lockname = 0; > > +#ifdef MAIL_USE_MAILLOCK > + char *spool_name = 0; > +#endif > + > #ifndef MAIL_USE_SYSTEM_LOCK > #ifdef MAIL_USE_MAILLOCK > spool_name = mail_spool_name (inname); This isn't quite right. See movemail.c:256, where spool_name is used without having been declared. Ken