Re: [Emacs-diffs] master b6c8cb5: Port movemail to RHEL 6 with --enable-gcc-warnings

[Ken Brown <kbrown@cornell.edu>]

On 9/9/2015 6:36 AM, Paul Eggert wrote:
> branch: master
> commit b6c8cb57fc23f46d431ffc372abff9d8b2ed486c
> Author: Paul Eggert <eggert@cs.ucla.edu>
> Commit: Paul Eggert <eggert@cs.ucla.edu>
>
>      Port movemail to RHEL 6 with --enable-gcc-warnings
>
>      * lib-src/movemail.c (main): Declare local only if needed.
> ---
>   lib-src/movemail.c |    6 ++++--
>   1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib-src/movemail.c b/lib-src/movemail.c
> index 231bc22..c25db62 100644
> --- a/lib-src/movemail.c
> +++ b/lib-src/movemail.c
> @@ -174,8 +174,6 @@ main (int argc, char **argv)
>     int desc;
>   #endif /* not MAIL_USE_SYSTEM_LOCK */
>
> -  char *spool_name = 0;
> -
>   #ifdef MAIL_USE_POP
>     bool pop_reverse_order = false;
>   # define ARGSTR "pr"
> @@ -247,6 +245,10 @@ main (int argc, char **argv)
>
>     char *lockname = 0;
>
> +#ifdef MAIL_USE_MAILLOCK
> +  char *spool_name = 0;
> +#endif
> +
>   #ifndef MAIL_USE_SYSTEM_LOCK
>   #ifdef MAIL_USE_MAILLOCK
>     spool_name = mail_spool_name (inname);

This isn't quite right.  See movemail.c:256, where spool_name is used 
without having been declared.

Ken