From: "Mattias Engdegård" <mattiase@acm.org>
To: Emacs developers <emacs-devel@gnu.org>, Paul Eggert <eggert@cs.ucla.edu>
Subject: Unbreak build on macOS
Date: Tue, 9 Jul 2019 13:41:57 +0200 [thread overview]
Message-ID: <55EE5431-8EC2-4562-8F75-33151A0F086E@acm.org> (raw)
On macOS, lib/fcntl.h does
# define open rpl_open
which now (f8ab90839f) gets included in src/font.c and breaks the line
font_object = driver_list->driver->open (f, entity, psize);
As an immediate remedy, I added
#undef open
to src/font.c.
In general, '#define open' is a rather unpleasant thing to do. Can we at least assume enough of C99 to do
#define open(...) rpl_open (__VA_ARGS__)
instead? That would permit font.c to use bracketing as an alternative countermeasure.
next reply other threads:[~2019-07-09 11:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 11:41 Mattias Engdegård [this message]
2019-07-09 13:51 ` Unbreak build on macOS Richard Copley
2019-07-09 14:46 ` Mattias Engdegård
2019-07-09 15:29 ` Eli Zaretskii
2019-07-09 15:44 ` Mattias Engdegård
2019-07-09 16:08 ` Eli Zaretskii
2019-07-09 15:17 ` Eli Zaretskii
2019-07-09 15:30 ` Mattias Engdegård
2019-07-09 16:19 ` Eli Zaretskii
2019-07-09 16:49 ` Mattias Engdegård
2019-07-09 17:09 ` Eli Zaretskii
2019-07-09 20:20 ` Richard Copley
2019-07-09 15:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EE5431-8EC2-4562-8F75-33151A0F086E@acm.org \
--to=mattiase@acm.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.