From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#21415: 25.0.50; Emacs Trunk -- pixelwise width/height for x-create-frame Date: Sun, 06 Sep 2015 21:26:54 +0200 Message-ID: <55EC937E.5020302@gmx.at> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040306040608030209000704" X-Trace: ger.gmane.org 1441567709 26982 80.91.229.3 (6 Sep 2015 19:28:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 6 Sep 2015 19:28:29 +0000 (UTC) Cc: 21415@debbugs.gnu.org To: Keith David Bershatsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 06 21:28:17 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZYfbr-0006hN-V1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Sep 2015 21:28:16 +0200 Original-Received: from localhost ([::1]:50293 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYfbm-0000qE-AH for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Sep 2015 15:28:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYfbi-0000p5-9x for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2015 15:28:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYfbe-0005Ge-Sb for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2015 15:28:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58722) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYfbe-0005GE-PQ for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2015 15:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZYfbe-0005bJ-GL for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2015 15:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Sep 2015 19:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21415 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21415-submit@debbugs.gnu.org id=B21415.144156763021448 (code B ref 21415); Sun, 06 Sep 2015 19:28:02 +0000 Original-Received: (at 21415) by debbugs.gnu.org; 6 Sep 2015 19:27:10 +0000 Original-Received: from localhost ([127.0.0.1]:50928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZYfao-0005Zs-00 for submit@debbugs.gnu.org; Sun, 06 Sep 2015 15:27:10 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:55156) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZYfal-0005Zj-4Q for 21415@debbugs.gnu.org; Sun, 06 Sep 2015 15:27:07 -0400 Original-Received: from [88.117.50.54] ([88.117.50.54]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MF4eJ-1ZSuyQ0wLz-00GIn7; Sun, 06 Sep 2015 21:27:05 +0200 In-Reply-To: X-Provags-ID: V03:K0:9sYO4STY+l4NOLdBMoxl+1kAQ9IHmTy71W6FVuNBYJqxjEqcOBQ Od4j7Owwsta4p7jOCT70ftMAwCphB7b/QoC5iZG5oZf2QJnkP+HqGqJu+TqCB9PKO3UEz9W V6lsZVmABY/337sm+ugWHzk70wt46fyOQ1ZKq+hH7b1/iH13v6dCTqkZJX3blqAu5ZL3sx3 S2f1422ihTadLcZFo+rFA== X-UI-Out-Filterresults: notjunk:1;V01:K0:CgNGJuIvYLM=:ej/bdiZ7ZvpFDFr0OHEcYM 0sj02JPNZMpyzYH87ooAarpE2ZowLgYTY+QzBWU2zYojnXP8tk8nR0HTwoYk7qOX8NQV7SexL /6OVxcHFJA6k+ti5keHZ4e3A39ytdNn716NYLZGfkKVoTxNKq2uWS0AGvyECr1MnA9bWUktk9 sKMzoaikvGHEzbKh94LINIoE4wklROmukG9X80YwO7bv12uTc0H1JrTPzBecrn7EUSPZEn9uQ REjuIRLxTUTjsphOW/riY+QPwvORGa4GT+CnZso61dOt9Jg6/A8kapXVmdnR+RQlxLXYgikGA OITfvjpBG8DCgE06vja8oObcBU8nxJSoW/7LgJ8Ylb6zsGo/xmpRfnmzg+cgoVk2N2Rkm/Hh3 c88zAcPbI+Dk78pVcDwJva45IJjwT65+qvUyulqDTIZ2Pyat2g+99fRPpKWEKFn3f8nNCTCtp bCJwNGsguBU9CK6+d8nPdHNprjnDZUPTpG63FloVcKqjIJZGLUxsl/0iOXCwRlA+5BNgKekQf 5oG5TpCRlEyXgUJ4HfqnumQa7olEjdKOIAaQtMW4mSWknVViS7a3VRMDDxqZryvtP8aIrvuie Vmp23kbyHLgKpryK5I9xdO2iXav/jBgl2D8l3wn+AAjur0L7toVhHB1e7jHr1mKWfVHREdjpG 2K7ekQa9pQarQ3w04hcwUd5pmnz3M6Kfxh+oWSQxjugcGicer92BKgp4jS8ffVd61im/qHcLi QV5MVNcfhI47YcLJ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106193 Archived-At: This is a multi-part message in MIME format. --------------040306040608030209000704 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > With respect to the patch, I believe it was applied successfully -- I selected the option "y". > > SHELL-PROMPT: emacs HOME$ patch -p1 < frame.c.diff > > patching file src/frame.c > > Reversed (or previously applied) patch detected! Assume -R? [n] y Strange. Are you sure you had a pristine frame.c? What does git diff give for your Emacs tree? > Hunk #3 succeeded at 4840 (offset 9 lines). If you have no private changes in frame.c do a C-x v u in a buffer showing frame.c and afterwards do git apply frame.c.diff followed by make. > I believe that `x-create-frame' is expecting an integer: > > Debugger entered--Lisp error: (wrong-type-argument integerp 400.0) That would indicate that my patch was not applied or you did not build Emacs correctly afterwards. In any case I attach the patch again. martin --------------040306040608030209000704 Content-Type: text/plain; charset=windows-1252; name="frame.c.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="frame.c.diff" diff --git a/src/frame.c b/src/frame.c index 4a526e2..bac2b24 100644 --- a/src/frame.c +++ b/src/frame.c @@ -537,6 +537,8 @@ adjust_frame_size (struct frame *f, int new_width, int new_height, int inhibit, } #endif } + else if (new_cols != old_cols) + call2 (Qwindow_pixel_to_total, frame, Qt); if (new_windows_height != old_windows_height /* When the top margin has changed we have to recalculate the top @@ -551,6 +553,8 @@ adjust_frame_size (struct frame *f, int new_width, int new_height, int inhibit, if ((FRAME_TERMCAP_P (f) && !pretend) || FRAME_MSDOS_P (f)) FrameRows (FRAME_TTY (f)) = new_lines + FRAME_TOP_MARGIN (f); } + else if (new_lines != old_lines) + call2 (Qwindow_pixel_to_total, frame, Qnil); frame_size_history_add (f, Qadjust_frame_size_3, new_text_width, new_text_height, @@ -4831,6 +4835,7 @@ syms_of_frame (void) DEFSYM (Qframep, "framep"); DEFSYM (Qframe_live_p, "frame-live-p"); DEFSYM (Qframe_windows_min_size, "frame-windows-min-size"); + DEFSYM (Qwindow_pixel_to_total, "window--pixel-to-total"); DEFSYM (Qexplicit_name, "explicit-name"); DEFSYM (Qheight, "height"); DEFSYM (Qicon, "icon"); --------------040306040608030209000704--