From: martin rudalics <rudalics@gmx.at>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: 21415@debbugs.gnu.org
Subject: bug#21415: 25.0.50; Emacs Trunk -- pixelwise width/height for x-create-frame
Date: Sun, 06 Sep 2015 21:26:54 +0200 [thread overview]
Message-ID: <55EC937E.5020302@gmx.at> (raw)
In-Reply-To: <m2d1xvpiu9.wl%esq@lawlist.com>
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
> With respect to the patch, I believe it was applied successfully -- I selected the option "y".
>
> SHELL-PROMPT: emacs HOME$ patch -p1 < frame.c.diff
>
> patching file src/frame.c
>
> Reversed (or previously applied) patch detected! Assume -R? [n] y
Strange. Are you sure you had a pristine frame.c? What does git diff
give for your Emacs tree?
> Hunk #3 succeeded at 4840 (offset 9 lines).
If you have no private changes in frame.c do a C-x v u in a buffer
showing frame.c and afterwards do
git apply frame.c.diff
followed by make.
> I believe that `x-create-frame' is expecting an integer:
>
> Debugger entered--Lisp error: (wrong-type-argument integerp 400.0)
That would indicate that my patch was not applied or you did not build
Emacs correctly afterwards. In any case I attach the patch again.
martin
[-- Attachment #2: frame.c.diff --]
[-- Type: text/plain, Size: 1191 bytes --]
diff --git a/src/frame.c b/src/frame.c
index 4a526e2..bac2b24 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -537,6 +537,8 @@ adjust_frame_size (struct frame *f, int new_width, int new_height, int inhibit,
}
#endif
}
+ else if (new_cols != old_cols)
+ call2 (Qwindow_pixel_to_total, frame, Qt);
if (new_windows_height != old_windows_height
/* When the top margin has changed we have to recalculate the top
@@ -551,6 +553,8 @@ adjust_frame_size (struct frame *f, int new_width, int new_height, int inhibit,
if ((FRAME_TERMCAP_P (f) && !pretend) || FRAME_MSDOS_P (f))
FrameRows (FRAME_TTY (f)) = new_lines + FRAME_TOP_MARGIN (f);
}
+ else if (new_lines != old_lines)
+ call2 (Qwindow_pixel_to_total, frame, Qnil);
frame_size_history_add
(f, Qadjust_frame_size_3, new_text_width, new_text_height,
@@ -4831,6 +4835,7 @@ syms_of_frame (void)
DEFSYM (Qframep, "framep");
DEFSYM (Qframe_live_p, "frame-live-p");
DEFSYM (Qframe_windows_min_size, "frame-windows-min-size");
+ DEFSYM (Qwindow_pixel_to_total, "window--pixel-to-total");
DEFSYM (Qexplicit_name, "explicit-name");
DEFSYM (Qheight, "height");
DEFSYM (Qicon, "icon");
next prev parent reply other threads:[~2015-09-06 19:26 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 17:41 bug#21415: 25.0.50; Emacs Trunk -- pixelwise width/height for x-create-frame Keith David Bershatsky
2015-09-04 19:17 ` martin rudalics
2015-09-05 0:31 ` Keith David Bershatsky
2015-09-05 9:59 ` martin rudalics
2015-09-06 17:18 ` Keith David Bershatsky
2015-09-06 19:26 ` martin rudalics [this message]
2015-09-06 17:56 ` Keith David Bershatsky
2015-09-06 19:26 ` martin rudalics
2015-09-06 22:01 ` Keith David Bershatsky
2015-09-07 7:05 ` martin rudalics
2015-09-07 17:53 ` Keith David Bershatsky
2015-09-08 8:29 ` martin rudalics
2015-09-08 16:13 ` Keith David Bershatsky
2015-09-08 19:22 ` martin rudalics
2015-09-09 0:38 ` Keith David Bershatsky
2015-09-09 6:27 ` martin rudalics
2015-09-09 14:30 ` Keith David Bershatsky
2015-09-09 15:53 ` martin rudalics
2015-09-09 16:26 ` Keith David Bershatsky
2015-09-09 17:11 ` martin rudalics
2015-09-10 0:46 ` Keith David Bershatsky
2015-09-10 6:57 ` martin rudalics
2015-09-10 18:39 ` Keith David Bershatsky
2015-09-12 11:11 ` martin rudalics
2015-09-12 19:57 ` Anders Lindgren
2015-09-13 9:02 ` martin rudalics
2015-09-12 11:12 ` martin rudalics
2015-09-12 18:11 ` Keith David Bershatsky
2015-09-12 23:09 ` Keith David Bershatsky
2015-09-13 9:02 ` martin rudalics
2015-09-12 23:13 ` Keith David Bershatsky
2015-09-13 7:10 ` Anders Lindgren
2015-09-13 9:02 ` martin rudalics
2015-09-13 16:17 ` Keith David Bershatsky
2015-09-13 18:01 ` martin rudalics
[not found] ` <CABr8ebYkM02NHh9BeU8tNfw0=eMtqJfQALAhN17VfOQtzfq9CQ@mail.gmail.com>
2015-09-13 20:21 ` bug#21415: Fwd: " Anders Lindgren
[not found] ` <55F6860D.9060503@gmx.at>
2015-09-14 9:37 ` Anders Lindgren
2015-09-14 13:39 ` martin rudalics
2015-09-14 14:45 ` Anders Lindgren
2015-09-14 17:37 ` martin rudalics
2015-09-14 19:03 ` Anders Lindgren
2015-09-15 8:29 ` martin rudalics
2015-09-19 21:12 ` Anders Lindgren
2015-09-19 22:17 ` martin rudalics
2015-09-20 7:25 ` Anders Lindgren
2015-09-20 8:44 ` martin rudalics
2015-09-20 9:27 ` Anders Lindgren
2015-09-20 9:54 ` martin rudalics
2015-09-20 18:29 ` Anders Lindgren
2015-09-21 9:42 ` martin rudalics
2015-09-13 18:36 ` Keith David Bershatsky
2015-09-14 8:31 ` martin rudalics
2015-09-14 8:32 ` martin rudalics
2015-09-13 18:53 ` Keith David Bershatsky
2015-09-14 15:25 ` Keith David Bershatsky
2015-09-14 17:37 ` martin rudalics
2015-09-20 16:47 ` Keith David Bershatsky
2015-09-20 18:31 ` Anders Lindgren
2015-09-21 9:43 ` martin rudalics
2015-09-21 18:56 ` Anders Lindgren
2015-09-22 6:38 ` martin rudalics
2015-09-22 8:54 ` Anders Lindgren
2015-09-22 9:36 ` martin rudalics
2015-09-27 18:53 ` Anders Lindgren
2015-09-28 6:48 ` martin rudalics
2015-09-28 21:35 ` Anders Lindgren
2015-09-29 7:23 ` martin rudalics
2015-09-29 7:50 ` Eli Zaretskii
2015-09-30 17:54 ` Anders Lindgren
2015-09-30 18:57 ` martin rudalics
2015-09-30 21:29 ` Anders Lindgren
2015-10-02 8:37 ` martin rudalics
2015-10-03 6:16 ` Anders Lindgren
2015-10-03 8:32 ` martin rudalics
2015-09-20 19:14 ` Keith David Bershatsky
2015-09-28 14:32 ` Keith David Bershatsky
2015-09-28 15:31 ` martin rudalics
2015-09-28 17:49 ` Keith David Bershatsky
2015-09-28 18:00 ` martin rudalics
2015-09-28 18:13 ` Keith David Bershatsky
2015-09-29 7:22 ` martin rudalics
2015-09-29 17:09 ` Keith David Bershatsky
2015-09-29 17:14 ` martin rudalics
2015-10-01 6:43 ` Keith David Bershatsky
2015-10-02 8:37 ` martin rudalics
2015-10-03 11:28 ` Andy Moreton
2015-10-03 12:31 ` martin rudalics
2015-10-05 21:02 ` Andy Moreton
2015-10-06 7:57 ` martin rudalics
2015-10-07 3:42 ` Keith David Bershatsky
2015-10-13 10:21 ` martin rudalics
2015-10-13 17:23 ` Keith David Bershatsky
2015-10-13 17:59 ` Anders Lindgren
2015-10-14 8:49 ` martin rudalics
2015-10-14 15:58 ` Keith David Bershatsky
2015-10-14 17:37 ` martin rudalics
2015-10-14 21:53 ` Anders Lindgren
2015-10-15 10:00 ` martin rudalics
2015-10-20 17:20 ` Anders Lindgren
2015-10-21 8:02 ` martin rudalics
2015-10-21 16:07 ` martin rudalics
2015-10-22 14:54 ` Anders Lindgren
2015-10-22 15:35 ` martin rudalics
2015-10-23 9:13 ` Anders Lindgren
2015-10-23 18:00 ` martin rudalics
2015-10-24 15:33 ` Anders Lindgren
2015-10-24 18:57 ` martin rudalics
2015-10-24 21:43 ` Anders Lindgren
2015-10-27 21:42 ` Anders Lindgren
2015-10-28 7:54 ` Anders Lindgren
2015-10-28 9:55 ` martin rudalics
2015-10-28 11:25 ` Anders Lindgren
2015-10-28 19:19 ` martin rudalics
2015-10-29 22:53 ` Anders Lindgren
2015-10-30 7:59 ` martin rudalics
2015-10-30 8:10 ` martin rudalics
2015-10-30 9:00 ` Anders Lindgren
2015-10-30 9:34 ` martin rudalics
2015-10-30 10:18 ` Anders Lindgren
2015-10-28 9:54 ` martin rudalics
2015-10-14 20:34 ` Keith David Bershatsky
2015-10-15 9:59 ` martin rudalics
2015-10-21 1:03 ` Keith David Bershatsky
2015-10-21 2:07 ` Anders Lindgren
2015-10-29 2:47 ` Keith David Bershatsky
2015-11-14 19:42 ` Anders Lindgren
2015-11-01 16:53 ` Keith David Bershatsky
2015-11-01 21:08 ` Anders Lindgren
2015-11-02 5:18 ` Keith David Bershatsky
2015-11-02 20:50 ` Anders Lindgren
2015-11-03 6:29 ` Keith David Bershatsky
2015-11-03 8:54 ` Anders Lindgren
2015-11-04 2:21 ` Keith David Bershatsky
2015-11-04 5:53 ` Anders Lindgren
2015-11-16 3:06 ` Keith David Bershatsky
2015-11-16 9:11 ` Anders Lindgren
2020-09-17 17:53 ` Lars Ingebrigtsen
2015-11-16 3:16 ` Keith David Bershatsky
2015-11-16 7:54 ` Anders Lindgren
2015-11-16 17:25 ` Keith David Bershatsky
2015-11-16 23:52 ` Keith David Bershatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EC937E.5020302@gmx.at \
--to=rudalics@gmx.at \
--cc=21415@debbugs.gnu.org \
--cc=esq@lawlist.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.