bug#21423: 24.5; (package-initialize) added to init.el without (setq package-enable-at-startup nil)

[Phil Sainty <psainty@orcon.net.nz>]

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

package--ensure-init-file inserts (package-initialize) into the user's
init file, but it does not also insert (setq package-enable-at-startup nil),
which means that (according to (emacs) Package Installation) Emacs will
re-initialize the packages post-init:

 > In some circumstances, you may want to load packages explicitly in
 > your init file (usually because some other code in your init file
 > depends on a package).  In that case, your init file should call the
 > function ‘package-initialize’.  It is up to you to ensure that
 > relevant user options, such as ‘package-load-list’ (see below), are
 > set up prior to the ‘package-initialize’ call.  You should also set
 > ‘package-enable-at-startup’ to ‘nil’, to avoid loading the packages
 > again after processing the init file.



[-- Attachment #2: 0001-Disable-package-enable-at-startup-when-forcing-packa.patch --]
[-- Type: text/x-patch, Size: 978 bytes --]

From 297f2d5555ba0efb0afc3412f49d1c728ebb5700 Mon Sep 17 00:00:00 2001
From: Phil Sainty <phil@orcon.net.nz>
Date: Sun, 6 Sep 2015 22:48:40 +1200
Subject: [PATCH] Disable package-enable-at-startup when forcing
 package-initialize

---
 lisp/emacs-lisp/package.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index d4a2f02..baa4ab6 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1856,6 +1856,7 @@ add a call to it along with some explanatory comments."
                ";; installed packages.  Don't delete this line.  If you don't want it,\n"
                ";; just comment it out by adding a semicolon to the start of the line.\n"
                ";; You may delete these explanatory comments.\n"
+               "(setq package-enable-at-startup nil)\n")
                "(package-initialize)\n")
               (unless (looking-at-p "$")
                 (insert "\n"))
-- 
2.1.0