From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#21383: Static revisions in vc-working-revision Date: Thu, 3 Sep 2015 22:24:51 +0300 Message-ID: <55E89E83.6000501@yandex.ru> References: <55E41499.5030501@yandex.ru> <55E5094A.3010108@yandex.ru> <55E59487.1050804@yandex.ru> <55E5CA42.1080005@yandex.ru> <55E5DF1A.9010902@yandex.ru> <55E6D426.10105@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1441308382 3292 80.91.229.3 (3 Sep 2015 19:26:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Sep 2015 19:26:22 +0000 (UTC) Cc: 21383-done@debbugs.gnu.org, Jonathan H To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 03 21:26:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZXa9B-0007w1-B1 for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Sep 2015 21:26:09 +0200 Original-Received: from localhost ([::1]:51334 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXa9B-0005kK-I2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Sep 2015 15:26:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXa97-0005jz-F3 for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2015 15:26:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXa94-0007DE-5P for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2015 15:26:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXa94-0007Ct-1f for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2015 15:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZXa93-0002F8-PK for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2015 15:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Sep 2015 19:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21383 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21383-done@debbugs.gnu.org id=D21383.14413083038549 (code D ref 21383); Thu, 03 Sep 2015 19:26:01 +0000 Original-Received: (at 21383-done) by debbugs.gnu.org; 3 Sep 2015 19:25:03 +0000 Original-Received: from localhost ([127.0.0.1]:47924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZXa86-0002Dp-BB for submit@debbugs.gnu.org; Thu, 03 Sep 2015 15:25:02 -0400 Original-Received: from mail-wi0-f178.google.com ([209.85.212.178]:34312) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZXa83-0002DM-NZ for 21383-done@debbugs.gnu.org; Thu, 03 Sep 2015 15:25:00 -0400 Original-Received: by wicfx3 with SMTP id fx3so786283wic.1 for <21383-done@debbugs.gnu.org>; Thu, 03 Sep 2015 12:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=Z2TeXcIsPzD3Wcj4N6QdSZKwetim398NGC0IbV5Pxxs=; b=dR2PQiXugv2e/KbvEbaKgT8iX7R6V7ctkHtarlh8S0SiwifF6nDLeWPv1mcTI9z0fY OVIivx7417gpPwFNfNmdkYiJKPBjVdkRk/uYkSHLZhmiLocTEolPX3STYiEtiBoJMLXg zqMngHXQyme5GLo3V5abE/s3JepU02H6/+H01dynEHesKvozn2ddhakszf7bzEVQsyLX 0Lp3DkUOGxdgs2dHx0G5msNhBMNUWhH7XR/UvPj705PHWs4RS0TGeO4gpPkCmSQr7WJ0 XudYmrtgv4dmtwpjO08xlbglmIj5xtH69t95/GvJmaBSHtiNBIiKa85nEVefz4upJ6jD jHDA== X-Received: by 10.180.106.66 with SMTP id gs2mr17594128wib.14.1441308299033; Thu, 03 Sep 2015 12:24:59 -0700 (PDT) Original-Received: from [10.9.0.103] (nat.webazilla.com. [78.140.128.228]) by smtp.googlemail.com with ESMTPSA id ik8sm39251083wjb.8.2015.09.03.12.24.57 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Sep 2015 12:24:57 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:40.0) Gecko/20100101 Thunderbird/40.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106125 Archived-At: On 09/03/2015 07:04 PM, Stefan Monnier wrote: > I think the problem is in the contract between VC itself and the > backends, because VC mostly assumes that default-directory doesn't > matter and uses absolute file names instead (that was the original > design), whereas for many backends this is sometimes inconvenient so > they occasionally rely on default-directory instead, which happens to > work as well, tho it's mostly an accident. Yes. >> And are you talking about FILE arg to vc-status, or e.g. vc-git-status? > > vc-git-status (and other backend operations). That might be viable. But the commands that don't use FILE currently only need the root, so we could avoid passing the argument in entirely. > Right, we could fix the problem by keeping the original design and > making sure the backends actually follow it, but I'm not sure it's the > better design nowadays (and since using default-directory happens to > work in 99% of the cases, it's hard to make sure we really fix all cases > where we incorrectly rely on default-directory being the right parent of > the absolute file names we get). That is true. But could we abandon the current design for all backends? Some of the older ones still don't have vc-root implemented (because it's impossible for some of them?), and until it is, vc-state and friends won't know what to set default-directory to.