From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 21383-done@debbugs.gnu.org, Jonathan H <pythonnut@gmail.com>
Subject: bug#21383: Static revisions in vc-working-revision
Date: Thu, 3 Sep 2015 22:24:51 +0300 [thread overview]
Message-ID: <55E89E83.6000501@yandex.ru> (raw)
In-Reply-To: <jwvegifmr7x.fsf-monnier+emacsbugs@gnu.org>
On 09/03/2015 07:04 PM, Stefan Monnier wrote:
> I think the problem is in the contract between VC itself and the
> backends, because VC mostly assumes that default-directory doesn't
> matter and uses absolute file names instead (that was the original
> design), whereas for many backends this is sometimes inconvenient so
> they occasionally rely on default-directory instead, which happens to
> work as well, tho it's mostly an accident.
Yes.
>> And are you talking about FILE arg to vc-status, or e.g. vc-git-status?
>
> vc-git-status (and other backend operations).
That might be viable. But the commands that don't use FILE currently
only need the root, so we could avoid passing the argument in entirely.
> Right, we could fix the problem by keeping the original design and
> making sure the backends actually follow it, but I'm not sure it's the
> better design nowadays (and since using default-directory happens to
> work in 99% of the cases, it's hard to make sure we really fix all cases
> where we incorrectly rely on default-directory being the right parent of
> the absolute file names we get).
That is true. But could we abandon the current design for all backends?
Some of the older ones still don't have vc-root implemented (because
it's impossible for some of them?), and until it is, vc-state and
friends won't know what to set default-directory to.
next prev parent reply other threads:[~2015-09-03 19:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 0:45 bug#21383: Static revisions in vc-working-revision Jonathan H
2015-08-31 4:45 ` Stefan Monnier
2015-08-31 8:47 ` Dmitry Gutov
2015-08-31 17:44 ` Stefan Monnier
2015-09-01 2:11 ` Dmitry Gutov
2015-09-01 3:55 ` Stefan Monnier
2015-09-01 12:05 ` Dmitry Gutov
2015-09-01 15:45 ` Stefan Monnier
2015-09-01 15:54 ` Dmitry Gutov
2015-09-01 16:52 ` Stefan Monnier
2015-09-01 17:23 ` Dmitry Gutov
2015-09-02 3:50 ` Stefan Monnier
2015-09-02 10:49 ` Dmitry Gutov
2015-09-02 22:44 ` Jonathan H
2015-09-03 12:56 ` Dmitry Gutov
2015-09-03 16:17 ` Stefan Monnier
2015-09-03 17:34 ` Jonathan H
2015-09-03 18:40 ` Dmitry Gutov
2015-09-03 20:07 ` Stefan Monnier
2015-09-03 22:32 ` Dmitry Gutov
2015-09-04 14:36 ` Stefan Monnier
2015-09-05 2:30 ` Dmitry Gutov
2015-09-03 16:04 ` Stefan Monnier
2015-09-03 19:24 ` Dmitry Gutov [this message]
2015-09-04 2:20 ` Stefan Monnier
2015-09-05 3:08 ` Dmitry Gutov
2015-09-05 15:12 ` Stefan Monnier
2015-09-05 20:30 ` Dmitry Gutov
2015-09-06 22:29 ` Stefan Monnier
2015-09-07 20:55 ` Using different default-directory and relative paths in VC, Was: Re: bug#21383 Dmitry Gutov
2015-09-07 22:33 ` Stefan Monnier
2015-09-07 23:29 ` Dmitry Gutov
2015-09-07 23:34 ` Dmitry Gutov
2015-09-08 1:31 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E89E83.6000501@yandex.ru \
--to=dgutov@yandex.ru \
--cc=21383-done@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=pythonnut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.