From: Dmitry Gutov <dgutov@yandex.ru>
To: Jonathan H <pythonnut@gmail.com>
Cc: 21383-done@debbugs.gnu.org
Subject: bug#21383: Static revisions in vc-working-revision
Date: Thu, 3 Sep 2015 15:56:34 +0300 [thread overview]
Message-ID: <55E84382.3030209@yandex.ru> (raw)
In-Reply-To: <CAAW2-Zd662pvfVGK169a-DuBbAX2UhMkKt6ov51hxqg3CCVWRg@mail.gmail.com>
On 09/03/2015 01:44 AM, Jonathan H wrote:
> I'm using (vc-working-revision buffer-file-name (vc-responsible-backend
> buffer-file-name)) to determine the current working revision.
>
> As far as I can tell, vc-working-revision will cache the current working
> revision in a file property, but it doesn't know when to invalidate the
> cache, so the results can be stale.
Yes, invalidation of those properties could use some improvement. But if
you're just worried about up-to-date results returned to your functions,
you could remove the property before calling `vc-working-revision'.
> In fact, in the specific case of
> git, you probably can't get any faster than a rev-parse anyway,
I wonder if that's true. Caching in a property is obviously fast, and
process calls are necessarily an order of magnitude slower (and slower
still on certain platforms).
Maybe you should write a patch and test it on Windows (or have someone
else do it), and see whether the mode-line updates don't become
perceptibly slower.
> I have a sneaking suspicion that git isn't the only backend where this
> can happen.
Probably. On the other hand, there are known backends where calling the
backend program *is* slow. Such as Bazaar or (most likely) CVS.
next prev parent reply other threads:[~2015-09-03 12:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 0:45 bug#21383: Static revisions in vc-working-revision Jonathan H
2015-08-31 4:45 ` Stefan Monnier
2015-08-31 8:47 ` Dmitry Gutov
2015-08-31 17:44 ` Stefan Monnier
2015-09-01 2:11 ` Dmitry Gutov
2015-09-01 3:55 ` Stefan Monnier
2015-09-01 12:05 ` Dmitry Gutov
2015-09-01 15:45 ` Stefan Monnier
2015-09-01 15:54 ` Dmitry Gutov
2015-09-01 16:52 ` Stefan Monnier
2015-09-01 17:23 ` Dmitry Gutov
2015-09-02 3:50 ` Stefan Monnier
2015-09-02 10:49 ` Dmitry Gutov
2015-09-02 22:44 ` Jonathan H
2015-09-03 12:56 ` Dmitry Gutov [this message]
2015-09-03 16:17 ` Stefan Monnier
2015-09-03 17:34 ` Jonathan H
2015-09-03 18:40 ` Dmitry Gutov
2015-09-03 20:07 ` Stefan Monnier
2015-09-03 22:32 ` Dmitry Gutov
2015-09-04 14:36 ` Stefan Monnier
2015-09-05 2:30 ` Dmitry Gutov
2015-09-03 16:04 ` Stefan Monnier
2015-09-03 19:24 ` Dmitry Gutov
2015-09-04 2:20 ` Stefan Monnier
2015-09-05 3:08 ` Dmitry Gutov
2015-09-05 15:12 ` Stefan Monnier
2015-09-05 20:30 ` Dmitry Gutov
2015-09-06 22:29 ` Stefan Monnier
2015-09-07 20:55 ` Using different default-directory and relative paths in VC, Was: Re: bug#21383 Dmitry Gutov
2015-09-07 22:33 ` Stefan Monnier
2015-09-07 23:29 ` Dmitry Gutov
2015-09-07 23:34 ` Dmitry Gutov
2015-09-08 1:31 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E84382.3030209@yandex.ru \
--to=dgutov@yandex.ru \
--cc=21383-done@debbugs.gnu.org \
--cc=pythonnut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.